diff mbox series

doc: fix incorrect example for specifying log level

Message ID 20200317083106.17727-1-xiaolong.ye@intel.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series doc: fix incorrect example for specifying log level |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Xiaolong Ye March 17, 2020, 8:31 a.m. UTC 
  Now we need to add prefix like lib. to enable the log.

Fixes: ffb9fd1b0808 ("log: update legacy modules dynamic logs regex")
Cc: stable@dpdk.org

Reported-by: Haiyue Wang <haiyue.wang@intel.com>
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 doc/guides/linux_gsg/eal_args.include.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger March 17, 2020, 5:18 p.m. UTC | #1 
On Tue, 17 Mar 2020 16:31:06 +0800
Xiaolong Ye <xiaolong.ye@intel.com> wrote:

> Now we need to add prefix like lib. to enable the log.
> 
> Fixes: ffb9fd1b0808 ("log: update legacy modules dynamic logs regex")
> Cc: stable@dpdk.org
> 
> Reported-by: Haiyue Wang <haiyue.wang@intel.com>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  doc/guides/linux_gsg/eal_args.include.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/linux_gsg/eal_args.include.rst b/doc/guides/linux_gsg/eal_args.include.rst
> index ed8b0e35b..b48b23927 100644
> --- a/doc/guides/linux_gsg/eal_args.include.rst
> +++ b/doc/guides/linux_gsg/eal_args.include.rst
> @@ -132,7 +132,7 @@ Debugging options
>  
>      Specify log level for a specific component. For example::
>  
> -        --log-level eal:8
> +        --log-level lib.eal:8
>  
>      Can be specified multiple times.
>  

Please change numeric value to name as well. Recent versions of
DPDK allow "debug" instead of 8
Xiaolong Ye March 18, 2020, 12:57 a.m. UTC | #2 
On 03/17, Stephen Hemminger wrote:
>On Tue, 17 Mar 2020 16:31:06 +0800
>Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>
>> Now we need to add prefix like lib. to enable the log.
>> 
>> Fixes: ffb9fd1b0808 ("log: update legacy modules dynamic logs regex")
>> Cc: stable@dpdk.org
>> 
>> Reported-by: Haiyue Wang <haiyue.wang@intel.com>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>>  doc/guides/linux_gsg/eal_args.include.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/doc/guides/linux_gsg/eal_args.include.rst b/doc/guides/linux_gsg/eal_args.include.rst
>> index ed8b0e35b..b48b23927 100644
>> --- a/doc/guides/linux_gsg/eal_args.include.rst
>> +++ b/doc/guides/linux_gsg/eal_args.include.rst
>> @@ -132,7 +132,7 @@ Debugging options
>>  
>>      Specify log level for a specific component. For example::
>>  
>> -        --log-level eal:8
>> +        --log-level lib.eal:8
>>  
>>      Can be specified multiple times.
>>  
>
>Please change numeric value to name as well. Recent versions of
>DPDK allow "debug" instead of 8

Make sense, will update it.

Thanks,
Xiaolong
diff mbox series

Patch

diff --git a/doc/guides/linux_gsg/eal_args.include.rst b/doc/guides/linux_gsg/eal_args.include.rst
index ed8b0e35b..b48b23927 100644
--- a/doc/guides/linux_gsg/eal_args.include.rst
+++ b/doc/guides/linux_gsg/eal_args.include.rst
@@ -132,7 +132,7 @@  Debugging options
 
     Specify log level for a specific component. For example::
 
-        --log-level eal:8
+        --log-level lib.eal:8
 
     Can be specified multiple times.