diff mbox series

net/bnxt: don't log at error level on flow creation

Message ID 20191028165339.28703-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Ajit Khaparde
Headers
Series net/bnxt: don't log at error level on flow creation |

Checks

Context Check Description
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/Intel-compilation fail Compilation issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed

Commit Message

Stephen Hemminger Oct. 28, 2019, 4:53 p.m. UTC 
  Creating a flow is a normal event; should not be logged at error level.

Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnxt/bnxt_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ajit Khaparde Oct. 31, 2019, 6:23 p.m. UTC | #1 
On Mon, Oct 28, 2019 at 9:53 AM Stephen Hemminger <
stephen@networkplumber.org> wrote:

> Creating a flow is a normal event; should not be logged at error level.
>
> Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>


> ---
>  drivers/net/bnxt/bnxt_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index cad232aba7da..8f386cdf1331 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
>                 }
>
>                 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
> -               PMD_DRV_LOG(ERR, "Successfully created flow.\n");
> +               PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
>                 STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
>                 bnxt_release_flow_lock(bp);
>                 return flow;
> --
> 2.20.1
>
>
Ajit Khaparde Oct. 31, 2019, 6:35 p.m. UTC | #2 
On Thu, Oct 31, 2019 at 11:23 AM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:

>
>
> On Mon, Oct 28, 2019 at 9:53 AM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
>
>> Creating a flow is a normal event; should not be logged at error level.
>>
>> Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow")
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>

Patch applied to dpdk-next-net-brcm.

>
>
>> ---
>>  drivers/net/bnxt/bnxt_flow.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
>> index cad232aba7da..8f386cdf1331 100644
>> --- a/drivers/net/bnxt/bnxt_flow.c
>> +++ b/drivers/net/bnxt/bnxt_flow.c
>> @@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
>>                 }
>>
>>                 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
>> -               PMD_DRV_LOG(ERR, "Successfully created flow.\n");
>> +               PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
>>                 STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
>>                 bnxt_release_flow_lock(bp);
>>                 return flow;
>> --
>> 2.20.1
>>
>>
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index cad232aba7da..8f386cdf1331 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -1758,7 +1758,7 @@  bnxt_flow_create(struct rte_eth_dev *dev,
 		}
 
 		STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
-		PMD_DRV_LOG(ERR, "Successfully created flow.\n");
+		PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
 		STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
 		bnxt_release_flow_lock(bp);
 		return flow;