[2/2] doc: remove flow API from the feature list
diff mbox series

Message ID 20191025125118.47189-2-ferruh.yigit@intel.com
State New
Delegated to: Ferruh Yigit
Headers show
Series
  • [1/2] doc: add PMD filtering features back
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit Oct. 25, 2019, 12:51 p.m. UTC
"Flow API" is a method/API to implement various filtering features, on
its own it doesn't give much context on what features are provided. And
it is not really a feature, so doesn't fit into feature table.

Also since other filtering related APIs, 'filter_ctrl', has been
deprecated, flow API is the only supported way in the DPDK to implement
filtering options, if related filter options announced by PMDs, listing
"Flow API" as implemented is redundant information.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Thomas Monjalon <thomas@monjalon.net>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Jerin Jacob <jerinj@marvell.com>
---
 doc/guides/nics/features/default.ini | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Monjalon Oct. 25, 2019, 1:26 p.m. UTC | #1
25/10/2019 14:51, Ferruh Yigit:
> "Flow API" is a method/API to implement various filtering features, on
> its own it doesn't give much context on what features are provided. And
> it is not really a feature, so doesn't fit into feature table.
> 
> Also since other filtering related APIs, 'filter_ctrl', has been
> deprecated, flow API is the only supported way in the DPDK to implement
> filtering options, if related filter options announced by PMDs, listing
> "Flow API" as implemented is redundant information.

I fully agree with this explanation.
rte_flow is the only supported API for flow offloads.
That's why we must remove the legacy API.

> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> -Flow API             =

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Jerin Jacob Oct. 25, 2019, 1:39 p.m. UTC | #2
On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 25/10/2019 14:51, Ferruh Yigit:
> > "Flow API" is a method/API to implement various filtering features, on
> > its own it doesn't give much context on what features are provided. And
> > it is not really a feature, so doesn't fit into feature table.
> >
> > Also since other filtering related APIs, 'filter_ctrl', has been
> > deprecated, flow API is the only supported way in the DPDK to implement
> > filtering options, if related filter options announced by PMDs, listing
> > "Flow API" as implemented is redundant information.
>
> I fully agree with this explanation.
> rte_flow is the only supported API for flow offloads.
> That's why we must remove the legacy API.
>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > --- a/doc/guides/nics/features/default.ini
> > +++ b/doc/guides/nics/features/default.ini
> > -Flow API             =
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

# Need to remove "Flow API" from doc/guides/nics/features.rst
# Need to remove refference of "Flow API" from "doc/guides/nics/*" as well.

Not specific to this patch,
Probably we need to add a new matrix to enumerate PATTERN and ACTIONS
supported by each PMD as a rte_flow feature matrix.
That some else can take it up if everyone agrees the semantics.

Patch
diff mbox series

diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index ca3b738ea..192a5168e 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -45,7 +45,6 @@  Flexible filter      =
 Hash filter          =
 Flow director        =
 Flow control         =
-Flow API             =
 Rate limitation      =
 Traffic mirroring    =
 Inline crypto        =