diff mbox series

net/ice: fix queue index for switch filter

Message ID 1571726366-34952-1-git-send-email-wei.zhao1@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series net/ice: fix queue index for switch filter |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Zhao1, Wei Oct. 22, 2019, 6:39 a.m. UTC 
  When calculate queue index for queue action in
switch filter, vsi base queue should be included.

Cc: stable@dpdk.org
Fixes: 24dc00c30907 ("net/ice: enable switch filter")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ice/ice_switch_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xiaolong Ye Oct. 22, 2019, 7:41 a.m. UTC | #1 
On 10/22, Wei Zhao wrote:
>When calculate queue index for queue action in
>switch filter, vsi base queue should be included.
>
>Cc: stable@dpdk.org
>Fixes: 24dc00c30907 ("net/ice: enable switch filter")

Should be:

Fixes: 57c4f2693588 ("net/ice: enable switch filter")
>
>Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>---
> drivers/net/ice/ice_switch_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
>index 6c96b6f..e1eaf91 100644
>--- a/drivers/net/ice/ice_switch_filter.c
>+++ b/drivers/net/ice/ice_switch_filter.c
>@@ -926,7 +926,7 @@ ice_switch_parse_action(struct ice_pf *pf,
> 	uint16_t valid_qgrop_number[MAX_QGRP_NUM_TYPE] = {
> 		 2, 4, 8, 16, 32, 64, 128};
> 
>-	base_queue = pf->base_queue;
>+	base_queue = pf->base_queue + vsi->base_queue;
> 	for (action = actions; action->type !=
> 			RTE_FLOW_ACTION_TYPE_END; action++) {
> 		action_type = action->type;
>-- 
>2.7.5
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Xiaolong Ye Oct. 22, 2019, 7:45 a.m. UTC | #2 
On 10/22, Wei Zhao wrote:
>When calculate queue index for queue action in
>switch filter, vsi base queue should be included.
>
>Cc: stable@dpdk.org
>Fixes: 24dc00c30907 ("net/ice: enable switch filter")
>
>Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>---
> drivers/net/ice/ice_switch_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
>index 6c96b6f..e1eaf91 100644
>--- a/drivers/net/ice/ice_switch_filter.c
>+++ b/drivers/net/ice/ice_switch_filter.c
>@@ -926,7 +926,7 @@ ice_switch_parse_action(struct ice_pf *pf,
> 	uint16_t valid_qgrop_number[MAX_QGRP_NUM_TYPE] = {
> 		 2, 4, 8, 16, 32, 64, 128};
> 
>-	base_queue = pf->base_queue;
>+	base_queue = pf->base_queue + vsi->base_queue;
> 	for (action = actions; action->type !=
> 			RTE_FLOW_ACTION_TYPE_END; action++) {
> 		action_type = action->type;
>-- 
>2.7.5
>

Applied to dpdk-next-net-intel.
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 6c96b6f..e1eaf91 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -926,7 +926,7 @@  ice_switch_parse_action(struct ice_pf *pf,
 	uint16_t valid_qgrop_number[MAX_QGRP_NUM_TYPE] = {
 		 2, 4, 8, 16, 32, 64, 128};
 
-	base_queue = pf->base_queue;
+	base_queue = pf->base_queue + vsi->base_queue;
 	for (action = actions; action->type !=
 			RTE_FLOW_ACTION_TYPE_END; action++) {
 		action_type = action->type;