diff mbox series

Revert "net/mlx: support IOVA VA mode"

Message ID 20190607230841.17125-1-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Revert "net/mlx: support IOVA VA mode" |

Checks

Context Check Description
ci/Intel-compilation fail apply issues
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger June 7, 2019, 11:08 p.m. UTC 
  From: Stephen Hemminger <sthemmin@microsoft.com>

This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
That commit breaks support for netvsc PMD with MLX SRIOV
on both Hyper-V and Azure.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/mlx4/mlx4.c | 4 ++--
 drivers/net/mlx5/mlx5.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Stephen Hemminger June 12, 2019, 9:39 p.m. UTC | #1 
On Fri,  7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Ping. What happened to this patch?
Stephen Hemminger June 20, 2019, 10:30 p.m. UTC | #2 
On Fri,  7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Could one of the MLX maintainers review this. DPDK 19.08 is broken
right now on Hyper-V/Azure.
Stephen Hemminger July 9, 2019, 2:39 p.m. UTC | #3 
On Fri,  7 Jun 2019 16:08:41 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

DPDK 19.08-rc is broken on Azure. This patch which seems to have been
ignored fixes it.
Thomas Monjalon July 10, 2019, 10:18 p.m. UTC | #4 
09/07/2019 16:39, Stephen Hemminger:
> On Fri,  7 Jun 2019 16:08:41 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> > From: Stephen Hemminger <sthemmin@microsoft.com>
> > 
> > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> > That commit breaks support for netvsc PMD with MLX SRIOV
> > on both Hyper-V and Azure.
> > 
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> 
> DPDK 19.08-rc is broken on Azure. This patch which seems to have been
> ignored fixes it.

This patch was not ignored. I was waiting for the IOVA changes
to settle down. As a result, the revert will happen because the
type RTE_KDRV_NIC_MLX is not needed anymore:
	https://patches.dpdk.org/patch/56314/

However, I don't understand how it is related to netvsc PMD.
Please could you give more details?
Thomas Monjalon July 22, 2019, 3:55 p.m. UTC | #5 
11/07/2019 00:18, Thomas Monjalon:
> 09/07/2019 16:39, Stephen Hemminger:
> > On Fri,  7 Jun 2019 16:08:41 -0700
> > Stephen Hemminger <stephen@networkplumber.org> wrote:
> > 
> > > From: Stephen Hemminger <sthemmin@microsoft.com>
> > > 
> > > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> > > That commit breaks support for netvsc PMD with MLX SRIOV
> > > on both Hyper-V and Azure.
> > > 
> > > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > 
> > DPDK 19.08-rc is broken on Azure. This patch which seems to have been
> > ignored fixes it.
> 
> This patch was not ignored. I was waiting for the IOVA changes
> to settle down. As a result, the revert will happen because the
> type RTE_KDRV_NIC_MLX is not needed anymore:
> 	https://patches.dpdk.org/patch/56314/

The revert is applied on master now.

> However, I don't understand how it is related to netvsc PMD.
> Please could you give more details?

Please did you investigate what happened?
diff mbox series

Patch

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index aa4d43fad78a..4d84a923d2ff 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -1142,8 +1142,8 @@  static struct rte_pci_driver mlx4_driver = {
 	},
 	.id_table = mlx4_pci_id_map,
 	.probe = mlx4_pci_probe,
-	.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
-		     RTE_PCI_DRV_IOVA_AS_VA,
+	.drv_flags = RTE_PCI_DRV_INTR_LSC |
+		     RTE_PCI_DRV_INTR_RMV,
 };
 
 #ifdef RTE_IBVERBS_LINK_DLOPEN
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index daadf4a7a7f9..912d80e16d09 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -2107,8 +2107,8 @@  static struct rte_pci_driver mlx5_driver = {
 	.remove = mlx5_pci_remove,
 	.dma_map = mlx5_dma_map,
 	.dma_unmap = mlx5_dma_unmap,
-	.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
-		     RTE_PCI_DRV_PROBE_AGAIN | RTE_PCI_DRV_IOVA_AS_VA,
+	.drv_flags = (RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
+		      RTE_PCI_DRV_PROBE_AGAIN),
 };
 
 #ifdef RTE_IBVERBS_LINK_DLOPEN