diff mbox series

[v1,3/9] net/mlx5: fix device arguments error detection

Message ID	1559211639-17442-4-git-send-email-matan@mellanox.com (mailing list archive)
State	Accepted, archived
Delegated to:	Shahaf Shuler
Headers	From: Matan Azrad <matan@mellanox.com> To: Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com> Cc: dev@dpdk.org, stable@dpdk.org Date: Thu, 30 May 2019 10:20:33 +0000 Message-Id: <1559211639-17442-4-git-send-email-matan@mellanox.com> In-Reply-To: <1559211639-17442-1-git-send-email-matan@mellanox.com> References: <1559211639-17442-1-git-send-email-matan@mellanox.com> Subject: [dpdk-dev] [PATCH v1 3/9] net/mlx5: fix device arguments error detection Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	mlx5: Handle data-path completions with error \| [v1,0/9] mlx5: Handle data-path completions with error [v1,1/9] net/mlx5: remove Rx queues indexes correlation [v1,2/9] net/mlx5: add log file procedure for debug data [v1,3/9] net/mlx5: fix device arguments error detection [v1,4/9] net/mlx5: mitigate Rx doorbell memory barrier [v1,5/9] net/mlx5: separate Rx queue initialization [v1,6/9] net/mlx5: extend Rx completion with error handling [v1,7/9] net/mlx5: handle Tx completion with error [v1,8/9] net/mlx5: recover secondary process Rx errors [v1,9/9] net/mlx5: recover secondary process Tx errors

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	fail	Compilation issues

Commit Message

Matan Azrad May 30, 2019, 10:20 a.m. UTC

  When bad device arguments are added to the DPDK command line, the PMD
ignores all the command line arguments specified by the user and uses
the default values instead.

This behavior doesn't make sense because the user intension is to force
some device parameters and expects to get an error in case of
problematic issues with the arguments.

Stop probing and report an error in case of problematic command line
arguments.

Fixes: e72dd09b614e ("net/mlx5: add support for configuration through kvargs")
Cc: stable@dpdk.org

Signed-off-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/mlx5/mlx5.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index ebb49c8..23e397e 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -986,8 +986,10 @@  struct mlx5_dev_spawn_data {
 		return 0;
 	/* Following UGLY cast is done to pass checkpatch. */
 	kvlist = rte_kvargs_parse(devargs->args, params);
-	if (kvlist == NULL)
-		return 0;
+	if (kvlist == NULL) {
+		rte_errno = EINVAL;
+		return -rte_errno;
+	}
 	/* Process parameters. */
 	for (i = 0; (params[i] != NULL); ++i) {
 		if (rte_kvargs_count(kvlist, params[i])) {