diff mbox series

[v4,1/8] net/bnxt: update release notes for bnxt

Message ID 20190529150234.15166-2-lance.richardson@broadcom.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series bnxt patchset |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail Compilation issues

Commit Message

Lance Richardson May 29, 2019, 3:02 p.m. UTC 
  From: Ajit Khaparde <ajit.khaparde@broadcom.com>

Update release doc briefly describing updates to bnxt PMD,
including transmit optimization changes in the following
commits:

  commit 5c26b1706862 ("net/bnxt: support bulk free of Tx mbufs")
  commit f8dea49ef89b ("net/bnxt: optimize Tx batching code")

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
---
 doc/guides/rel_notes/release_19_08.rst | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Kevin Traynor May 29, 2019, 6:16 p.m. UTC | #1 
On 29/05/2019 16:02, Lance Richardson wrote:
> From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 
> Update release doc briefly describing updates to bnxt PMD,
> including transmit optimization changes in the following
> commits:
> 
>   commit 5c26b1706862 ("net/bnxt: support bulk free of Tx mbufs")
>   commit f8dea49ef89b ("net/bnxt: optimize Tx batching code")
> 

The commit-id's are not correct, and it should be with Fixes tag

Fixes: 5ef3592c97b9 ("net/bnxt: support bulk free of Tx mbufs")
Fixes: 220de9869bc3 ("net/bnxt: optimize Tx batching")

> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> ---
>  doc/guides/rel_notes/release_19_08.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst
> index 5ebb564b1..2b66f41f5 100644
> --- a/doc/guides/rel_notes/release_19_08.rst
> +++ b/doc/guides/rel_notes/release_19_08.rst
> @@ -54,6 +54,10 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =========================================================
>  
> +* **Updated the bnxt PMD.**
> +
> +  Updated the bnxt PMD. The major enhancements include:
> +  * Performance optimizations in non-vector Tx path
>  
>  Removed Items
>  -------------
>
Lance Richardson May 29, 2019, 8:28 p.m. UTC | #2 
On Wed, May 29, 2019 at 2:16 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> On 29/05/2019 16:02, Lance Richardson wrote:
> > From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> >
> > Update release doc briefly describing updates to bnxt PMD,
> > including transmit optimization changes in the following
> > commits:
> >
> >   commit 5c26b1706862 ("net/bnxt: support bulk free of Tx mbufs")
> >   commit f8dea49ef89b ("net/bnxt: optimize Tx batching code")
> >
>
> The commit-id's are not correct, and it should be with Fixes tag
>
> Fixes: 5ef3592c97b9 ("net/bnxt: support bulk free of Tx mbufs")
> Fixes: 220de9869bc3 ("net/bnxt: optimize Tx batching")
>

Hi Kevin,

Oops, those IDs were from the dpdk-next-net repo. Will fix, and add
"Fixes" tag...

Thanks,

    Lance
Lance Richardson May 29, 2019, 8:35 p.m. UTC | #3 
On Wed, May 29, 2019 at 4:28 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> On Wed, May 29, 2019 at 2:16 PM Kevin Traynor <ktraynor@redhat.com> wrote:
> >
> > On 29/05/2019 16:02, Lance Richardson wrote:
> > > From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > >
> > > Update release doc briefly describing updates to bnxt PMD,
> > > including transmit optimization changes in the following
> > > commits:
> > >
> > >   commit 5c26b1706862 ("net/bnxt: support bulk free of Tx mbufs")
> > >   commit f8dea49ef89b ("net/bnxt: optimize Tx batching code")
> > >
> >
> > The commit-id's are not correct, and it should be with Fixes tag
> >
> > Fixes: 5ef3592c97b9 ("net/bnxt: support bulk free of Tx mbufs")
> > Fixes: 220de9869bc3 ("net/bnxt: optimize Tx batching")
> >
>
> Hi Kevin,
>
> Oops, those IDs were from the dpdk-next-net repo. Will fix, and add
> "Fixes" tag...
>
> Thanks,
>
>     Lance

I jumped the gun... what is wrong with the commit IDs?

dpdk_upstream lance$ git remote show origin | grep URL
  Fetch URL: https://github.com/DPDK/dpdk.git
  Push  URL: https://github.com/DPDK/dpdk.git
dpdk_upstream lance$ git log --oneline -s --abbrev=12 | grep bnxt | head
5ef3592c97b9 net/bnxt: support bulk free of Tx mbufs
220de9869bc3 net/bnxt: optimize Tx batching

Thanks,

   Lance
Lance Richardson May 29, 2019, 8:38 p.m. UTC | #4 
I see now that you had fixed them up... sorry for the noise.

On Wed, May 29, 2019 at 4:35 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> On Wed, May 29, 2019 at 4:28 PM Lance Richardson
> <lance.richardson@broadcom.com> wrote:
> >
> > On Wed, May 29, 2019 at 2:16 PM Kevin Traynor <ktraynor@redhat.com> wrote:
> > >
> > > On 29/05/2019 16:02, Lance Richardson wrote:
> > > > From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > > >
> > > > Update release doc briefly describing updates to bnxt PMD,
> > > > including transmit optimization changes in the following
> > > > commits:
> > > >
> > > >   commit 5c26b1706862 ("net/bnxt: support bulk free of Tx mbufs")
> > > >   commit f8dea49ef89b ("net/bnxt: optimize Tx batching code")
> > > >
> > >
> > > The commit-id's are not correct, and it should be with Fixes tag
> > >
> > > Fixes: 5ef3592c97b9 ("net/bnxt: support bulk free of Tx mbufs")
> > > Fixes: 220de9869bc3 ("net/bnxt: optimize Tx batching")
> > >
> >
> > Hi Kevin,
> >
> > Oops, those IDs were from the dpdk-next-net repo. Will fix, and add
> > "Fixes" tag...
> >
> > Thanks,
> >
> >     Lance
>
> I jumped the gun... what is wrong with the commit IDs?
>
> dpdk_upstream lance$ git remote show origin | grep URL
>   Fetch URL: https://github.com/DPDK/dpdk.git
>   Push  URL: https://github.com/DPDK/dpdk.git
> dpdk_upstream lance$ git log --oneline -s --abbrev=12 | grep bnxt | head
> 5ef3592c97b9 net/bnxt: support bulk free of Tx mbufs
> 220de9869bc3 net/bnxt: optimize Tx batching
>
> Thanks,
>
>    Lance
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst
index 5ebb564b1..2b66f41f5 100644
--- a/doc/guides/rel_notes/release_19_08.rst
+++ b/doc/guides/rel_notes/release_19_08.rst
@@ -54,6 +54,10 @@  New Features
      Also, make sure to start the actual text at the margin.
      =========================================================
 
+* **Updated the bnxt PMD.**
+
+  Updated the bnxt PMD. The major enhancements include:
+  * Performance optimizations in non-vector Tx path
 
 Removed Items
 -------------