[4/4] raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30
Checks
Commit Message
GCC9 gives warnings if the parameter passed to printf for "%s" could be
NULL, so we need to add checks in some cases to ensure that is not the
case.
Fixes: 3298fa4853b8 ("raw/dpaa2_cmdif: introduce DPAA2 command interface driver")
Cc: nipun.gupta@nxp.com
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 2 ++
1 file changed, 2 insertions(+)
Comments
On Wed, May 1, 2019 at 9:51 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:
> GCC9 gives warnings if the parameter passed to printf for "%s" could be
> NULL, so we need to add checks in some cases to ensure that is not the
> case.
>
> Fixes: 3298fa4853b8 ("raw/dpaa2_cmdif: introduce DPAA2 command interface
> driver")
> Cc: nipun.gupta@nxp.com
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
> b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
> index 7d311b2ee..da3c7d7a6 100644
> --- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
> +++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
> @@ -270,6 +270,8 @@ dpaa2_cmdif_remove(struct rte_vdev_device *vdev)
> int ret;
>
> name = rte_vdev_device_name(vdev);
> + if (name == NULL)
> + return -1;
>
> DPAA2_CMDIF_INFO("Closing %s on NUMA node %d", name,
> rte_socket_id());
>
> --
> 2.21.0
>
>
Tested-by: David Marchand <david.marchand@redhat.com>
@@ -270,6 +270,8 @@ dpaa2_cmdif_remove(struct rte_vdev_device *vdev)
int ret;
name = rte_vdev_device_name(vdev);
+ if (name == NULL)
+ return -1;
DPAA2_CMDIF_INFO("Closing %s on NUMA node %d", name, rte_socket_id());