| Message ID | 1555075598-4988-4-git-send-email-g.singh@nxp.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Ferruh Yigit |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F1BC58CB; Fri, 12 Apr 2019 09:04:19 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70041.outbound.protection.outlook.com [40.107.7.41]) by dpdk.org (Postfix) with ESMTP id 33BDB4F9A for <dev@dpdk.org>; Fri, 12 Apr 2019 09:04:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mh5ubX/e5iIJjLSR4B8UTjgyZK+pE03Pen5kx+OLpOc=; b=TiXycE1+pVVBgHuRT1GP985sYGxKOEFfzgUtziRAbw5hjiXzx5dcocQNPLa9EdCxzKckPwdhpbBghISfjzswKvK6K5fSoYfXtL0zOBa663K0q1dwc7zaad6xXWRgqm6Z5eHoQHs6g+74UJNUdDvmhu5/niQkRN3c5FRWUqY+eQA= Received: from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by VE1PR04MB6461.eurprd04.prod.outlook.com (20.179.233.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.17; Fri, 12 Apr 2019 07:04:09 +0000 Received: from VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0]) by VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016; Fri, 12 Apr 2019 07:04:09 +0000 From: Gagandeep Singh <G.Singh@nxp.com> To: "dev@dpdk.org" <dev@dpdk.org>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com> CC: "thomas@monjalon.net" <thomas@monjalon.net>, Gagandeep Singh <G.Singh@nxp.com> Thread-Topic: [PATCH v2 03/13] net/enetc: use correct buffer allocation API Thread-Index: AQHU8P3sKTVIRuj6kUS1XV5sCI7SFg== Date: Fri, 12 Apr 2019 07:04:08 +0000 Message-ID: <1555075598-4988-4-git-send-email-g.singh@nxp.com> References: <1554745507-15089-1-git-send-email-g.singh@nxp.com> <1555075598-4988-1-git-send-email-g.singh@nxp.com> In-Reply-To: <1555075598-4988-1-git-send-email-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR0101CA0038.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::24) To VE1PR04MB6365.eurprd04.prod.outlook.com (2603:10a6:803:12a::14) x-mailer: git-send-email 1.9.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.1.67] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50f8caaf-e200-47e7-892a-08d6bf150ee7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6461; x-ms-traffictypediagnostic: VE1PR04MB6461: x-microsoft-antispam-prvs: <VE1PR04MB64614431EB2582D8D0BC82FDE1280@VE1PR04MB6461.eurprd04.prod.outlook.com> x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(376002)(366004)(396003)(346002)(189003)(199004)(6512007)(102836004)(256004)(86362001)(36756003)(486006)(25786009)(6486002)(2501003)(26005)(386003)(2906002)(66066001)(7736002)(71190400001)(14454004)(71200400001)(6506007)(53936002)(97736004)(186003)(76176011)(8676002)(52116002)(105586002)(106356001)(99286004)(446003)(81166006)(81156014)(72206003)(478600001)(50226002)(11346002)(476003)(2616005)(6116002)(54906003)(5660300002)(110136005)(4326008)(316002)(8936002)(6436002)(4744005)(68736007)(3846002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6461; H:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: pgkBDHClvKE1PG6ZD+zVhCt/IqfxccShMCB3gGihascBdvvJhZABKflDP2imojbbeh2wLQIhG8r1risd3YJNBcBd8wEn2rmOiIw+slt0hE6IzuP0krbL2IEuT6IF8C0iNZ+6vpAlp2PLOLCZCvyDBLEJ+rC+6OaNUnxBgqynlOWnepifXI4L8PvWaIptHsdmTry78EC8COQP034Li8Kdk60LlbtMBPoxpXin1KXY+hNphg5SeRC5C1auij6Fbg2AkmmVQ9ar3YUOEeNizcVw/wxglk76AJyy9Hrb1TOuw9fbvCoUchJmOb2ELxj8vcDI4IBd7R5hAIrWfgJLCtpgpHqpkwptvR3bL4hrqC4Lhj15ct+x8EzIcSc4Nz4zFgqzgajZrgdqq/HPzqI7x74U2C9ctHI3K74R8cE7xZr61oc= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50f8caaf-e200-47e7-892a-08d6bf150ee7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 07:04:08.9820 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6461 Subject: [dpdk-dev] [PATCH v2 03/13] net/enetc: use correct buffer allocation API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
ENETC PMD basic features and bug fixes
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Gagandeep Singh
April 12, 2019, 7:04 a.m. UTC
rte_pktmbuf_alloc API should be used to allocate mbuf
instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf
information.
Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx")
Cc: g.singh@nxp.com
Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
drivers/net/enetc/enetc_rxtx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Comments
12/04/2019 09:04, Gagandeep Singh: > rte_pktmbuf_alloc API should be used to allocate mbuf > instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf > information. > > Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") > Cc: g.singh@nxp.com You should mention it is also fixing big endian compilation.
> -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Friday, April 12, 2019 2:08 PM > To: Gagandeep Singh <G.Singh@nxp.com> > Cc: dev@dpdk.org; ferruh.yigit@intel.com> > > 12/04/2019 09:04, Gagandeep Singh: > > rte_pktmbuf_alloc API should be used to allocate mbuf > > instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf > > information. > > > > Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") > > Cc: g.singh@nxp.com > > You should mention it is also fixing big endian compilation. > > Ok, I'll do that. Thanks, Gagandeep Singh
diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c index a31a387..42f16ca 100644 --- a/drivers/net/enetc/enetc_rxtx.c +++ b/drivers/net/enetc/enetc_rxtx.c @@ -88,8 +88,9 @@ rx_swbd = &rx_ring->q_swbd[i]; rxbd = ENETC_RXBD(*rx_ring, i); for (j = 0; j < buff_cnt; j++) { - rx_swbd->buffer_addr = - rte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool)); + rx_swbd->buffer_addr = (void *)(uintptr_t) + rte_cpu_to_le_64((uint64_t)(uintptr_t) + rte_pktmbuf_alloc(rx_ring->mb_pool)); rxbd->w.addr = (uint64_t)(uintptr_t) rx_swbd->buffer_addr->buf_iova + rx_swbd->buffer_addr->data_off;