[v2] build: document that Meson < 0.46 will fail to list private deps
diff mbox series

Message ID 20181116105733.21200-1-bluca@debian.org
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [v2] build: document that Meson < 0.46 will fail to list private deps
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi Nov. 16, 2018, 10:57 a.m. UTC
Meson can generate the list of private dependencies of libraries
automatically for the pkgconfig file only since version 0.46.0.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
v2: corrected version, minimum required is meson 0.46

 doc/build-sdk-meson.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Bruce Richardson Nov. 16, 2018, 11:47 a.m. UTC | #1
> -----Original Message-----
> From: Luca Boccassi [mailto:bluca@debian.org]
> Sent: Friday, November 16, 2018 10:58 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; thomas@monjalon.net;
> Luca Boccassi <bluca@debian.org>
> Subject: [PATCH v2] build: document that Meson < 0.46 will fail to list
> private deps
> 
> Meson can generate the list of private dependencies of libraries
> automatically for the pkgconfig file only since version 0.46.0.
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> v2: corrected version, minimum required is meson 0.46
> 

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Nov. 18, 2018, 11:51 p.m. UTC | #2
> > Meson can generate the list of private dependencies of libraries
> > automatically for the pkgconfig file only since version 0.46.0.
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

Title updated: build: document Meson < 0.46 miss private dependencies

Patch
diff mbox series

diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
index 508e2cb64..3d8a69c29 100644
--- a/doc/build-sdk-meson.txt
+++ b/doc/build-sdk-meson.txt
@@ -203,3 +203,9 @@  From examples/helloworld/Makefile::
 
 	build:
 		@mkdir -p $@
+
+NOTE: for --static builds, DPDK needs to be built with Meson >= 0.46 in order to
+fully generate the list of private dependencies. If DPDK is built with an older
+version of Meson, it might be necessary to manually specify dependencies of DPDK
+PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or the static link
+step might fail.