diff mbox

[dpdk-dev,2/2] cmdline: remove useless intermediate buffer

Message ID 1527753808-19409-2-git-send-email-david.marchand@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand May 31, 2018, 8:03 a.m. UTC 
  Rather than copy the string, we can use a precision in the format string
given to printf.

Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 lib/librte_cmdline/cmdline_parse.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Comments

Olivier Matz June 25, 2018, 2:42 p.m. UTC | #1 
On Thu, May 31, 2018 at 10:03:28AM +0200, David Marchand wrote:
> Rather than copy the string, we can use a precision in the format string
> given to printf.
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>
diff mbox

Patch

diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c
index 961f9be..9666e90 100644
--- a/lib/librte_cmdline/cmdline_parse.c
+++ b/lib/librte_cmdline/cmdline_parse.c
@@ -208,9 +208,6 @@  cmdline_parse(struct cmdline *cl, const char * buf)
 	int err = CMDLINE_PARSE_NOMATCH;
 	int tok;
 	cmdline_parse_ctx_t *ctx;
-#ifdef RTE_LIBRTE_CMDLINE_DEBUG
-	char debug_buf[BUFSIZ];
-#endif
 	char *result_buf = result.buf;
 
 	if (!cl || !buf)
@@ -250,10 +247,8 @@  cmdline_parse(struct cmdline *cl, const char * buf)
 		return linelen;
 	}
 
-#ifdef RTE_LIBRTE_CMDLINE_DEBUG
-	strlcpy(debug_buf, buf, (linelen > 64 ? 64 : linelen));
-	debug_printf("Parse line : len=%d, <%s>\n", linelen, debug_buf);
-#endif
+	debug_printf("Parse line : len=%d, <%.*s>\n",
+		     linelen, linelen > 64 ? 64 : linelen, buf);
 
 	/* parse it !! */
 	inst = ctx[inst_num];