[dpdk-dev] vhost: Add -lfuse into the LDFLAGS list
diff mbox

Message ID 1421786998-5814-1-git-send-email-nhorman@tuxdriver.com
State Superseded, archived
Headers show

Commit Message

Neil Horman Jan. 20, 2015, 8:49 p.m. UTC
the vhost library relies on libfuse, and thats included when we do a normal
shared object build, but when we specify combined libs, its gets left out.  Add
it back in

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
---
 mk/rte.app.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Flavio Leitner Jan. 20, 2015, 10:24 p.m. UTC | #1
On Tuesday, January 20, 2015 03:49:58 PM Neil Horman wrote:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out.  Add
> it back in
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>

Fixes the build issue here.
Reported-by: Flavio Leitner <fbl@redhat.com>
Tested-by: Flavio Leitner <fbl@redhat.com>

Thanks Neil!
fbl
Thomas Monjalon Jan. 26, 2015, 9:03 p.m. UTC | #2
2015-01-20 15:49, Neil Horman:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out.  Add
> it back in
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> ---
>  mk/rte.app.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> +ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
> +LDLIBS += -lfuse
> +endif

There was already a line for -lfuse below in the file.
You are adding it in a place where it applies to every cases,
so you should remove the old special case.

Thanks

Patch
diff mbox

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index e1a0dbf..86d9865 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -127,6 +127,10 @@  ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
 LDLIBS += -lpcap
 endif
 
+ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
+LDLIBS += -lfuse
+endif
+
 LDLIBS += --start-group
 
 ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)