[v2,0/2] build: add Wformat to fix gcc compile warnings and format fixes

  On some systems Wformat-nonliteral and Wformat-security could not be
checked without Wformat also being specified this causes a compile
warning on these systems. This patchset adds Wformat to
config/meson.build and fixes some format issues that this exposed.

---

v2:
- expand explaination of patches
- suppress false postives in icc
- add fixes for format issues

Conor Walsh (2):
  build: fix gcc compile warnings by adding wformat
  net/bnxt: fix format characters for unsigned values

 config/meson.build                 | 3 ++-
 drivers/net/bnxt/tf_core/tf_core.c | 8 ++++----
 2 files changed, 6 insertions(+), 5 deletions(-)
  

On Wed, 2020-11-18 at 18:11 +0000, Conor Walsh wrote:
> On some systems Wformat-nonliteral and Wformat-security could not be
> checked without Wformat also being specified this causes a compile
> warning on these systems. This patchset adds Wformat to
> config/meson.build and fixes some format issues that this exposed.
> 
> ---
> 
> v2:
> - expand explaination of patches
> - suppress false postives in icc
> - add fixes for format issues
> 
> Conor Walsh (2):
>   build: fix gcc compile warnings by adding wformat
>   net/bnxt: fix format characters for unsigned values
> 
>  config/meson.build                 | 3 ++-
>  drivers/net/bnxt/tf_core/tf_core.c | 8 ++++----
>  2 files changed, 6 insertions(+), 5 deletions(-)

Looks good to me, but it should be cc'ed to stable as well I think
  

Thank you for your feedback Luca,
I pushed a v3 that now has stable cc'ed.
/Conor

> From: Luca Boccassi <bluca@debian.org>
> Sent: Wednesday 18 November 2020 18:38
> To: Walsh, Conor <conor.walsh@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; ajit.khaparde@broadcom.com;
> somnath.kotur@broadcom.com; stuart.schacher@broadcom.com;
> venkatkumar.duvvuru@broadcom.com; michael.wildt@broadcom.com
> Cc: dev@dpdk.org; Chen, LingliX <linglix.chen@intel.com>;
> thomas@monjalon.net
> Subject: Re: [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile
> warnings and format fixes
> 
> On Wed, 2020-11-18 at 18:11 +0000, Conor Walsh wrote:
> > On some systems Wformat-nonliteral and Wformat-security could not be
> > checked without Wformat also being specified this causes a compile
> > warning on these systems. This patchset adds Wformat to
> > config/meson.build and fixes some format issues that this exposed.
> >
> > ---
> >
> > v2:
> > - expand explaination of patches
> > - suppress false postives in icc
> > - add fixes for format issues
> >
> > Conor Walsh (2):
> >   build: fix gcc compile warnings by adding wformat
> >   net/bnxt: fix format characters for unsigned values
> >
> >  config/meson.build                 | 3 ++-
> >  drivers/net/bnxt/tf_core/tf_core.c | 8 ++++----
> >  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> Looks good to me, but it should be cc'ed to stable as well I think
> 
> --
> Kind regards,
> Luca Boccassi