mbox series

[V4,0/3] add FEC support

Message ID 1599722646-19188-1-git-send-email-humin29@huawei.com (mailing list archive)
Headers
Series add FEC support |

Message

humin (Q) Sept. 10, 2020, 7:24 a.m. UTC 
  This series add FEC support for ethdev.

Min Hu (Connor) (3):
  ethdev: introduce FEC API
  net/hns3: support FEC
  app/testpmd: add FEC command

 app/test-pmd/cmdline.c                   | 219 +++++++++++++++++++++++++++++++
 app/test-pmd/config.c                    |  54 ++++++++
 app/test-pmd/testpmd.h                   |   2 +
 drivers/net/hns3/hns3_cmd.h              |  19 ++-
 drivers/net/hns3/hns3_ethdev.c           | 156 ++++++++++++++++++++++
 drivers/net/hns3/hns3_ethdev.h           |   1 +
 lib/librte_ethdev/rte_ethdev.c           |  50 +++++++
 lib/librte_ethdev/rte_ethdev.h           |  75 +++++++++++
 lib/librte_ethdev/rte_ethdev_core.h      |  77 +++++++++++
 lib/librte_ethdev/rte_ethdev_version.map |   5 +
 10 files changed, 657 insertions(+), 1 deletion(-)

Comments

Ajit Khaparde Sept. 10, 2020, 9:02 p.m. UTC | #1 
On Thu, Sep 10, 2020 at 12:26 AM Min Hu (Connor) <humin29@huawei.com> wrote:

> This series add FEC support for ethdev.
>
Can you tell why DPDK applications need this info?


>
> Min Hu (Connor) (3):
>   ethdev: introduce FEC API
>   net/hns3: support FEC
>   app/testpmd: add FEC command
>
>  app/test-pmd/cmdline.c                   | 219
> +++++++++++++++++++++++++++++++
>  app/test-pmd/config.c                    |  54 ++++++++
>  app/test-pmd/testpmd.h                   |   2 +
>  drivers/net/hns3/hns3_cmd.h              |  19 ++-
>  drivers/net/hns3/hns3_ethdev.c           | 156 ++++++++++++++++++++++
>  drivers/net/hns3/hns3_ethdev.h           |   1 +
>  lib/librte_ethdev/rte_ethdev.c           |  50 +++++++
>  lib/librte_ethdev/rte_ethdev.h           |  75 +++++++++++
>  lib/librte_ethdev/rte_ethdev_core.h      |  77 +++++++++++
>  lib/librte_ethdev/rte_ethdev_version.map |   5 +
>  10 files changed, 657 insertions(+), 1 deletion(-)
>
> --
> 2.7.4
>
>
humin (Q) Sept. 11, 2020, 8:39 a.m. UTC | #2 
Hi, Ajit Khaparde:

Forward error correction (FEC) is a bit error correction mode.
It adds error correction information to data packets at the
transmit end, and uses the error correction information to correct
the bit errors generated during data packet transmission at the
receive end. This improves signal quality.

FEC ensures signal transmission quality in high-speed networks.
DPDK application needs FEC information from device if user want to
set FEC mode to ensures signal transmission quality.

For example, if user wants to set FEC mode for device by 
"rte_eth_fec_set",FEC capability of device getting from 
"rte_eth_fec_get_capability" is needed by user. AS FEC mode should be 
within the limits of FEC capability of device.

在 2020/9/11 5:02, Ajit Khaparde 写道:
> 
> On Thu, Sep 10, 2020 at 12:26 AM Min Hu (Connor) <humin29@huawei.com 
> <mailto:humin29@huawei.com>> wrote:
> 
>     This series add FEC support for ethdev.
> 
> Can you tell why DPDK applications need this info?
> 
> 
>     Min Hu (Connor) (3):
>        ethdev: introduce FEC API
>        net/hns3: support FEC
>        app/testpmd: add FEC command
> 
>       app/test-pmd/cmdline.c                   | 219
>     +++++++++++++++++++++++++++++++
>       app/test-pmd/config.c                    |  54 ++++++++
>       app/test-pmd/testpmd.h                   |   2 +
>       drivers/net/hns3/hns3_cmd.h              |  19 ++-
>       drivers/net/hns3/hns3_ethdev.c           | 156 ++++++++++++++++++++++
>       drivers/net/hns3/hns3_ethdev.h           |   1 +
>       lib/librte_ethdev/rte_ethdev.c           |  50 +++++++
>       lib/librte_ethdev/rte_ethdev.h           |  75 +++++++++++
>       lib/librte_ethdev/rte_ethdev_core.h      |  77 +++++++++++
>       lib/librte_ethdev/rte_ethdev_version.map |   5 +
>       10 files changed, 657 insertions(+), 1 deletion(-)
> 
>     -- 
>     2.7.4
>
humin (Q) Sept. 16, 2020, 12:37 p.m. UTC | #3 
Hi, all
	Are there any comment?

Thanks
Connor

在 2020/9/10 15:24, Min Hu (Connor) 写道:
> This series add FEC support for ethdev.
> 
> Min Hu (Connor) (3):
>    ethdev: introduce FEC API
>    net/hns3: support FEC
>    app/testpmd: add FEC command
> 
>   app/test-pmd/cmdline.c                   | 219 +++++++++++++++++++++++++++++++
>   app/test-pmd/config.c                    |  54 ++++++++
>   app/test-pmd/testpmd.h                   |   2 +
>   drivers/net/hns3/hns3_cmd.h              |  19 ++-
>   drivers/net/hns3/hns3_ethdev.c           | 156 ++++++++++++++++++++++
>   drivers/net/hns3/hns3_ethdev.h           |   1 +
>   lib/librte_ethdev/rte_ethdev.c           |  50 +++++++
>   lib/librte_ethdev/rte_ethdev.h           |  75 +++++++++++
>   lib/librte_ethdev/rte_ethdev_core.h      |  77 +++++++++++
>   lib/librte_ethdev/rte_ethdev_version.map |   5 +
>   10 files changed, 657 insertions(+), 1 deletion(-)
>