| Message ID | 20200907081518.46350-1-ruifeng.wang@arm.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91B6FA04B9; Mon, 7 Sep 2020 10:15:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E050F2BAB; Mon, 7 Sep 2020 10:15:33 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id AE86829AC for <dev@dpdk.org>; Mon, 7 Sep 2020 10:15:32 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D08AD6E; Mon, 7 Sep 2020 01:15:32 -0700 (PDT) Received: from net-arm-thunderx2-02.shanghai.arm.com (net-arm-thunderx2-02.shanghai.arm.com [10.169.210.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8F6003F66E; Mon, 7 Sep 2020 01:15:30 -0700 (PDT) From: Ruifeng Wang <ruifeng.wang@arm.com> To: Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com, Ruifeng Wang <ruifeng.wang@arm.com> Date: Mon, 7 Sep 2020 16:15:15 +0800 Message-Id: <20200907081518.46350-1-ruifeng.wang@arm.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 0/2] LPM changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
LPM changes
|
|
Message
Ruifeng Wang
Sept. 7, 2020, 8:15 a.m. UTC
The rte_lpm structure is exported because lookup API is inlined. But most of the structure can be hidden. Discussion at: http://patches.dpdk.org/patch/72403/ This patch set aimed to hide the rte_lpm structure as much as possible. A data free issue was identified and fixed. Ruifeng Wang (2): lpm: fix free of data structure lpm: hide internal data lib/librte_lpm/rte_lpm.c | 154 +++++++++++++++++++++++---------------- lib/librte_lpm/rte_lpm.h | 7 -- 2 files changed, 92 insertions(+), 69 deletions(-)
Comments
On Mon, Sep 7, 2020 at 10:15 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote: > > The rte_lpm structure is exported because lookup API is inlined. > But most of the structure can be hidden. > Discussion at: http://patches.dpdk.org/patch/72403/ > This patch set aimed to hide the rte_lpm structure as much as possible. > > A data free issue was identified and fixed. > > Ruifeng Wang (2): > lpm: fix free of data structure > lpm: hide internal data > > lib/librte_lpm/rte_lpm.c | 154 +++++++++++++++++++++++---------------- > lib/librte_lpm/rte_lpm.h | 7 -- > 2 files changed, 92 insertions(+), 69 deletions(-) Cc: maintainers. Those changes look good to me. Opinions? Thanks.
On 15/09/2020 15:41, David Marchand wrote: > On Mon, Sep 7, 2020 at 10:15 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote: >> >> The rte_lpm structure is exported because lookup API is inlined. >> But most of the structure can be hidden. >> Discussion at: http://patches.dpdk.org/patch/72403/ >> This patch set aimed to hide the rte_lpm structure as much as possible. >> >> A data free issue was identified and fixed. >> >> Ruifeng Wang (2): >> lpm: fix free of data structure >> lpm: hide internal data >> >> lib/librte_lpm/rte_lpm.c | 154 +++++++++++++++++++++++---------------- >> lib/librte_lpm/rte_lpm.h | 7 -- >> 2 files changed, 92 insertions(+), 69 deletions(-) > > Cc: maintainers. > > Those changes look good to me. > Opinions? > > LGTM, Gatekeeper confirmed they can handle this change. Acked-by: Kevin Traynor <ktraynor@redhat.com> > Thanks. >