mbox series

[v4,0/3] compile librte_net for windows

Message ID 20200723070825.6448-1-fady@mellanox.com (mailing list archive)
Headers
Series compile librte_net for windows |

Message

Fady Bader July 23, 2020, 7:08 a.m. UTC
  v2: * fixed style issue.

v3: * replaced htons with rte_cpu_to_be_16.
    * rebased to current master.

v4: * removed the use of rte_random in librte_net.
    * replaced htons with RTE_BE16.

Fady Bader (3):
  net: fix s_addr redefinition in Windows
  net: replace htons with RTE_BE16
  eal/windows: librte_net build on Windows

 lib/librte_eal/windows/include/netinet/in.h | 23 +++++++++++++++++++++++
 lib/librte_eal/windows/include/netinet/ip.h | 10 ++++++++++
 lib/librte_net/rte_arp.c                    | 11 +++++------
 lib/librte_net/rte_ether.c                  |  4 ++++
 lib/librte_net/rte_ether.h                  |  9 +++++++++
 lib/meson.build                             |  2 +-
 6 files changed, 52 insertions(+), 7 deletions(-)
 create mode 100644 lib/librte_eal/windows/include/netinet/in.h
 create mode 100644 lib/librte_eal/windows/include/netinet/ip.h
  

Comments

Menon, Ranjit July 24, 2020, 1:11 a.m. UTC | #1
On 7/23/2020 12:08 AM, Fady Bader wrote:
> v2: * fixed style issue.
>
> v3: * replaced htons with rte_cpu_to_be_16.
>      * rebased to current master.
>
> v4: * removed the use of rte_random in librte_net.
>      * replaced htons with RTE_BE16.
>
> Fady Bader (3):
>    net: fix s_addr redefinition in Windows
>    net: replace htons with RTE_BE16
>    eal/windows: librte_net build on Windows
>
>   lib/librte_eal/windows/include/netinet/in.h | 23 +++++++++++++++++++++++
>   lib/librte_eal/windows/include/netinet/ip.h | 10 ++++++++++
>   lib/librte_net/rte_arp.c                    | 11 +++++------
>   lib/librte_net/rte_ether.c                  |  4 ++++
>   lib/librte_net/rte_ether.h                  |  9 +++++++++
>   lib/meson.build                             |  2 +-
>   6 files changed, 52 insertions(+), 7 deletions(-)
>   create mode 100644 lib/librte_eal/windows/include/netinet/in.h
>   create mode 100644 lib/librte_eal/windows/include/netinet/ip.h

Acked-by: Ranjit Menon <ranjit.menon@intel.com>
  
Kadam, Pallavi July 24, 2020, 3:52 p.m. UTC | #2
On 7/23/2020 12:08 AM, Fady Bader wrote:
> v2: * fixed style issue.
> 
> v3: * replaced htons with rte_cpu_to_be_16.
>      * rebased to current master.
> 
> v4: * removed the use of rte_random in librte_net.
>      * replaced htons with RTE_BE16.
> 
> Fady Bader (3):
>    net: fix s_addr redefinition in Windows
>    net: replace htons with RTE_BE16
>    eal/windows: librte_net build on Windows
> 
>   lib/librte_eal/windows/include/netinet/in.h | 23 +++++++++++++++++++++++
>   lib/librte_eal/windows/include/netinet/ip.h | 10 ++++++++++
>   lib/librte_net/rte_arp.c                    | 11 +++++------
>   lib/librte_net/rte_ether.c                  |  4 ++++
>   lib/librte_net/rte_ether.h                  |  9 +++++++++
>   lib/meson.build                             |  2 +-
>   6 files changed, 52 insertions(+), 7 deletions(-)
>   create mode 100644 lib/librte_eal/windows/include/netinet/in.h
>   create mode 100644 lib/librte_eal/windows/include/netinet/ip.h
> 

Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
  
Thomas Monjalon Sept. 10, 2020, 7:55 p.m. UTC | #3
24/07/2020 03:11, Ranjit Menon:
> On 7/23/2020 12:08 AM, Fady Bader wrote:
> > v2: * fixed style issue.
> >
> > v3: * replaced htons with rte_cpu_to_be_16.
> >      * rebased to current master.
> >
> > v4: * removed the use of rte_random in librte_net.
> >      * replaced htons with RTE_BE16.
> >
> > Fady Bader (3):
> >    net: fix s_addr redefinition in Windows
> >    net: replace htons with RTE_BE16
> >    eal/windows: librte_net build on Windows
> >
> >   lib/librte_eal/windows/include/netinet/in.h | 23 +++++++++++++++++++++++
> >   lib/librte_eal/windows/include/netinet/ip.h | 10 ++++++++++
> >   lib/librte_net/rte_arp.c                    | 11 +++++------
> >   lib/librte_net/rte_ether.c                  |  4 ++++
> >   lib/librte_net/rte_ether.h                  |  9 +++++++++
> >   lib/meson.build                             |  2 +-
> >   6 files changed, 52 insertions(+), 7 deletions(-)
> >   create mode 100644 lib/librte_eal/windows/include/netinet/in.h
> >   create mode 100644 lib/librte_eal/windows/include/netinet/ip.h
> 
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>
Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>

Applied with ICMP added as Ophir requested, and some rewording.