[v2,0/4] Crypto test refactoring (second phase)

  This patchset is the phase two of the crypto test refactoring
effort. It mainly focuses on removing the PMD bitmask used
to select which PMDs are used to run the tests against.
Instead, now all PMDs will run all test cases and the capability
checking will determine which ones are supported and therefore,
are not skipped.

Since there are tests cases that require sessionless support,
a new feature flag has been added, which reflects this support per PMD.

I am CC'ing all PMD maintainers, asking for their collaboration to
test this patchset, as this might impact the testing of each PMD.


This patchset depends on:
(1) http://patches.dpdk.org/patch/68433/ (crypto/openssl: fix out-of-place encryption)
(2) http://patches.dpdk.org/patch/68434/ (cryptodev: add missing feature name)
(3) http://patches.dpdk.org/cover/68677/ (Crypto test refactoring (first phase))

Changes in v2:
- Added new commit, adding a check for out-of-place operations

Pablo de Lara (4):
  cryptodev: add sessionless support feature flag
  test/crypto: check if device supports sessionless
  test/crypto: check if device supports out-of-place ops
  test/crypto: do not check for PMD in tests

 app/test/test_cryptodev.c                    |   1 -
 app/test/test_cryptodev_aes_test_vectors.h   | 519 -------------------
 app/test/test_cryptodev_blockcipher.c        | 155 +-----
 app/test/test_cryptodev_blockcipher.h        |  18 -
 app/test/test_cryptodev_des_test_vectors.h   | 160 ------
 app/test/test_cryptodev_hash_test_vectors.h  | 219 --------
 doc/guides/cryptodevs/features/aesni_gcm.ini |   1 +
 doc/guides/cryptodevs/features/aesni_mb.ini  |   1 +
 doc/guides/cryptodevs/features/armv8.ini     |   1 +
 doc/guides/cryptodevs/features/caam_jr.ini   |   2 +-
 doc/guides/cryptodevs/features/ccp.ini       |   3 +-
 doc/guides/cryptodevs/features/default.ini   |   1 +
 doc/guides/cryptodevs/features/kasumi.ini    |   3 +-
 doc/guides/cryptodevs/features/octeontx.ini  |   1 +
 doc/guides/cryptodevs/features/octeontx2.ini |   1 +
 doc/guides/cryptodevs/features/openssl.ini   |   1 +
 doc/guides/cryptodevs/features/snow3g.ini    |   3 +-
 doc/guides/cryptodevs/features/zuc.ini       |   1 +
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c     |   3 +-
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c   |   3 +-
 drivers/crypto/armv8/rte_armv8_pmd.c         |   3 +-
 drivers/crypto/ccp/rte_ccp_pmd.c             |   3 +-
 drivers/crypto/kasumi/rte_kasumi_pmd.c       |   3 +-
 drivers/crypto/null/null_crypto_pmd.c        |   3 +-
 drivers/crypto/octeontx/otx_cryptodev_ops.c  |   3 +-
 drivers/crypto/octeontx2/otx2_cryptodev.c    |   3 +-
 drivers/crypto/openssl/rte_openssl_pmd.c     |   3 +-
 drivers/crypto/snow3g/rte_snow3g_pmd.c       |   3 +-
 drivers/crypto/zuc/rte_zuc_pmd.c             |   3 +-
 lib/librte_cryptodev/rte_cryptodev.c         |   2 +
 lib/librte_cryptodev/rte_cryptodev.h         |   2 +
 31 files changed, 67 insertions(+), 1061 deletions(-)
  

> -----Original Message-----
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Sent: Thursday, April 16, 2020 10:25 AM
> To: Doherty, Declan <declan.doherty@intel.com>; ravi1.kumar@amd.com; ruifeng.wang@arm.com;
> anoobj@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; tdu@semihalf.com; rnagadheeraj@marvell.com; adwivedi@marvell.com;
> g.singh@nxp.com; hemant.agrawal@nxp.com; jianjay.zhou@huawei.com
> Cc: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2 0/4] Crypto test refactoring (second phase)
> 
> This patchset is the phase two of the crypto test refactoring
> effort. It mainly focuses on removing the PMD bitmask used
> to select which PMDs are used to run the tests against.
> Instead, now all PMDs will run all test cases and the capability
> checking will determine which ones are supported and therefore,
> are not skipped.
> 
> Since there are tests cases that require sessionless support,
> a new feature flag has been added, which reflects this support per PMD.
> 
> I am CC'ing all PMD maintainers, asking for their collaboration to
> test this patchset, as this might impact the testing of each PMD.
> 
> 
> This patchset depends on:
> (1) http://patches.dpdk.org/patch/68433/ (crypto/openssl: fix out-of-place encryption)
> (2) http://patches.dpdk.org/patch/68434/ (cryptodev: add missing feature name)
> (3) http://patches.dpdk.org/cover/68677/ (Crypto test refactoring (first phase))
> 
> Changes in v2:
> - Added new commit, adding a check for out-of-place operations
> 
> Pablo de Lara (4):
>   cryptodev: add sessionless support feature flag
>   test/crypto: check if device supports sessionless
>   test/crypto: check if device supports out-of-place ops
>   test/crypto: do not check for PMD in tests

Series Acked-by: Fiona Trahe <fiona.trahe@intel.com>
  

> > Changes in v2:
> > - Added new commit, adding a check for out-of-place operations
> >
> > Pablo de Lara (4):
> >   cryptodev: add sessionless support feature flag
> >   test/crypto: check if device supports sessionless
> >   test/crypto: check if device supports out-of-place ops
> >   test/crypto: do not check for PMD in tests
> 
> Series Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto.

Thanks for the much needed patches. These patches were applied earlier without waiting for acknowledgement from many PMD owners so that they can be merged in RC1 and bug fixes can be added.

I would request all PMD owners to shift to cryptodev_testsuite and remove their specific testsuites otherwise no patch will be accepted for their PMDs.

Regards,
Akhil