mbox series

[0/2] app/testpmd: fix detach

Message ID 20200213155226.1024939-1-thomas@monjalon.net (mailing list archive)
Headers
Series app/testpmd: fix detach |

Message

Thomas Monjalon Feb. 13, 2020, 3:52 p.m. UTC 
  This fix is proposed as an alternative to
https://patches.dpdk.org/patch/65088/
The benefit is to fix a race condition in addition.

Thomas Monjalon (2):
  app/testpmd: rename function for detaching by devargs
  app/testpmd: fix hot-unplug detaching

 app/test-pmd/cmdline.c |  2 +-
 app/test-pmd/testpmd.c | 51 +++++++++++++++++++++++++-----------------
 app/test-pmd/testpmd.h |  2 +-
 3 files changed, 32 insertions(+), 23 deletions(-)

Comments

Ferruh Yigit Feb. 13, 2020, 6:27 p.m. UTC | #1 
On 2/13/2020 3:52 PM, Thomas Monjalon wrote:
> This fix is proposed as an alternative to
> https://patches.dpdk.org/patch/65088/
> The benefit is to fix a race condition in addition.
> 
> Thomas Monjalon (2):
>   app/testpmd: rename function for detaching by devargs
>   app/testpmd: fix hot-unplug detaching
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/master, thanks.

(Patch splitting fixed on 'detach_devargs()' return type)
Thomas Monjalon Feb. 13, 2020, 8:05 p.m. UTC | #2 
13/02/2020 19:27, Ferruh Yigit:
> On 2/13/2020 3:52 PM, Thomas Monjalon wrote:
> > This fix is proposed as an alternative to
> > https://patches.dpdk.org/patch/65088/
> > The benefit is to fix a race condition in addition.
> > 
> > Thomas Monjalon (2):
> >   app/testpmd: rename function for detaching by devargs
> >   app/testpmd: fix hot-unplug detaching
> > 
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Series applied to dpdk-next-net/master, thanks.
> 
> (Patch splitting fixed on 'detach_devargs()' return type)

Good catch, thank you.
It seems you are well testing compilation after each patch :-)