| Message ID | 20200207031437.9124-1-pallavi.kadam@intel.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23FBBA0541; Fri, 7 Feb 2020 04:15:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12CB21C07D; Fri, 7 Feb 2020 04:15:57 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B08B01C069 for <dev@dpdk.org>; Fri, 7 Feb 2020 04:15:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2020 19:15:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,411,1574150400"; d="scan'208";a="404692986" Received: from win-dpdk-pallavi.jf.intel.com (HELO localhost.localdomain) ([10.166.188.75]) by orsmga005.jf.intel.com with ESMTP; 06 Feb 2020 19:15:52 -0800 From: Pallavi Kadam <pallavi.kadam@intel.com> To: dev@dpdk.org, thomas@monjalon.net Cc: Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinjacobk@gmail.com, ranjit.menon@intel.com, antara.ganesh.kolar@intel.com, pallavi.kadam@intel.com Date: Thu, 6 Feb 2020 19:14:28 -0800 Message-Id: <20200207031437.9124-1-pallavi.kadam@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20200201000406.11060-1-pallavi.kadam@intel.com> References: <20200201000406.11060-1-pallavi.kadam@intel.com> Subject: [dpdk-dev] [PATCH v8 0/9] Windows patchset with additional EAL functionalities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
Windows patchset with additional EAL functionalities
|
|
Message
Kadam, Pallavi
Feb. 7, 2020, 3:14 a.m. UTC
This patchset includes additional functionalities for Windows EAL to support command-line parsing feature and some EAL common code on Windows. This patchset can be applied to windpdk-next-dev branch in the draft repo. v8 changes: Fixed the naming conventions. Fixed a crash encountered due to getopt function. Removed "--syslog" from help options for Windows. v7 changes: Removed Windows "eal_filesystem.h" for now and will be added later if required. Currently, Windows EAL uses common version of eal_filesystem.h. v6 changes: Removed sysfs function as it was not required on Windows. Removed syslog and dlfcn support for Windows. v5 changes: Fixed indentation in patch 6. v4 changes: Modified license/exceptions.txt file. The following files in this patch-set require license exceptions as listed: dirent.h MIT license getopt.h BSD-2-Clause license getopt.c ISC and BSD-2-Clause license Removed syslog file in Windows and added ifndef Windows around syslog classification parameters in the common code. v3 Changes: Modified generic rte_vect to add Windows support. Moved RTE_CPU* definitions to OS specific file. Added SPDX tag on top of third party files. v2 Changes: syslog.h: Replaced the BSD license boilerplate to SPDX tag. Pallavi Kadam (9): license: add license exception for windows eal: dirent.h implementation for windows eal: add additional function overrides in windows header files eal: getopt implementation for windows eal: add function to detect process type eal: include SSE4 support for windows eal: remove syslog and dlfcn support for windows build: add additional common files support eal: add minimum viable code to support parsing lib/librte_eal/common/eal_common_options.c | 14 + .../common/include/arch/x86/rte_vect.h | 4 +- lib/librte_eal/windows/eal/eal.c | 194 ++++- lib/librte_eal/windows/eal/eal_debug.c | 1 + lib/librte_eal/windows/eal/eal_lcore.c | 3 + lib/librte_eal/windows/eal/eal_thread.c | 11 + lib/librte_eal/windows/eal/getopt.c | 470 +++++++++++++ lib/librte_eal/windows/eal/include/dirent.h | 664 ++++++++++++++++++ lib/librte_eal/windows/eal/include/getopt.h | 92 +++ lib/librte_eal/windows/eal/include/pthread.h | 66 ++ lib/librte_eal/windows/eal/include/rte_os.h | 42 ++ lib/librte_eal/windows/eal/include/sched.h | 46 ++ .../windows/eal/include/sys/queue.h | 8 + lib/librte_eal/windows/eal/meson.build | 9 +- license/exceptions.txt | 12 +- 15 files changed, 1625 insertions(+), 11 deletions(-) create mode 100644 lib/librte_eal/windows/eal/getopt.c create mode 100644 lib/librte_eal/windows/eal/include/dirent.h create mode 100644 lib/librte_eal/windows/eal/include/getopt.h
Comments
> This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed the naming conventions. > Fixed a crash encountered due to getopt function. > Removed "--syslog" from help options for Windows. > Observing no issues on Windows 10, Meson 0.53.999, Clang 9.0.1. Reviewed-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed the naming conventions. > Fixed a crash encountered due to getopt function. > Removed "--syslog" from help options for Windows. > > v7 changes: > Removed Windows "eal_filesystem.h" for now and will be added > later if required. Currently, Windows EAL uses common version > of eal_filesystem.h. > > v6 changes: > Removed sysfs function as it was not required on Windows. > Removed syslog and dlfcn support for Windows. > > v5 changes: > Fixed indentation in patch 6. > > v4 changes: > Modified license/exceptions.txt file. > The following files in this patch-set require license exceptions as > listed: > dirent.h MIT license > getopt.h BSD-2-Clause license > getopt.c ISC and BSD-2-Clause license > > Removed syslog file in Windows and added ifndef Windows around syslog > classification parameters in the common code. > > v3 Changes: > Modified generic rte_vect to add Windows support. > Moved RTE_CPU* definitions to OS specific file. > Added SPDX tag on top of third party files. > > v2 Changes: > syslog.h: Replaced the BSD license boilerplate to SPDX tag. > > > Pallavi Kadam (9): > license: add license exception for windows > eal: dirent.h implementation for windows > eal: add additional function overrides in windows header files > eal: getopt implementation for windows > eal: add function to detect process type > eal: include SSE4 support for windows > eal: remove syslog and dlfcn support for windows > build: add additional common files support > eal: add minimum viable code to support parsing > > lib/librte_eal/common/eal_common_options.c | 14 + > .../common/include/arch/x86/rte_vect.h | 4 +- > lib/librte_eal/windows/eal/eal.c | 194 ++++- > lib/librte_eal/windows/eal/eal_debug.c | 1 + > lib/librte_eal/windows/eal/eal_lcore.c | 3 + > lib/librte_eal/windows/eal/eal_thread.c | 11 + > lib/librte_eal/windows/eal/getopt.c | 470 +++++++++++++ > lib/librte_eal/windows/eal/include/dirent.h | 664 ++++++++++++++++++ > lib/librte_eal/windows/eal/include/getopt.h | 92 +++ > lib/librte_eal/windows/eal/include/pthread.h | 66 ++ > lib/librte_eal/windows/eal/include/rte_os.h | 42 ++ > lib/librte_eal/windows/eal/include/sched.h | 46 ++ > .../windows/eal/include/sys/queue.h | 8 + > lib/librte_eal/windows/eal/meson.build | 9 +- > license/exceptions.txt | 12 +- > 15 files changed, 1625 insertions(+), 11 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/getopt.c > create mode 100644 lib/librte_eal/windows/eal/include/dirent.h > create mode 100644 lib/librte_eal/windows/eal/include/getopt.h > Tested-by Narcisa Vasile <navasile@microsoft.com> Acked-by Narcisa Vasile <navasile@microsoft.com>
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed the naming conventions. > Fixed a crash encountered due to getopt function. > Removed "--syslog" from help options for Windows. > > v7 changes: > Removed Windows "eal_filesystem.h" for now and will be added > later if required. Currently, Windows EAL uses common version > of eal_filesystem.h. > > v6 changes: > Removed sysfs function as it was not required on Windows. > Removed syslog and dlfcn support for Windows. > > v5 changes: > Fixed indentation in patch 6. > > v4 changes: > Modified license/exceptions.txt file. > The following files in this patch-set require license exceptions as > listed: > dirent.h MIT license > getopt.h BSD-2-Clause license > getopt.c ISC and BSD-2-Clause license > > Removed syslog file in Windows and added ifndef Windows around syslog > classification parameters in the common code. > > v3 Changes: > Modified generic rte_vect to add Windows support. > Moved RTE_CPU* definitions to OS specific file. > Added SPDX tag on top of third party files. > > v2 Changes: > syslog.h: Replaced the BSD license boilerplate to SPDX tag. > > > Pallavi Kadam (9): > license: add license exception for windows > eal: dirent.h implementation for windows > eal: add additional function overrides in windows header files > eal: getopt implementation for windows > eal: add function to detect process type > eal: include SSE4 support for windows > eal: remove syslog and dlfcn support for windows > build: add additional common files support > eal: add minimum viable code to support parsing > > lib/librte_eal/common/eal_common_options.c | 14 + > .../common/include/arch/x86/rte_vect.h | 4 +- > lib/librte_eal/windows/eal/eal.c | 194 ++++- > lib/librte_eal/windows/eal/eal_debug.c | 1 + > lib/librte_eal/windows/eal/eal_lcore.c | 3 + > lib/librte_eal/windows/eal/eal_thread.c | 11 + > lib/librte_eal/windows/eal/getopt.c | 470 +++++++++++++ > lib/librte_eal/windows/eal/include/dirent.h | 664 ++++++++++++++++++ > lib/librte_eal/windows/eal/include/getopt.h | 92 +++ > lib/librte_eal/windows/eal/include/pthread.h | 66 ++ > lib/librte_eal/windows/eal/include/rte_os.h | 42 ++ > lib/librte_eal/windows/eal/include/sched.h | 46 ++ > .../windows/eal/include/sys/queue.h | 8 + > lib/librte_eal/windows/eal/meson.build | 9 +- > license/exceptions.txt | 12 +- > 15 files changed, 1625 insertions(+), 11 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/getopt.c > create mode 100644 lib/librte_eal/windows/eal/include/dirent.h > create mode 100644 lib/librte_eal/windows/eal/include/getopt.h > Tested-by: Narcisa Vasile <navasile@microsoft.com> Acked-by: Narcisa Vasile <navasile@microsoft.com>
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed the naming conventions. > Fixed a crash encountered due to getopt function. > Removed "--syslog" from help options for Windows. > > v7 changes: > Removed Windows "eal_filesystem.h" for now and will be added > later if required. Currently, Windows EAL uses common version > of eal_filesystem.h. > > v6 changes: > Removed sysfs function as it was not required on Windows. > Removed syslog and dlfcn support for Windows. > > v5 changes: > Fixed indentation in patch 6. > > v4 changes: > Modified license/exceptions.txt file. > The following files in this patch-set require license exceptions as > listed: > dirent.h MIT license > getopt.h BSD-2-Clause license > getopt.c ISC and BSD-2-Clause license > > Removed syslog file in Windows and added ifndef Windows around syslog > classification parameters in the common code. > > v3 Changes: > Modified generic rte_vect to add Windows support. > Moved RTE_CPU* definitions to OS specific file. > Added SPDX tag on top of third party files. > > v2 Changes: > syslog.h: Replaced the BSD license boilerplate to SPDX tag. > > > Pallavi Kadam (9): > license: add license exception for windows > eal: dirent.h implementation for windows > eal: add additional function overrides in windows header files > eal: getopt implementation for windows > eal: add function to detect process type > eal: include SSE4 support for windows > eal: remove syslog and dlfcn support for windows > build: add additional common files support > eal: add minimum viable code to support parsing > > lib/librte_eal/common/eal_common_options.c | 14 + > .../common/include/arch/x86/rte_vect.h | 4 +- > lib/librte_eal/windows/eal/eal.c | 194 ++++- > lib/librte_eal/windows/eal/eal_debug.c | 1 + > lib/librte_eal/windows/eal/eal_lcore.c | 3 + > lib/librte_eal/windows/eal/eal_thread.c | 11 + > lib/librte_eal/windows/eal/getopt.c | 470 +++++++++++++ > lib/librte_eal/windows/eal/include/dirent.h | 664 ++++++++++++++++++ > lib/librte_eal/windows/eal/include/getopt.h | 92 +++ > lib/librte_eal/windows/eal/include/pthread.h | 66 ++ > lib/librte_eal/windows/eal/include/rte_os.h | 42 ++ > lib/librte_eal/windows/eal/include/sched.h | 46 ++ > .../windows/eal/include/sys/queue.h | 8 + > lib/librte_eal/windows/eal/meson.build | 9 +- > license/exceptions.txt | 12 +- > 15 files changed, 1625 insertions(+), 11 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/getopt.c > create mode 100644 lib/librte_eal/windows/eal/include/dirent.h > create mode 100644 lib/librte_eal/windows/eal/include/getopt.h > Tested-by: Narcisa Vasile <navasile@microsoft.com> Acked-by: Narcisa Vasile <navasile@microsoft.com>
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed the naming conventions. > Fixed a crash encountered due to getopt function. > Removed "--syslog" from help options for Windows. > > v7 changes: > Removed Windows "eal_filesystem.h" for now and will be added > later if required. Currently, Windows EAL uses common version > of eal_filesystem.h. > > v6 changes: > Removed sysfs function as it was not required on Windows. > Removed syslog and dlfcn support for Windows. > > v5 changes: > Fixed indentation in patch 6. > > v4 changes: > Modified license/exceptions.txt file. > The following files in this patch-set require license exceptions as > listed: > dirent.h MIT license > getopt.h BSD-2-Clause license > getopt.c ISC and BSD-2-Clause license > > Removed syslog file in Windows and added ifndef Windows around syslog > classification parameters in the common code. > > v3 Changes: > Modified generic rte_vect to add Windows support. > Moved RTE_CPU* definitions to OS specific file. > Added SPDX tag on top of third party files. > > v2 Changes: > syslog.h: Replaced the BSD license boilerplate to SPDX tag. > > > Pallavi Kadam (9): > license: add license exception for windows > eal: dirent.h implementation for windows > eal: add additional function overrides in windows header files > eal: getopt implementation for windows > eal: add function to detect process type > eal: include SSE4 support for windows > eal: remove syslog and dlfcn support for windows > build: add additional common files support > eal: add minimum viable code to support parsing > > lib/librte_eal/common/eal_common_options.c | 14 + > .../common/include/arch/x86/rte_vect.h | 4 +- > lib/librte_eal/windows/eal/eal.c | 194 ++++- > lib/librte_eal/windows/eal/eal_debug.c | 1 + > lib/librte_eal/windows/eal/eal_lcore.c | 3 + > lib/librte_eal/windows/eal/eal_thread.c | 11 + > lib/librte_eal/windows/eal/getopt.c | 470 +++++++++++++ > lib/librte_eal/windows/eal/include/dirent.h | 664 ++++++++++++++++++ > lib/librte_eal/windows/eal/include/getopt.h | 92 +++ > lib/librte_eal/windows/eal/include/pthread.h | 66 ++ > lib/librte_eal/windows/eal/include/rte_os.h | 42 ++ > lib/librte_eal/windows/eal/include/sched.h | 46 ++ > .../windows/eal/include/sys/queue.h | 8 + > lib/librte_eal/windows/eal/meson.build | 9 +- > license/exceptions.txt | 12 +- > 15 files changed, 1625 insertions(+), 11 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/getopt.c > create mode 100644 lib/librte_eal/windows/eal/include/dirent.h > create mode 100644 lib/librte_eal/windows/eal/include/getopt.h > Tested-by: Narcisa Vasile <Narcisa.Vasile@microsoft.com> Acked-by: Narcisa Vasile <Narcisa.Vasile@microsoft.com>
On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed the naming conventions. > Fixed a crash encountered due to getopt function. > Removed "--syslog" from help options for Windows. > > v7 changes: > Removed Windows "eal_filesystem.h" for now and will be added > later if required. Currently, Windows EAL uses common version > of eal_filesystem.h. > > v6 changes: > Removed sysfs function as it was not required on Windows. > Removed syslog and dlfcn support for Windows. > > v5 changes: > Fixed indentation in patch 6. > > v4 changes: > Modified license/exceptions.txt file. > The following files in this patch-set require license exceptions as > listed: > dirent.h MIT license > getopt.h BSD-2-Clause license > getopt.c ISC and BSD-2-Clause license > > Removed syslog file in Windows and added ifndef Windows around syslog > classification parameters in the common code. > > v3 Changes: > Modified generic rte_vect to add Windows support. > Moved RTE_CPU* definitions to OS specific file. > Added SPDX tag on top of third party files. > > v2 Changes: > syslog.h: Replaced the BSD license boilerplate to SPDX tag. > > > Pallavi Kadam (9): > license: add license exception for windows > eal: dirent.h implementation for windows > eal: add additional function overrides in windows header files > eal: getopt implementation for windows > eal: add function to detect process type > eal: include SSE4 support for windows > eal: remove syslog and dlfcn support for windows > build: add additional common files support > eal: add minimum viable code to support parsing > > lib/librte_eal/common/eal_common_options.c | 14 + > .../common/include/arch/x86/rte_vect.h | 4 +- > lib/librte_eal/windows/eal/eal.c | 194 ++++- > lib/librte_eal/windows/eal/eal_debug.c | 1 + > lib/librte_eal/windows/eal/eal_lcore.c | 3 + > lib/librte_eal/windows/eal/eal_thread.c | 11 + > lib/librte_eal/windows/eal/getopt.c | 470 +++++++++++++ > lib/librte_eal/windows/eal/include/dirent.h | 664 ++++++++++++++++++ > lib/librte_eal/windows/eal/include/getopt.h | 92 +++ > lib/librte_eal/windows/eal/include/pthread.h | 66 ++ > lib/librte_eal/windows/eal/include/rte_os.h | 42 ++ > lib/librte_eal/windows/eal/include/sched.h | 46 ++ > .../windows/eal/include/sys/queue.h | 8 + > lib/librte_eal/windows/eal/meson.build | 9 +- > license/exceptions.txt | 12 +- > 15 files changed, 1625 insertions(+), 11 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/getopt.c > create mode 100644 lib/librte_eal/windows/eal/include/dirent.h > create mode 100644 lib/librte_eal/windows/eal/include/getopt.h > Tested-by: Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com> Acked-by: Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>
07/02/2020 20:05, Dmitry Kozlyuk: > > This patchset includes additional functionalities for Windows EAL > > to support command-line parsing feature and some EAL common code > > on Windows. > > > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > > > v8 changes: > > Fixed the naming conventions. > > Fixed a crash encountered due to getopt function. > > Removed "--syslog" from help options for Windows. > > > > Observing no issues on Windows 10, Meson 0.53.999, Clang 9.0.1. > > Reviewed-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> Applied, thanks