mbox series

[v3,0/5] Add session-less, RSA, RSA-CRT to QAT

Message ID 20191021180919.11284-1-arkadiuszx.kusztal@intel.com (mailing list archive)
Headers
Series Add session-less, RSA, RSA-CRT to QAT |

Message

Arkadiusz Kusztal Oct. 21, 2019, 6:09 p.m. UTC
  This patchset adds session-less option, RSA algorithm, RSA-CRT algorithm
to Intel QuickAssist Technology PMD. It also adds session-less test cases
for those algorithms.
Test case for RSA signature with no padding will be sent in a later patch.

[1]crypto/qat: add sessionless implementation to asym pmd
- this patch adds sessionless option to QAT, already implemented
algorithms MOD EXP and MOD INV can be used with sessionless
[2]crypto/qat: add rsa implementation to asym pmd
- this patch adds option to use RSA with exponent private key
pair (n,d)
[3]crypto/qat: add rsa crt implementation to asym pmd
- this patch adds CRT option to RSA, to improve performance of
decryption and creating of signature

v3:
- fixes RSA test cases
- fixes output of RSA verify

Arek Kusztal (5):
  crypto/qat: add sessionless implementation to asym pmd
  crypto/qat: add rsa implementation to asym pmd
  crypto/qat: add rsa crt implementation to asym pmd
  test/crypto: add sessionless to asymmetric mod exp
  test/crypto: add rsa tests to qat and openssl with no padding

 app/test/test_cryptodev_asym.c                     | 207 +++++--
 app/test/test_cryptodev_rsa_test_vectors.h         | 226 ++++++++
 doc/guides/cryptodevs/features/qat.ini             |   4 +
 doc/guides/cryptodevs/qat.rst                      |   1 +
 doc/guides/rel_notes/release_19_11.rst             |   8 +
 .../qat/qat_adf/qat_pke_functionality_arrays.h     |  27 +
 drivers/crypto/qat/qat_asym.c                      | 633 ++++++++++++++++-----
 drivers/crypto/qat/qat_asym.h                      |  29 +-
 drivers/crypto/qat/qat_asym_capabilities.h         |  21 +
 drivers/crypto/qat/qat_asym_pmd.c                  |   5 +-
 10 files changed, 971 insertions(+), 190 deletions(-)
  

Comments

Fiona Trahe Oct. 21, 2019, 6:12 p.m. UTC | #1
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Monday, October 21, 2019 7:09 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v3 0/5] Add session-less, RSA, RSA-CRT to QAT
> 
> This patchset adds session-less option, RSA algorithm, RSA-CRT algorithm
> to Intel QuickAssist Technology PMD. It also adds session-less test cases
> for those algorithms.
> Test case for RSA signature with no padding will be sent in a later patch.
> 
> [1]crypto/qat: add sessionless implementation to asym pmd
> - this patch adds sessionless option to QAT, already implemented
> algorithms MOD EXP and MOD INV can be used with sessionless
> [2]crypto/qat: add rsa implementation to asym pmd
> - this patch adds option to use RSA with exponent private key
> pair (n,d)
> [3]crypto/qat: add rsa crt implementation to asym pmd
> - this patch adds CRT option to RSA, to improve performance of
> decryption and creating of signature
> 
> v3:
> - fixes RSA test cases
> - fixes output of RSA verify
> 
> Arek Kusztal (5):
>   crypto/qat: add sessionless implementation to asym pmd
>   crypto/qat: add rsa implementation to asym pmd
>   crypto/qat: add rsa crt implementation to asym pmd
>   test/crypto: add sessionless to asymmetric mod exp
>   test/crypto: add rsa tests to qat and openssl with no padding
> 
>  app/test/test_cryptodev_asym.c                     | 207 +++++--
>  app/test/test_cryptodev_rsa_test_vectors.h         | 226 ++++++++
>  doc/guides/cryptodevs/features/qat.ini             |   4 +
>  doc/guides/cryptodevs/qat.rst                      |   1 +
>  doc/guides/rel_notes/release_19_11.rst             |   8 +
>  .../qat/qat_adf/qat_pke_functionality_arrays.h     |  27 +
>  drivers/crypto/qat/qat_asym.c                      | 633 ++++++++++++++++-----
>  drivers/crypto/qat/qat_asym.h                      |  29 +-
>  drivers/crypto/qat/qat_asym_capabilities.h         |  21 +
>  drivers/crypto/qat/qat_asym_pmd.c                  |   5 +-
>  10 files changed, 971 insertions(+), 190 deletions(-)
> 
> --
> 2.1.0
Series
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
  
Akhil Goyal Oct. 22, 2019, 6:53 a.m. UTC | #2
Hi Arek,

This patchset is showing compilation issues in CI. Please fix and send the updated patchset.

Regards,
Akhil

> 
> This patchset adds session-less option, RSA algorithm, RSA-CRT algorithm
> to Intel QuickAssist Technology PMD. It also adds session-less test cases
> for those algorithms.
> Test case for RSA signature with no padding will be sent in a later patch.
> 
> [1]crypto/qat: add sessionless implementation to asym pmd
> - this patch adds sessionless option to QAT, already implemented
> algorithms MOD EXP and MOD INV can be used with sessionless
> [2]crypto/qat: add rsa implementation to asym pmd
> - this patch adds option to use RSA with exponent private key
> pair (n,d)
> [3]crypto/qat: add rsa crt implementation to asym pmd
> - this patch adds CRT option to RSA, to improve performance of
> decryption and creating of signature
> 


> v3:
> - fixes RSA test cases
> - fixes output of RSA verify
> 
> Arek Kusztal (5):
>   crypto/qat: add sessionless implementation to asym pmd
>   crypto/qat: add rsa implementation to asym pmd
>   crypto/qat: add rsa crt implementation to asym pmd
>   test/crypto: add sessionless to asymmetric mod exp
>   test/crypto: add rsa tests to qat and openssl with no padding
> 
>  app/test/test_cryptodev_asym.c                     | 207 +++++--
>  app/test/test_cryptodev_rsa_test_vectors.h         | 226 ++++++++
>  doc/guides/cryptodevs/features/qat.ini             |   4 +
>  doc/guides/cryptodevs/qat.rst                      |   1 +
>  doc/guides/rel_notes/release_19_11.rst             |   8 +
>  .../qat/qat_adf/qat_pke_functionality_arrays.h     |  27 +
>  drivers/crypto/qat/qat_asym.c                      | 633 ++++++++++++++++-----
>  drivers/crypto/qat/qat_asym.h                      |  29 +-
>  drivers/crypto/qat/qat_asym_capabilities.h         |  21 +
>  drivers/crypto/qat/qat_asym_pmd.c                  |   5 +-
>  10 files changed, 971 insertions(+), 190 deletions(-)
> 
> --
> 2.1.0
  
Arkadiusz Kusztal Oct. 22, 2019, 8:36 a.m. UTC | #3
Sure, I will investigate and send v4.
Thanks,
Arek

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Tuesday, October 22, 2019 8:54 AM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH v3 0/5] Add session-less, RSA, RSA-CRT to QAT
> 
> Hi Arek,
> 
> This patchset is showing compilation issues in CI. Please fix and send the
> updated patchset.
> 
> Regards,
> Akhil
> 
> >
> > This patchset adds session-less option, RSA algorithm, RSA-CRT
> > algorithm to Intel QuickAssist Technology PMD. It also adds
> > session-less test cases for those algorithms.
> > Test case for RSA signature with no padding will be sent in a later patch.
> >
> > [1]crypto/qat: add sessionless implementation to asym pmd
> > - this patch adds sessionless option to QAT, already implemented
> > algorithms MOD EXP and MOD INV can be used with sessionless
> > [2]crypto/qat: add rsa implementation to asym pmd
> > - this patch adds option to use RSA with exponent private key pair
> > (n,d)
> > [3]crypto/qat: add rsa crt implementation to asym pmd
> > - this patch adds CRT option to RSA, to improve performance of
> > decryption and creating of signature
> >
> 
> 
> > v3:
> > - fixes RSA test cases
> > - fixes output of RSA verify
> >
> > Arek Kusztal (5):
> >   crypto/qat: add sessionless implementation to asym pmd
> >   crypto/qat: add rsa implementation to asym pmd
> >   crypto/qat: add rsa crt implementation to asym pmd
> >   test/crypto: add sessionless to asymmetric mod exp
> >   test/crypto: add rsa tests to qat and openssl with no padding
> >
> >  app/test/test_cryptodev_asym.c                     | 207 +++++--
> >  app/test/test_cryptodev_rsa_test_vectors.h         | 226 ++++++++
> >  doc/guides/cryptodevs/features/qat.ini             |   4 +
> >  doc/guides/cryptodevs/qat.rst                      |   1 +
> >  doc/guides/rel_notes/release_19_11.rst             |   8 +
> >  .../qat/qat_adf/qat_pke_functionality_arrays.h     |  27 +
> >  drivers/crypto/qat/qat_asym.c                      | 633 ++++++++++++++++-----
> >  drivers/crypto/qat/qat_asym.h                      |  29 +-
> >  drivers/crypto/qat/qat_asym_capabilities.h         |  21 +
> >  drivers/crypto/qat/qat_asym_pmd.c                  |   5 +-
> >  10 files changed, 971 insertions(+), 190 deletions(-)
> >
> > --
> > 2.1.0