mbox series

[v10,0/3] add actions to modify header fields

Message ID cover.1562078184.git.dekelp@mellanox.com (mailing list archive)
Headers
Series add actions to modify header fields |

Message

Dekel Peled July 2, 2019, 2:44 p.m. UTC
  Patch [1] implemented set of header modification actions in MLX PMD, based on ethdev and testpmd updates included in [2].
This series implements support of additional header modification actions, in ethdev, testpmd, and MLX5 PMD.

Original work by Xiaoyu Min.

[1] http://patches.dpdk.org/patch/49310/
[2] http://mails.dpdk.org/archives/dev/2018-August/109672.html

---
v2: apply code review comments.
v3: apply additional code review comments.
    - Update documentation of new commands.
    - Use common general struct for all commands.
v4: apply checkpatch comments.
v5: apply additional code review comments.
    - Add 8, 16, 32 bit types to union.
    - Update struct name and documentation.
v6: expand description of new struct in h file and commit log.
v7: - Remove the common general struct with union added in v3 & v5.
    - Commands take a simple integer value, not enclosed in a structure.
    - Use separate commands for INC and DEC with 32 bit unsigned value
      of type rte_be32_t.
v8: clean redundant comments refering to removed structure.
v9: - Send the announcement of new approach (use action with single
      argument configuration) in separate patch before this series,
      see http://patches.dpdk.org/patch/55773/.
    - Add PMD release notes update.
v10: - Reorder release notes update properly.
     - Update comments for doxygen.
---

Dekel Peled (3):
  ethdev: add actions to modify TCP header fields
  app/testpmd: add actions to modify TCP header fields
  net/mlx5: update modify header using Direct Verbs

 app/test-pmd/cmdline_flow.c                 | 100 ++++++++++++
 doc/guides/prog_guide/rte_flow.rst          |  32 ++++
 doc/guides/rel_notes/release_19_08.rst      |   7 +
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  16 ++
 drivers/net/mlx5/mlx5_flow.h                |  10 +-
 drivers/net/mlx5/mlx5_flow_dv.c             | 237 ++++++++++++++++++++++++++++
 drivers/net/mlx5/mlx5_prm.h                 |  12 ++
 lib/librte_ethdev/rte_flow.c                |   4 +
 lib/librte_ethdev/rte_flow.h                |  56 +++++++
 9 files changed, 473 insertions(+), 1 deletion(-)
  

Comments

Adrien Mazarguil July 2, 2019, 3:15 p.m. UTC | #1
On Tue, Jul 02, 2019 at 05:44:25PM +0300, Dekel Peled wrote:
> Patch [1] implemented set of header modification actions in MLX PMD, based on ethdev and testpmd updates included in [2].
> This series implements support of additional header modification actions, in ethdev, testpmd, and MLX5 PMD.
> 
> Original work by Xiaoyu Min.
> 
> [1] http://patches.dpdk.org/patch/49310/
> [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html
> 
> ---
> v2: apply code review comments.
> v3: apply additional code review comments.
>     - Update documentation of new commands.
>     - Use common general struct for all commands.
> v4: apply checkpatch comments.
> v5: apply additional code review comments.
>     - Add 8, 16, 32 bit types to union.
>     - Update struct name and documentation.
> v6: expand description of new struct in h file and commit log.
> v7: - Remove the common general struct with union added in v3 & v5.
>     - Commands take a simple integer value, not enclosed in a structure.
>     - Use separate commands for INC and DEC with 32 bit unsigned value
>       of type rte_be32_t.
> v8: clean redundant comments refering to removed structure.
> v9: - Send the announcement of new approach (use action with single
>       argument configuration) in separate patch before this series,
>       see http://patches.dpdk.org/patch/55773/.
>     - Add PMD release notes update.
> v10: - Reorder release notes update properly.
>      - Update comments for doxygen.

Phew!

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
  
Ferruh Yigit July 3, 2019, 2:59 p.m. UTC | #2
On 7/2/2019 4:15 PM, Adrien Mazarguil wrote:
> On Tue, Jul 02, 2019 at 05:44:25PM +0300, Dekel Peled wrote:
>> Patch [1] implemented set of header modification actions in MLX PMD, based on ethdev and testpmd updates included in [2].
>> This series implements support of additional header modification actions, in ethdev, testpmd, and MLX5 PMD.
>>
>> Original work by Xiaoyu Min.
>>
>> [1] http://patches.dpdk.org/patch/49310/
>> [2] http://mails.dpdk.org/archives/dev/2018-August/109672.html
>>
>> ---
>> v2: apply code review comments.
>> v3: apply additional code review comments.
>>     - Update documentation of new commands.
>>     - Use common general struct for all commands.
>> v4: apply checkpatch comments.
>> v5: apply additional code review comments.
>>     - Add 8, 16, 32 bit types to union.
>>     - Update struct name and documentation.
>> v6: expand description of new struct in h file and commit log.
>> v7: - Remove the common general struct with union added in v3 & v5.
>>     - Commands take a simple integer value, not enclosed in a structure.
>>     - Use separate commands for INC and DEC with 32 bit unsigned value
>>       of type rte_be32_t.
>> v8: clean redundant comments refering to removed structure.
>> v9: - Send the announcement of new approach (use action with single
>>       argument configuration) in separate patch before this series,
>>       see http://patches.dpdk.org/patch/55773/.
>>     - Add PMD release notes update.
>> v10: - Reorder release notes update properly.
>>      - Update comments for doxygen.
> 
> Phew!
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 

Series applied to dpdk-next-net/master, thanks.