[v5,0/6] add multiple cores feature to test-compress-perf
mbox series

Message ID 1561980385-3223-1-git-send-email-tjozwiakgm@gmail.com
Headers show
Series
  • add multiple cores feature to test-compress-perf
Related show

Message

Tomasz Jóźwiak July 1, 2019, 11:26 a.m. UTC
This patchset adds multiple cores feature to compression perf tool.
All structures have been aligned and are consistent
with crypto perf tool. All test cases have constructor, runner
and destructor and can use more cores and compression devices at
the same time.

v2 changes:

  - fixed checkpatch warning
  - fixed max_nb_queue_pairs detection. Based on compression API
    if max_nb_queue_pairs = 0 that means there is no limit in
    maximum number of queue pairs
  - fixed qp setup on the last device

v3 changes:

  - merged with commit 767350e7ede791932cc050bf2a192f6527b70c15
    app/compress-perf: add prints for socket id

  - fixed wrong compression/decompression throughput calculation

v4 changes:

  - moved release notes update to patch 1
  - removed pmd cyclecount template

v5 changes:

  - changed ctx null ptr detection inside constructors

Tomasz Jozwiak (6):
  app/test-compress-perf: add weak functions for multi-cores test
  app/test-compress-perf: add ptest command line option
  app/test-compress-perf: add verification test case
  app/test-compress-perf: add benchmark test case
  doc: update dpdk-test-compress-perf description
  app/test-compress-perf: add force process termination

 app/test-compress-perf/Makefile                   |   1 +
 app/test-compress-perf/comp_perf.h                |  50 ++
 app/test-compress-perf/comp_perf_options.h        |  45 +-
 app/test-compress-perf/comp_perf_options_parse.c  |  54 +-
 app/test-compress-perf/comp_perf_test_benchmark.c | 153 ++++--
 app/test-compress-perf/comp_perf_test_benchmark.h |  25 +-
 app/test-compress-perf/comp_perf_test_common.c    | 284 ++++++++++
 app/test-compress-perf/comp_perf_test_common.h    |  41 ++
 app/test-compress-perf/comp_perf_test_verify.c    | 137 +++--
 app/test-compress-perf/comp_perf_test_verify.h    |  24 +-
 app/test-compress-perf/main.c                     | 605 +++++++++-------------
 app/test-compress-perf/meson.build                |   3 +-
 doc/guides/rel_notes/release_19_08.rst            |   3 +
 doc/guides/tools/comp_perf.rst                    |  34 +-
 14 files changed, 992 insertions(+), 467 deletions(-)
 create mode 100644 app/test-compress-perf/comp_perf.h
 create mode 100644 app/test-compress-perf/comp_perf_test_common.c
 create mode 100644 app/test-compress-perf/comp_perf_test_common.h

Comments

Akhil Goyal July 3, 2019, 10:21 a.m. UTC | #1
Hi Tomasz,

This series need a rebase.

Thanks,
Akhil

> 
> This patchset adds multiple cores feature to compression perf tool.
> All structures have been aligned and are consistent
> with crypto perf tool. All test cases have constructor, runner
> and destructor and can use more cores and compression devices at
> the same time.
> 
> v2 changes:
> 
>   - fixed checkpatch warning
>   - fixed max_nb_queue_pairs detection. Based on compression API
>     if max_nb_queue_pairs = 0 that means there is no limit in
>     maximum number of queue pairs
>   - fixed qp setup on the last device
> 
> v3 changes:
> 
>   - merged with commit 767350e7ede791932cc050bf2a192f6527b70c15
>     app/compress-perf: add prints for socket id
> 
>   - fixed wrong compression/decompression throughput calculation
> 
> v4 changes:
> 
>   - moved release notes update to patch 1
>   - removed pmd cyclecount template
> 
> v5 changes:
> 
>   - changed ctx null ptr detection inside constructors
> 
> Tomasz Jozwiak (6):
>   app/test-compress-perf: add weak functions for multi-cores test
>   app/test-compress-perf: add ptest command line option
>   app/test-compress-perf: add verification test case
>   app/test-compress-perf: add benchmark test case
>   doc: update dpdk-test-compress-perf description
>   app/test-compress-perf: add force process termination
> 
>  app/test-compress-perf/Makefile                   |   1 +
>  app/test-compress-perf/comp_perf.h                |  50 ++
>  app/test-compress-perf/comp_perf_options.h        |  45 +-
>  app/test-compress-perf/comp_perf_options_parse.c  |  54 +-
>  app/test-compress-perf/comp_perf_test_benchmark.c | 153 ++++--
>  app/test-compress-perf/comp_perf_test_benchmark.h |  25 +-
>  app/test-compress-perf/comp_perf_test_common.c    | 284 ++++++++++
>  app/test-compress-perf/comp_perf_test_common.h    |  41 ++
>  app/test-compress-perf/comp_perf_test_verify.c    | 137 +++--
>  app/test-compress-perf/comp_perf_test_verify.h    |  24 +-
>  app/test-compress-perf/main.c                     | 605 +++++++++-------------
>  app/test-compress-perf/meson.build                |   3 +-
>  doc/guides/rel_notes/release_19_08.rst            |   3 +
>  doc/guides/tools/comp_perf.rst                    |  34 +-
>  14 files changed, 992 insertions(+), 467 deletions(-)
>  create mode 100644 app/test-compress-perf/comp_perf.h
>  create mode 100644 app/test-compress-perf/comp_perf_test_common.c
>  create mode 100644 app/test-compress-perf/comp_perf_test_common.h
> 
> --
> 2.7.4
Tomasz Jóźwiak July 3, 2019, 12:20 p.m. UTC | #2
Hi Akhil,

Was rebased on Monday. Too dynamic head :)  , will do Today and add you in
Cc.

Thx, Tomek

śr., 3.07.2019, 12:21 użytkownik Akhil Goyal <akhil.goyal@nxp.com> napisał:

> Hi Tomasz,
>
> This series need a rebase.
>
> Thanks,
> Akhil
>
> >
> > This patchset adds multiple cores feature to compression perf tool.
> > All structures have been aligned and are consistent
> > with crypto perf tool. All test cases have constructor, runner
> > and destructor and can use more cores and compression devices at
> > the same time.
> >
> > v2 changes:
> >
> >   - fixed checkpatch warning
> >   - fixed max_nb_queue_pairs detection. Based on compression API
> >     if max_nb_queue_pairs = 0 that means there is no limit in
> >     maximum number of queue pairs
> >   - fixed qp setup on the last device
> >
> > v3 changes:
> >
> >   - merged with commit 767350e7ede791932cc050bf2a192f6527b70c15
> >     app/compress-perf: add prints for socket id
> >
> >   - fixed wrong compression/decompression throughput calculation
> >
> > v4 changes:
> >
> >   - moved release notes update to patch 1
> >   - removed pmd cyclecount template
> >
> > v5 changes:
> >
> >   - changed ctx null ptr detection inside constructors
> >
> > Tomasz Jozwiak (6):
> >   app/test-compress-perf: add weak functions for multi-cores test
> >   app/test-compress-perf: add ptest command line option
> >   app/test-compress-perf: add verification test case
> >   app/test-compress-perf: add benchmark test case
> >   doc: update dpdk-test-compress-perf description
> >   app/test-compress-perf: add force process termination
> >
> >  app/test-compress-perf/Makefile                   |   1 +
> >  app/test-compress-perf/comp_perf.h                |  50 ++
> >  app/test-compress-perf/comp_perf_options.h        |  45 +-
> >  app/test-compress-perf/comp_perf_options_parse.c  |  54 +-
> >  app/test-compress-perf/comp_perf_test_benchmark.c | 153 ++++--
> >  app/test-compress-perf/comp_perf_test_benchmark.h |  25 +-
> >  app/test-compress-perf/comp_perf_test_common.c    | 284 ++++++++++
> >  app/test-compress-perf/comp_perf_test_common.h    |  41 ++
> >  app/test-compress-perf/comp_perf_test_verify.c    | 137 +++--
> >  app/test-compress-perf/comp_perf_test_verify.h    |  24 +-
> >  app/test-compress-perf/main.c                     | 605
> +++++++++-------------
> >  app/test-compress-perf/meson.build                |   3 +-
> >  doc/guides/rel_notes/release_19_08.rst            |   3 +
> >  doc/guides/tools/comp_perf.rst                    |  34 +-
> >  14 files changed, 992 insertions(+), 467 deletions(-)
> >  create mode 100644 app/test-compress-perf/comp_perf.h
> >  create mode 100644 app/test-compress-perf/comp_perf_test_common.c
> >  create mode 100644 app/test-compress-perf/comp_perf_test_common.h
> >
> > --
> > 2.7.4
>
>