[v6,0/2] net/mlx5: remove TCF support from PMD
mbox series

Message ID cover.1561973011.git.motih@mellanox.com
Headers show
Series
  • net/mlx5: remove TCF support from PMD
Related show

Message

Moti Haimovsky July 1, 2019, 9:34 a.m. UTC
Today, it is possible to offload an interface flow rules to the
hardware using DPDK flow commands.
With mlx5 it is also possible to offload a limited set of flow rules
to the mlxsw (or E-switch) using the same DPDK flow commands.
A 'transfer' attribute was added to the flow rule creation command in
order to distinguish between configuring port flows and E-switch
flows. The commands destined for the E-switch are transposed to
TC-flower rules and are send, as Netlink messages, to the mlx5 driver,
or more precisely to the netdev which represent the mlxsw port.
With the addition to the PMD of E-switch configuration via DR
(direct verbs rules) it is now possible to configure the E-switch
using these commands instead of using TC-Flower messages.
Doing so will allow us to remove the TCF support and the dependency
of libmnl from the PMD.
The purpose of this RFC is to propose configuring the E-switch
flow filtering using DR, to remove the TCF support from the PMD and
to remove the dependency of the PMD in libmnl.
As for today VLAN insertion or removal is not supported in DR, this
support will be added in separate commits.

Moti Haimovsky (2):
  net/mlx5: fix crashing testpmd on null drv opts
  net/mlx5: remove TCF support from PMD

 doc/guides/nics/mlx5.rst          |   19 -
 doc/guides/platform/bluefield.rst |    4 -
 drivers/net/mlx5/Makefile         |  303 --
 drivers/net/mlx5/meson.build      |  123 +-
 drivers/net/mlx5/mlx5.c           |   32 -
 drivers/net/mlx5/mlx5.h           |    3 -
 drivers/net/mlx5/mlx5_flow.c      |   43 +-
 drivers/net/mlx5/mlx5_flow.h      |   25 -
 drivers/net/mlx5/mlx5_flow_tcf.c  | 6382 -------------------------------------
 mk/rte.app.mk                     |    2 +-
 10 files changed, 23 insertions(+), 6913 deletions(-)
 delete mode 100644 drivers/net/mlx5/mlx5_flow_tcf.c

Comments

Raslan Darawsheh July 1, 2019, 10:26 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: Moti Haimovsky <motih@mellanox.com>
> Sent: Monday, July 1, 2019 12:34 PM
> To: Raslan Darawsheh <rasland@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [Suspected-Phishing][PATCH v6 0/2] net/mlx5: remove TCF support
> from PMD
> 
> Today, it is possible to offload an interface flow rules to the hardware using
> DPDK flow commands.
> With mlx5 it is also possible to offload a limited set of flow rules to the mlxsw
> (or E-switch) using the same DPDK flow commands.
> A 'transfer' attribute was added to the flow rule creation command in order
> to distinguish between configuring port flows and E-switch flows. The
> commands destined for the E-switch are transposed to TC-flower rules and
> are send, as Netlink messages, to the mlx5 driver, or more precisely to the
> netdev which represent the mlxsw port.
> With the addition to the PMD of E-switch configuration via DR (direct verbs
> rules) it is now possible to configure the E-switch using these commands
> instead of using TC-Flower messages.
> Doing so will allow us to remove the TCF support and the dependency of
> libmnl from the PMD.
> The purpose of this RFC is to propose configuring the E-switch flow filtering
> using DR, to remove the TCF support from the PMD and to remove the
> dependency of the PMD in libmnl.
> As for today VLAN insertion or removal is not supported in DR, this support
> will be added in separate commits.
> 
> Moti Haimovsky (2):
>   net/mlx5: fix crashing testpmd on null drv opts
>   net/mlx5: remove TCF support from PMD

Series applied to next-net-mlx


Kindest regards,
Raslan Darawsheh