[0/3] Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib
mbox series

Message ID 1558005716-30083-1-git-send-email-skori@marvell.com
Headers show
  • Removing PKT_TX_IP_CKSUM from fragmentation/reassembly lib
Related show


Sunil Kumar Kori May 16, 2019, 11:21 a.m. UTC
Patchset contains below changes:
1. Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags
during fragmentation and reassemble operation implicitly.
Because of this, application is forced to use checksum offload
whether it is supported by platform or not.
Also documentation does not provide any expected value of ol_flags
in returned mbuf (reassembled or fragmented) so application will
never come to know that which offloads are enabled. So transmission may
gets failed for the platforms which does not support checksum offload.
Also, IPv6 does not contain any checksum field in header so setting
mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid.

So removing mentioned flag from the library.

2. Enabling PKT_TX_IP_CKSUM into mbuf->ol_flags in fragmentation
   and reassembly application itself.

Sunil Kumar Kori (3):
  lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags
  examples/ip_fragmentation: Enabling IP checksum offload in mbuf
  examples/ip_reassembly: Enabling IP checksum offload in mbuf

 examples/ip_fragmentation/main.c            | 7 +++++--
 examples/ip_reassembly/main.c               | 6 ++++++
 lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 -
 lib/librte_ip_frag/rte_ipv4_reassembly.c    | 3 ---
 lib/librte_ip_frag/rte_ipv6_reassembly.c    | 3 ---
 5 files changed, 11 insertions(+), 9 deletions(-)