[v2,0/6] HelloWorld example for windows

  Includes Windows-specific EAL changes and meson changes
to build the code on windows. 
v2 Changes:
Incorporated reviews from v1.
Fixed license period for updated files.
Renamed 'winapp' folder to 'windows'.
Cleaned unneeded meson changes.
Fixed code style warnings. 
Added maintainers information for windows branch

lcore mask parameter for helloworld will be supported
from v3.

Anand Rawat (6):
  eal: eal stub to add windows support
  eal: add header files to support windows
  eal: add headers for compatibility with windows environment
  eal: add minimum viable code for eal on windows
  examples: add meson changes for windows
  doc: add documention for windows

 MAINTAINERS                                   |   7 +
 config/meson.build                            |  22 +-
 config/rte_config.h                           |   7 +-
 config/x86/meson.build                        |  14 +-
 doc/guides/index.rst                          |   3 +-
 doc/guides/windows_gsg/build_dpdk.rst         |  67 ++++
 doc/guides/windows_gsg/index.rst              |  14 +
 doc/guides/windows_gsg/intro.rst              |  20 ++
 examples/meson.build                          |   9 +-
 lib/librte_eal/common/meson.build             | 160 +++++----
 lib/librte_eal/meson.build                    |  10 +-
 lib/librte_eal/windows/eal/eal.c              |  79 +++++
 lib/librte_eal/windows/eal/eal_debug.c        |  18 +
 lib/librte_eal/windows/eal/eal_lcore.c        |  99 ++++++
 lib/librte_eal/windows/eal/eal_thread.c       | 151 +++++++++
 .../windows/eal/include/exec-env/fnmatch.h    |  25 ++
 .../windows/eal/include/exec-env/pthread.h    |  19 ++
 .../windows/eal/include/exec-env/regex.h      |  52 +++
 .../eal/include/exec-env/rte_windows.h        |  47 +++
 .../windows/eal/include/exec-env/sched.h      |  41 +++
 .../windows/eal/include/exec-env/sys/queue.h  | 320 ++++++++++++++++++
 .../windows/eal/include/exec-env/unistd.h     |   7 +
 lib/librte_eal/windows/eal/meson.build        |  12 +
 lib/meson.build                               |   6 +-
 meson.build                                   |  34 +-
 25 files changed, 1135 insertions(+), 108 deletions(-)
 create mode 100644 doc/guides/windows_gsg/build_dpdk.rst
 create mode 100644 doc/guides/windows_gsg/index.rst
 create mode 100644 doc/guides/windows_gsg/intro.rst
 create mode 100644 lib/librte_eal/windows/eal/eal.c
 create mode 100644 lib/librte_eal/windows/eal/eal_debug.c
 create mode 100644 lib/librte_eal/windows/eal/eal_lcore.c
 create mode 100644 lib/librte_eal/windows/eal/eal_thread.c
 create mode 100644 lib/librte_eal/windows/eal/include/exec-env/fnmatch.h
 create mode 100644 lib/librte_eal/windows/eal/include/exec-env/pthread.h
 create mode 100644 lib/librte_eal/windows/eal/include/exec-env/regex.h
 create mode 100644 lib/librte_eal/windows/eal/include/exec-env/rte_windows.h
 create mode 100644 lib/librte_eal/windows/eal/include/exec-env/sched.h
 create mode 100644 lib/librte_eal/windows/eal/include/exec-env/sys/queue.h
 create mode 100644 lib/librte_eal/windows/eal/include/exec-env/unistd.h
 create mode 100644 lib/librte_eal/windows/eal/meson.build
  

Hi,

06/03/2019 05:16, Anand Rawat:
> v2 Changes:
> Incorporated reviews from v1.
> Fixed license period for updated files.
> Renamed 'winapp' folder to 'windows'.
> Cleaned unneeded meson changes.
> Fixed code style warnings. 
> Added maintainers information for windows branch

About the method, two advices:

- Please reply to the questions asked during the review
of the previous version before doing a new version.
It is with discussion that we can find the best solutions.

- Please use --in-reply-to for new revisions in order to have
all revisions in the same mail thread.
The best is to make all revisions as replies of the first cover letter.
  

On 3/6/2019 12:29 AM, Thomas Monjalon wrote:
> Hi,
> 
> 06/03/2019 05:16, Anand Rawat:
>> v2 Changes:
>> Incorporated reviews from v1.
>> Fixed license period for updated files.
>> Renamed 'winapp' folder to 'windows'.
>> Cleaned unneeded meson changes.
>> Fixed code style warnings.
>> Added maintainers information for windows branch
> 
> About the method, two advices:
> 
> - Please reply to the questions asked during the review
> of the previous version before doing a new version.
> It is with discussion that we can find the best solutions.
> 

Apologies, my email client was not setup to respond
as per the community guidelines. There will be more interaction
for v2

> - Please use --in-reply-to for new revisions in order to have
> all revisions in the same mail thread.
> The best is to make all revisions as replies of the first cover letter.
> 
> 

I will make sure to follow this from v3 onward.
Since now that there two cover letters, which one would you like
me to have --in-reply-to for v3
  

06/03/2019 23:45, Anand Rawat:
> > - Please use --in-reply-to for new revisions in order to have
> > all revisions in the same mail thread.
> > The best is to make all revisions as replies of the first cover letter.
> > 
> > 
> 
> I will make sure to follow this from v3 onward.
> Since now that there two cover letters, which one would you like
> me to have --in-reply-to for v3

You can continue on top of v2.