mbox series

[v2,0/3] adding rsa priv key feature flag

Message ID 20190227133258.8962-1-ayverma@marvell.com (mailing list archive)
Headers
Series adding rsa priv key feature flag |

Message

Ayuj Verma Feb. 27, 2019, 1:33 p.m. UTC 
  Some PMDs can only support RSA private key operations using CRT
(quintuple) or exponent key only. Thus it is required to add
feature flag (ff) in PMD to reflect which key type is supported
to perform sign and decrypt ops.

Thus add feature flags RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP
and RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT which would mean support
to perform a private key op using CRT keys (quintuple) or
exponent or both.

App should query PMD feature flag to check if specific
key type is supported and call operation with relevant key type.

Ayuj Verma (3):
  lib/cryptodev: add rsa priv key feature flag
  crypto/openssl: set rsa private op feature flag
  test/crypto: check for rsa key type feature flag

 drivers/crypto/openssl/rte_openssl_pmd.c |  4 +++-
 lib/librte_cryptodev/rte_cryptodev.c     |  4 ++++
 lib/librte_cryptodev/rte_cryptodev.h     |  4 ++++
 test/test/test_cryptodev_asym.c          | 26 ++++++++++++++++++++++++
 4 files changed, 37 insertions(+), 1 deletion(-)

Comments

Ayuj Verma March 5, 2019, 9:11 a.m. UTC | #1 
Hi Akhil,


Did you get a chance to look into these.


Thanks and regards

Ayuj Verma
Ayuj Verma March 13, 2019, 7:29 a.m. UTC | #2 
Hi Akhil, Fiona, Arek,


Gentle reminder.


Did you get a chance to look into these.


Thanks and regards

Ayuj Verma
Arkadiusz Kusztal March 13, 2019, 7:02 p.m. UTC | #3 
Hi Ayuj,

Sorry for delayed answer.

For me it is perfectly fine, I will ack it.

Thanks,
Arek

From: Ayuj Verma [mailto:ayverma@marvell.com]
Sent: Wednesday, March 13, 2019 8:30 AM
To: akhil.goyal@nxp.com
Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Shally Verma <shallyv@marvell.com>; Sunila Sahu <ssahu@marvell.com>; Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>; Arvind Desai <adesai@marvell.com>; dev@dpdk.org
Subject: Re: [PATCH v2 0/3] adding rsa priv key feature flag


Hi Akhil, Fiona, Arek,



Gentle reminder.



Did you get a chance to look into these.



Thanks and regards

Ayuj Verma
Arkadiusz Kusztal March 13, 2019, 7:06 p.m. UTC | #4 
V2 will be needed as test directory apparently changed its location.
Iam acking anyway.

> -----Original Message-----
> From: Ayuj Verma [mailto:ayverma@marvell.com]
> Sent: Wednesday, February 27, 2019 2:34 PM
> To: akhil.goyal@nxp.com
> Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Shally Verma <shallyv@marvell.com>; Sunila Sahu
> <ssahu@marvell.com>; Kanaka Durga Kotamarthy
> <kkotamarthy@marvell.com>; Arvind Desai <adesai@marvell.com>;
> dev@dpdk.org; Ayuj Verma <ayverma@marvell.com>
> Subject: [PATCH v2 0/3] adding rsa priv key feature flag
> 
> Some PMDs can only support RSA private key operations using CRT
> (quintuple) or exponent key only. Thus it is required to add feature flag (ff) in
> PMD to reflect which key type is supported to perform sign and decrypt ops.
> 
> Thus add feature flags RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP
> and RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT which would mean support
> to perform a private key op using CRT keys (quintuple) or exponent or both.
> 
> App should query PMD feature flag to check if specific key type is supported
> and call operation with relevant key type.
> 
> Ayuj Verma (3):
>   lib/cryptodev: add rsa priv key feature flag
>   crypto/openssl: set rsa private op feature flag
>   test/crypto: check for rsa key type feature flag
> 
>  drivers/crypto/openssl/rte_openssl_pmd.c |  4 +++-
>  lib/librte_cryptodev/rte_cryptodev.c     |  4 ++++
>  lib/librte_cryptodev/rte_cryptodev.h     |  4 ++++
>  test/test/test_cryptodev_asym.c          | 26 ++++++++++++++++++++++++
>  4 files changed, 37 insertions(+), 1 deletion(-)
> 
> --
> 2.20.0

Series-acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>