mbox series

[v2,0/6] net/tap: fixes and cleanups

Message ID 20190111203520.19944-1-stephen@networkplumber.org (mailing list archive)
Headers
Series net/tap: fixes and cleanups |

Message

Stephen Hemminger Jan. 11, 2019, 8:35 p.m. UTC 
  The tap device (used by vdev_netvsc on Azure) has a bug that
prevents it working with primary/secondary process model because
the device name generation assumed a single process.  The fix for
this is to have the kernel assign the device name (patch #5).

While investigating this, found a number of other small issues
that should be cleaned up as well.

v2
  - encorporate Keith's style feedback and ack
  - use strlcpy instead of snprintf when copying "dtap%d"
    since it makes intent clearer
  - add another message cleanup

Stephen Hemminger (7):
  net/tap: use strlcpy for interface name
  net/tap: allow full length names
  net/tap: check interface name in kvargs
  net/tap: lower the priority of log messages
  net/tap: let kernel choose tun device name
  net/tap: get rid of global tuntap_name
  net/tap: don't print pointer in info message

 drivers/net/tap/rte_eth_tap.c | 118 +++++++++++++++++++++-------------
 1 file changed, 73 insertions(+), 45 deletions(-)

Comments

Ferruh Yigit Jan. 14, 2019, 2:10 p.m. UTC | #1 
On 1/11/2019 8:35 PM, Stephen Hemminger wrote:
> The tap device (used by vdev_netvsc on Azure) has a bug that
> prevents it working with primary/secondary process model because
> the device name generation assumed a single process.  The fix for
> this is to have the kernel assign the device name (patch #5).
> 
> While investigating this, found a number of other small issues
> that should be cleaned up as well.
> 
> v2
>   - encorporate Keith's style feedback and ack
>   - use strlcpy instead of snprintf when copying "dtap%d"
>     since it makes intent clearer
>   - add another message cleanup
> 
> Stephen Hemminger (7):
>   net/tap: use strlcpy for interface name
>   net/tap: allow full length names
>   net/tap: check interface name in kvargs
>   net/tap: lower the priority of log messages
>   net/tap: let kernel choose tun device name
>   net/tap: get rid of global tuntap_name
>   net/tap: don't print pointer in info message

Series applied to dpdk-next-net/master, thanks.