mbox series

[v4,0/3] add rte ring reset api and use it to flush a ring by hash

Message ID 1546390533-53868-1-git-send-email-gavin.hu@arm.com (mailing list archive)
Headers
Series add rte ring reset api and use it to flush a ring by hash |

Message

Gavin Hu Jan. 2, 2019, 12:55 a.m. UTC
  V4: Include the ring perf test case enhancement patch in the series.

V3: Allow experimental API for meson build

V2: Fix the coding style issue(commit message line too long)

V1: To flush a ring not in use, dequeue one by one is wasting cpu cycles.
The patch is to just resetting the head and tail indices to save cpu
cycle.

Gavin Hu (2):
  ring: add reset api to flush the ring when not in use
  hash: flush the rings instead of dequeuing one by one

Joyce Kong (1):
  test/ring: ring perf test case enhancement

 lib/librte_hash/Makefile             |  2 +-
 lib/librte_hash/meson.build          |  3 ++
 lib/librte_hash/rte_cuckoo_hash.c    | 11 ++---
 lib/librte_ring/rte_ring.h           | 20 +++++++++
 lib/librte_ring/rte_ring_version.map |  7 +++
 test/test/test_ring_perf.c           | 82 ++++++++++++++++++++++++++++++++++--
 6 files changed, 114 insertions(+), 11 deletions(-)
  

Comments

Thomas Monjalon Jan. 2, 2019, 12:50 p.m. UTC | #1
02/01/2019 01:55, Gavin Hu:
> V4: Include the ring perf test case enhancement patch in the series.
> 
> V3: Allow experimental API for meson build
> 
> V2: Fix the coding style issue(commit message line too long)
> 
> V1: To flush a ring not in use, dequeue one by one is wasting cpu cycles.
> The patch is to just resetting the head and tail indices to save cpu
> cycle.

It is too late for adding this API in 19.02, but we should
review and give opinion, so it will be ready to integrate
in early February.
  
Honnappa Nagarahalli Jan. 2, 2019, 6:40 p.m. UTC | #2
> 
> 02/01/2019 01:55, Gavin Hu:
> > V4: Include the ring perf test case enhancement patch in the series.
This change is not related to this patch. Should be a separate patch?
There were comments provided:
http://mails.dpdk.org/archives/dev/2018-December/121893.html
http://mails.dpdk.org/archives/dev/2018-December/122157.html

Do you plan to address these?

> >
> > V3: Allow experimental API for meson build
> >
> > V2: Fix the coding style issue(commit message line too long)
> >
> > V1: To flush a ring not in use, dequeue one by one is wasting cpu cycles.
> > The patch is to just resetting the head and tail indices to save cpu
> > cycle.
> 
> It is too late for adding this API in 19.02, but we should review and give
> opinion, so it will be ready to integrate in early February.
>
  
Gavin Hu Jan. 3, 2019, 2:43 a.m. UTC | #3
> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Thursday, January 3, 2019 2:41 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Gavin Hu (Arm Technology
> China) <Gavin.Hu@arm.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; hemant.agrawal@nxp.com;
> bruce.richardson@intel.com; chaozhu@linux.vnet.ibm.com; nd
> <nd@arm.com>; olivier.matz@6wind.com; nd <nd@arm.com>
> Subject: RE: [PATCH v4 0/3] add rte ring reset api and use it to flush a ring by
> hash
> 
> >
> > 02/01/2019 01:55, Gavin Hu:
> > > V4: Include the ring perf test case enhancement patch in the series.
> This change is not related to this patch. Should be a separate patch?
I included it in this patch set to avoid patches scattering here and there, 
Anyway I updated the title of the cover letter to reflect this.
> There were comments provided:
> http://mails.dpdk.org/archives/dev/2018-December/121893.html
> http://mails.dpdk.org/archives/dev/2018-December/122157.html
> 
> Do you plan to address these?
One was addressed in v4 and the other was address in new v5. Thanks!
> 
> > >
> > > V3: Allow experimental API for meson build
> > >
> > > V2: Fix the coding style issue(commit message line too long)
> > >
> > > V1: To flush a ring not in use, dequeue one by one is wasting cpu cycles.
> > > The patch is to just resetting the head and tail indices to save cpu
> > > cycle.
> >
> > It is too late for adding this API in 19.02, but we should review and give
> > opinion, so it will be ready to integrate in early February.
> >