[v11,0/4] Hyper-V/Azure netvsc PMD and bus support
mbox series

Message ID 20180612232939.24793-1-stephen@networkplumber.org
Headers show
Series
  • Hyper-V/Azure netvsc PMD and bus support
Related show

Message

Stephen Hemminger June 12, 2018, 11:29 p.m. UTC
Latest version of the Hyper-V native bus (VMBus)
and network device (netvsc) drivers. This virtual device
is used in Microsoft Hyper-V in Windows 10, Windows Server 2016
and Azure. Most of this code was extracted from FreeBSD and some of
this is from earlier code donated by Brocade.

Only Linux is supported at present, but the code is split
to allow future FreeBSD and Windows support.

This version works best with 4.17 kernel which has all
the necessary patches for multi-queue support.
It is possible to use with 4.16 but then only a single
queue is supported.

Device binding is best done via driverctl; this required some
additional fixes to kernel and driverctl to work correctly.
Linux kernel vmbus support needed to support sysfs driver_override
and driverctl needed to handle non-PCI bus from udev.
 https://gitlab.com/driverctl/driverctl/merge_requests/3
 http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-April/118889.html

The remaining TODO's are:
  - Performance testing
  - Rx buffer copy avoidance (external mbuf)
  - Transparent VF support

v11
  - merge meson build into bus and netvsc patches
  - fix docbook for rte_uuid
  - fix a couple of checkpatch warnings
  - reduce logging during debug for stats

v10
  - resolve RSS setup 
  - add documentation about restart issue
  - update documentation to refer to 4.17
  - use same RSS key as MLX

v9
  - fix places where still targeted at previous release
  - add map entry for rte_uuid
  - fix meson build dependencies

v8
  - targeted for 18.08, move release notes
  - use Ted's libuuid (not FreeBSD) because that is 3 clause BSD license
    versus 2 clause in FreeBSD
  - minor checkpatch whitespace fixes

v7
  - add EAL UUID functions from BSD to remove dependency on libuuid
    this means device can be enabled by default and eliminates
    build issues
  - add support for latest NetVSP protocol (from hayaingz)
  - add probe finish for compatability with 18.05
  - rebase to 18.05-rc3



Stephen Hemminger (4):
  eal: add rte_uuid support
  bus/vmbus: add hyper-v virtual bus support
  net/netvsc: add hyper-v netvsc network device
  net/netvsc: add documentation

 MAINTAINERS                                   |   11 +
 config/common_base                            |   13 +
 config/common_linuxapp                        |    3 +
 doc/guides/nics/features/netvsc.ini           |   23 +
 doc/guides/nics/index.rst                     |    1 +
 doc/guides/nics/netvsc.rst                    |  101 ++
 doc/guides/rel_notes/known_issues.rst         |   20 +
 doc/guides/rel_notes/release_18_08.rst        |    6 +
 drivers/bus/Makefile                          |    1 +
 drivers/bus/meson.build                       |    2 +-
 drivers/bus/vmbus/Makefile                    |   36 +
 drivers/bus/vmbus/linux/Makefile              |    3 +
 drivers/bus/vmbus/linux/vmbus_bus.c           |  355 +++++
 drivers/bus/vmbus/linux/vmbus_uio.c           |  390 ++++++
 drivers/bus/vmbus/meson.build                 |   18 +
 drivers/bus/vmbus/private.h                   |  132 ++
 drivers/bus/vmbus/rte_bus_vmbus.h             |  396 ++++++
 drivers/bus/vmbus/rte_bus_vmbus_version.map   |   28 +
 drivers/bus/vmbus/rte_vmbus_reg.h             |  344 +++++
 drivers/bus/vmbus/vmbus_bufring.c             |  241 ++++
 drivers/bus/vmbus/vmbus_channel.c             |  406 ++++++
 drivers/bus/vmbus/vmbus_common.c              |  286 ++++
 drivers/bus/vmbus/vmbus_common_uio.c          |  232 ++++
 drivers/net/Makefile                          |    1 +
 drivers/net/meson.build                       |    2 +-
 drivers/net/netvsc/Makefile                   |   23 +
 drivers/net/netvsc/hn_ethdev.c                |  755 ++++++++++
 drivers/net/netvsc/hn_logs.h                  |   35 +
 drivers/net/netvsc/hn_nvs.c                   |  535 ++++++++
 drivers/net/netvsc/hn_nvs.h                   |  245 ++++
 drivers/net/netvsc/hn_rndis.c                 | 1097 +++++++++++++++
 drivers/net/netvsc/hn_rndis.h                 |   26 +
 drivers/net/netvsc/hn_rxtx.c                  | 1216 +++++++++++++++++
 drivers/net/netvsc/hn_var.h                   |  139 ++
 drivers/net/netvsc/meson.build                |    7 +
 drivers/net/netvsc/ndis.h                     |  378 +++++
 drivers/net/netvsc/rndis.h                    |  414 ++++++
 drivers/net/netvsc/rte_pmd_netvsc_version.map |    5 +
 lib/librte_eal/bsdapp/eal/Makefile            |    1 +
 lib/librte_eal/common/Makefile                |    2 +-
 lib/librte_eal/common/eal_common_uuid.c       |  193 +++
 lib/librte_eal/common/include/rte_uuid.h      |  129 ++
 lib/librte_eal/common/meson.build             |    2 +
 lib/librte_eal/linuxapp/eal/Makefile          |    1 +
 lib/librte_eal/rte_eal_version.map            |    9 +
 mk/rte.app.mk                                 |    2 +
 46 files changed, 8262 insertions(+), 3 deletions(-)
 create mode 100644 doc/guides/nics/features/netvsc.ini
 create mode 100644 doc/guides/nics/netvsc.rst
 create mode 100644 drivers/bus/vmbus/Makefile
 create mode 100644 drivers/bus/vmbus/linux/Makefile
 create mode 100644 drivers/bus/vmbus/linux/vmbus_bus.c
 create mode 100644 drivers/bus/vmbus/linux/vmbus_uio.c
 create mode 100644 drivers/bus/vmbus/meson.build
 create mode 100644 drivers/bus/vmbus/private.h
 create mode 100644 drivers/bus/vmbus/rte_bus_vmbus.h
 create mode 100644 drivers/bus/vmbus/rte_bus_vmbus_version.map
 create mode 100644 drivers/bus/vmbus/rte_vmbus_reg.h
 create mode 100644 drivers/bus/vmbus/vmbus_bufring.c
 create mode 100644 drivers/bus/vmbus/vmbus_channel.c
 create mode 100644 drivers/bus/vmbus/vmbus_common.c
 create mode 100644 drivers/bus/vmbus/vmbus_common_uio.c
 create mode 100644 drivers/net/netvsc/Makefile
 create mode 100644 drivers/net/netvsc/hn_ethdev.c
 create mode 100644 drivers/net/netvsc/hn_logs.h
 create mode 100644 drivers/net/netvsc/hn_nvs.c
 create mode 100644 drivers/net/netvsc/hn_nvs.h
 create mode 100644 drivers/net/netvsc/hn_rndis.c
 create mode 100644 drivers/net/netvsc/hn_rndis.h
 create mode 100644 drivers/net/netvsc/hn_rxtx.c
 create mode 100644 drivers/net/netvsc/hn_var.h
 create mode 100644 drivers/net/netvsc/meson.build
 create mode 100644 drivers/net/netvsc/ndis.h
 create mode 100644 drivers/net/netvsc/rndis.h
 create mode 100644 drivers/net/netvsc/rte_pmd_netvsc_version.map
 create mode 100644 lib/librte_eal/common/eal_common_uuid.c
 create mode 100644 lib/librte_eal/common/include/rte_uuid.h

Comments

Thomas Monjalon July 12, 2018, 7:55 p.m. UTC | #1
The old offload API has been removed.
Please could you adapt this PMD to the new API?

The errors are:
../drivers/net/netvsc/hn_ethdev.c:185:4: error: ‘struct rte_eth_txconf’ has no member named ‘txq_flags’
../drivers/net/netvsc/hn_ethdev.c:185:16: error: ‘ETH_TXQ_FLAGS_NOXSUMS’ undeclared (first use in this function)
   .txq_flags = ETH_TXQ_FLAGS_NOXSUMS,


Some checkpatches warnings are remaining:

### [dpdk-dev] [PATCH v11 2/4] bus/vmbus: add hyper-v virtual bus support

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#353: FILE: drivers/bus/vmbus/linux/vmbus_bus.c:28:
+extern struct rte_vmbus_bus rte_vmbus_bus;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2715: FILE: drivers/bus/vmbus/vmbus_common.c:26:
+extern struct rte_vmbus_bus rte_vmbus_bus;

### [dpdk-dev] [PATCH v11 3/4] net/netvsc: add hyper-v netvsc network device

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#519: FILE: drivers/net/netvsc/hn_ethdev.c:189:
+       dev_info->flow_type_rss_offloads
+               = ETH_RSS_IPV4 | ETH_RSS_IPV6 | ETH_RSS_TCP | ETH_RSS_UDP;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#622: FILE: drivers/net/netvsc/hn_ethdev.c:292:
+       const struct rte_eth_rss_conf *rss_conf
+               = &dev_conf->rx_adv_conf.rss_conf;

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#632: FILE: drivers/net/netvsc/hn_ethdev.c:302:
+                           "unsupported TX offload: %#" PRIx64,

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#788: FILE: drivers/net/netvsc/hn_ethdev.c:458:
+       const unsigned int nstats
+               = dev->data->nb_tx_queues * RTE_DIM(hn_stat_strings)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#2644: FILE: drivers/net/netvsc/hn_rndis.c:720:
+               PMD_DRV_LOG(ERR, "exec RNDIS set %#" PRIx32 " failed",

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3500: FILE: drivers/net/netvsc/hn_rxtx.c:441:
+               struct rte_eth_dev *dev
+                       = &rte_eth_devices[rxq->port_id];