Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99801/?format=api
{ "id": 99801, "url": "http://patches.dpdk.org/api/patches/99801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210927133450.10653-5-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210927133450.10653-5-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210927133450.10653-5-srikanth.k@oneconvergence.com", "date": "2021-09-27T13:34:35", "name": "[04/19] net/mlx5: disabling auxiliary bus support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dcb41f5d17462fc99701dd59694986aab3597915", "submitter": { "id": 2368, "url": "http://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210927133450.10653-5-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 19193, "url": "http://patches.dpdk.org/api/series/19193/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19193", "date": "2021-09-27T13:34:31", "name": "MLX5 FreeBSD support", "version": 1, "mbox": "http://patches.dpdk.org/series/19193/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/99801/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/99801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE1E7A0C46;\n\tMon, 27 Sep 2021 16:58:38 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 10B5141104;\n\tMon, 27 Sep 2021 16:58:13 +0200 (CEST)", "from mail-pg1-f181.google.com (mail-pg1-f181.google.com\n [209.85.215.181])\n by mails.dpdk.org (Postfix) with ESMTP id E12B140E3C\n for <dev@dpdk.org>; Mon, 27 Sep 2021 15:36:13 +0200 (CEST)", "by mail-pg1-f181.google.com with SMTP id s75so1312468pgs.5\n for <dev@dpdk.org>; Mon, 27 Sep 2021 06:36:13 -0700 (PDT)", "from srikanth-ThinkPad-T450.domain.name ([223.178.22.200])\n by smtp.gmail.com with ESMTPSA id t6sm17342274pfh.63.2021.09.27.06.36.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Sep 2021 06:36:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=CJUblWHtW7DfBvkUvHJGMZkYZvNjIpYnUNKkqbLHfQo=;\n b=WbV2SgX41mxm2xcaP3eKp+bN61Eu/NKvEgHjUdqaAz8nu6zK4AfSEYZrso03MnB0It\n yB5ZLD9uLlynea0yade7kOBxyVMqMvwp/Vc9bfOmnUwrJt4BHvq2pMTnEwiLz35hDjzh\n b6O96i73NHEDbyTa7KRuz+9YmxMmRUdR4vM7M=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=CJUblWHtW7DfBvkUvHJGMZkYZvNjIpYnUNKkqbLHfQo=;\n b=pPYKiK+gkXuGMXKH//8Qdj1O94KZbe2UDvwtj/FHK8HUjXU357uYg40nCVO2dVG7UC\n 2kFMzClSpVgxleBAQhAQWyvs9u6PWFts3/lki4uFigzorz/09gh6mYU47+ncrcGfF3/s\n gfC5L06ieMAIpqHsU347YE4fqi6Sryk3ZIRaeyO/15EOMtFsYil4R41hJ8MJx5DQkFP4\n IkBdOFu6wc1sBXBOy1G7tJK/Jkd1EJIKRZH2R/XI33XWdBnpelP6zwbrUgEp0LzLsjGw\n +Q9bEK1CMHsTByJMItHg0SltV56njeyPCspakmq7PkWJ8A2zxCslyGzL1NtNGr/5NV1V\n xUUQ==", "X-Gm-Message-State": "AOAM533FbMGlQZkeRNSt3SvlYjRRu+W/ltC4FXUbwfR6qh9WWroBWkqK\n 2dE4VrqX2Pl3ymk1cXmAiQ2zerOV/PUS1g==", "X-Google-Smtp-Source": "\n ABdhPJwvvKBRWRgfhBUIAQj5TskmZWlHLq5+nOyowqBZ2JuTTry6M29cGHuP8Lp0OInJzkNviELFTA==", "X-Received": "by 2002:aa7:9846:0:b0:444:5517:fa17 with SMTP id\n n6-20020aa79846000000b004445517fa17mr24012925pfq.85.1632749773045;\n Mon, 27 Sep 2021 06:36:13 -0700 (PDT)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Cc": "dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,\n Anand Thulasiram <avelu@juniper.net>,\n Srikanth Kaka <srikanth.k@oneconvergence.com>", "Date": "Mon, 27 Sep 2021 19:04:35 +0530", "Message-Id": "<20210927133450.10653-5-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210927133450.10653-1-srikanth.k@oneconvergence.com>", "References": "<20210927133450.10653-1-srikanth.k@oneconvergence.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 27 Sep 2021 16:58:07 +0200", "Subject": "[dpdk-dev] [PATCH 04/19] net/mlx5: disabling auxiliary bus support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Disabling auxiliary bus support in FreeBSD at this moment\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 12 ------\n drivers/net/mlx5/freebsd/mlx5_os.c | 52 +----------------------\n drivers/net/mlx5/freebsd/mlx5_os.h | 2 -\n 3 files changed, 2 insertions(+), 64 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\nindex f34133e2c6..5cf3eab65a 100644\n--- a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\n+++ b/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c\n@@ -128,18 +128,6 @@ struct ethtool_link_settings {\n #define ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT 2 /* 66 - 64 */\n #endif\n \n-/* Get interface index from SubFunction device name. */\n-int\n-mlx5_auxiliary_get_ifindex(const char *sf_name)\n-{\n-\tchar if_name[IF_NAMESIZE] = { 0 };\n-\n-\tif (mlx5_auxiliary_get_child_name(sf_name, \"/net\",\n-\t\t\t\t\t if_name, sizeof(if_name)) != 0)\n-\t\treturn -rte_errno;\n-\treturn if_nametoindex(if_name);\n-}\n-\n /**\n * Get interface name from private structure.\n *\ndiff --git a/drivers/net/mlx5/freebsd/mlx5_os.c b/drivers/net/mlx5/freebsd/mlx5_os.c\nindex 3746057673..616bb73744 100644\n--- a/drivers/net/mlx5/freebsd/mlx5_os.c\n+++ b/drivers/net/mlx5/freebsd/mlx5_os.c\n@@ -20,7 +20,6 @@\n #include <ethdev_pci.h>\n #include <rte_pci.h>\n #include <rte_bus_pci.h>\n-#include <rte_bus_auxiliary.h>\n #include <rte_common.h>\n #include <rte_kvargs.h>\n #include <rte_rwlock.h>\n@@ -2716,57 +2715,10 @@ mlx5_os_pci_probe(struct rte_pci_device *pci_dev)\n \t}\n \treturn ret;\n }\n-\n-/* Probe a single SF device on auxiliary bus, no representor support. */\n-static int\n-mlx5_os_auxiliary_probe(struct rte_device *dev)\n-{\n-\tstruct rte_eth_devargs eth_da = { .nb_ports = 0 };\n-\tstruct mlx5_dev_config config;\n-\tstruct mlx5_dev_spawn_data spawn = { .pf_bond = -1 };\n-\tstruct rte_auxiliary_device *adev = RTE_DEV_TO_AUXILIARY(dev);\n-\tstruct rte_eth_dev *eth_dev;\n-\tint ret = 0;\n-\n-\t/* Parse ethdev devargs. */\n-\tret = mlx5_os_parse_eth_devargs(dev, ð_da);\n-\tif (ret != 0)\n-\t\treturn ret;\n-\t/* Set default config data. */\n-\tmlx5_os_config_default(&config);\n-\tconfig.sf = 1;\n-\t/* Init spawn data. */\n-\tspawn.max_port = 1;\n-\tspawn.phys_port = 1;\n-\tspawn.phys_dev = mlx5_os_get_ibv_dev(dev);\n-\tif (spawn.phys_dev == NULL)\n-\t\treturn -rte_errno;\n-\tret = mlx5_auxiliary_get_ifindex(dev->name);\n-\tif (ret < 0) {\n-\t\tDRV_LOG(ERR, \"failed to get ethdev ifindex: %s\", dev->name);\n-\t\treturn ret;\n-\t}\n-\tspawn.ifindex = ret;\n-\tspawn.numa_node = dev->numa_node;\n-\t/* Spawn device. */\n-\teth_dev = mlx5_dev_spawn(dev, &spawn, &config, ð_da);\n-\tif (eth_dev == NULL)\n-\t\treturn -rte_errno;\n-\t/* Post create. */\n-\teth_dev->intr_handle = &adev->intr_handle;\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\teth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;\n-\t\teth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_RMV;\n-\t\teth_dev->data->numa_node = dev->numa_node;\n-\t}\n-\trte_eth_dev_probing_finish(eth_dev);\n-\treturn 0;\n-}\n-\n /**\n * Net class driver callback to probe a device.\n *\n- * This function probe PCI bus device(s) or a single SF on auxiliary bus.\n+ * This function probe PCI bus device(s)\n *\n * @param[in] dev\n * Pointer to the generic device.\n@@ -2790,7 +2742,7 @@ mlx5_os_net_probe(struct rte_device *dev)\n \tif (mlx5_dev_is_pci(dev))\n \t\treturn mlx5_os_pci_probe(RTE_DEV_TO_PCI(dev));\n \telse\n-\t\treturn mlx5_os_auxiliary_probe(dev);\n+\t\treturn -ENOTSUP;\n }\n \n static int\ndiff --git a/drivers/net/mlx5/freebsd/mlx5_os.h b/drivers/net/mlx5/freebsd/mlx5_os.h\nindex 2991d37df2..af7cbeb418 100644\n--- a/drivers/net/mlx5/freebsd/mlx5_os.h\n+++ b/drivers/net/mlx5/freebsd/mlx5_os.h\n@@ -19,6 +19,4 @@ enum {\n \n #define MLX5_NAMESIZE IF_NAMESIZE\n \n-int mlx5_auxiliary_get_ifindex(const char *sf_name);\n-\n #endif /* RTE_PMD_MLX5_OS_H_ */\n", "prefixes": [ "04/19" ] }