Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 99627,
    "url": "http://patches.dpdk.org/api/patches/99627/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210924152202.7592-6-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210924152202.7592-6-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210924152202.7592-6-stephen@networkplumber.org",
    "date": "2021-09-24T15:21:55",
    "name": "[v11,05/12] bpf: add function to dump eBPF instructions",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d393a4373dfdb7e26c9a7019d6079888d0b6ca36",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210924152202.7592-6-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 19146,
            "url": "http://patches.dpdk.org/api/series/19146/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19146",
            "date": "2021-09-24T15:21:50",
            "name": "Packet capture framework enhancements",
            "version": 11,
            "mbox": "http://patches.dpdk.org/series/19146/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/99627/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/99627/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A005FA0548;\n\tFri, 24 Sep 2021 17:22:44 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2882D41345;\n\tFri, 24 Sep 2021 17:22:23 +0200 (CEST)",
            "from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n [209.85.214.179])\n by mails.dpdk.org (Postfix) with ESMTP id 2B62D41320\n for <dev@dpdk.org>; Fri, 24 Sep 2021 17:22:18 +0200 (CEST)",
            "by mail-pl1-f179.google.com with SMTP id c4so6703140pls.6\n for <dev@dpdk.org>; Fri, 24 Sep 2021 08:22:18 -0700 (PDT)",
            "from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123])\n by smtp.gmail.com with ESMTPSA id v2sm8587493pje.15.2021.09.24.08.22.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 24 Sep 2021 08:22:15 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=4vaE/EiLwrmc4bOiTRxz3zUDK47Pr9QU3JL0LOFt1VY=;\n b=BwPuNdBHqiV6HHE8l/QqpysVfDR4J+78egqcepRdqV4VZWmQuQBAyDuOSlQpEozgaD\n 5RE33o84RV1Qm8OqJ529Cx9ORE701ZCuYKchLTA9luwfHsYd5YpvkteWjNqg3t5XhdVW\n 7vvTZDZCJTaAAwv6XM+fUk5Y7MQKLMHk8YMiJvfu0/Vv2PUXNF2Hg0ZVPtNoWgV7Ki2/\n Rv9Q/Yb/9iQRLOQiKMRkkI6lWvmYI4fMAo4wOxbiNvcFc4PFn5uKBlPGFRXmziT7ZD8b\n CkGM9QA0ZXNrarILmxwSavUEm++r14gpsFCY/mVJG8wHO8HU6qDjGQA/fAnApOc0ZHeq\n erqw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=4vaE/EiLwrmc4bOiTRxz3zUDK47Pr9QU3JL0LOFt1VY=;\n b=CIvro/Rc0wnZ8Ao8g9FULd6db72jbMW7gZlkZUBZuks0V2emcGofPDXOamycR+Iu5d\n ktlFGbQL/2MmiWnrHMtgoNxXFC2tl6nQEJvT1ur45dGzy/Iid17lVJRYelPObwf4Ro6b\n w7sKIAYYeECyjW/G2Ff1sh1h4Nl41bJDyxtc//BiVTOEtRN4uDbvF4YKtwZSe5lFUaiS\n sa6iG3kkWqtFShZhR3ThbckYYqHhlnpBG2UPFGZ+3l+r0MK7CjaRw2Pc0sKJAwFr8A82\n IlkjVaU8Z/82xoct8rDlQCFsDfrg8wW/tPgRb0NapG67rYCEjvk64p2FcseWvv0/5zn2\n VkQw==",
        "X-Gm-Message-State": "AOAM531J7H34Ykqt6KYR+zX6bRmA37uGmjUyxu+cnlvf3KDI33ZVWsyW\n Hisild4sPt4f7AFPMJ2ZAOCg/6VuuBBsJw==",
        "X-Google-Smtp-Source": "\n ABdhPJyg00utPxs5eE1XBQUIEnVbGyMSh4mn0bXKSPsmLXp5zYU4oTus4AkakXFBryeYIATesLtSJQ==",
        "X-Received": "by 2002:a17:903:4094:b0:13c:86b0:3050 with SMTP id\n z20-20020a170903409400b0013c86b03050mr9423182plc.58.1632496936675;\n Fri, 24 Sep 2021 08:22:16 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>",
        "Date": "Fri, 24 Sep 2021 08:21:55 -0700",
        "Message-Id": "<20210924152202.7592-6-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.30.2",
        "In-Reply-To": "<20210924152202.7592-1-stephen@networkplumber.org>",
        "References": "<20210903004732.109023-1-stephen@networkplumber.org>\n <20210924152202.7592-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v11 05/12] bpf: add function to dump eBPF\n instructions",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When debugging converted (and other) programs it is useful\nto see disassembled eBPF output.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/bpf/bpf_dump.c  | 139 ++++++++++++++++++++++++++++++++++++++++++++\n lib/bpf/meson.build |   1 +\n lib/bpf/rte_bpf.h   |  14 +++++\n lib/bpf/version.map |   1 +\n 4 files changed, 155 insertions(+)\n create mode 100644 lib/bpf/bpf_dump.c",
    "diff": "diff --git a/lib/bpf/bpf_dump.c b/lib/bpf/bpf_dump.c\nnew file mode 100644\nindex 000000000000..b86977b96d08\n--- /dev/null\n+++ b/lib/bpf/bpf_dump.c\n@@ -0,0 +1,139 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) 2021 Stephen Hemminger\n+ * Based on filter2xdp\n+ * Copyright (C) 2017 Tobias Klauser\n+ */\n+\n+#include <stdio.h>\n+#include <stdint.h>\n+\n+#include \"rte_bpf.h\"\n+\n+#define BPF_OP_INDEX(x) (BPF_OP(x) >> 4)\n+#define BPF_SIZE_INDEX(x) (BPF_SIZE(x) >> 3)\n+\n+static const char *const class_tbl[] = {\n+\t[BPF_LD] = \"ld\",   [BPF_LDX] = \"ldx\",\t [BPF_ST] = \"st\",\n+\t[BPF_STX] = \"stx\", [BPF_ALU] = \"alu\",\t [BPF_JMP] = \"jmp\",\n+\t[BPF_RET] = \"ret\", [BPF_MISC] = \"alu64\",\n+};\n+\n+static const char *const alu_op_tbl[16] = {\n+\t[BPF_ADD >> 4] = \"add\",\t   [BPF_SUB >> 4] = \"sub\",\n+\t[BPF_MUL >> 4] = \"mul\",\t   [BPF_DIV >> 4] = \"div\",\n+\t[BPF_OR >> 4] = \"or\",\t   [BPF_AND >> 4] = \"and\",\n+\t[BPF_LSH >> 4] = \"lsh\",\t   [BPF_RSH >> 4] = \"rsh\",\n+\t[BPF_NEG >> 4] = \"neg\",\t   [BPF_MOD >> 4] = \"mod\",\n+\t[BPF_XOR >> 4] = \"xor\",\t   [EBPF_MOV >> 4] = \"mov\",\n+\t[EBPF_ARSH >> 4] = \"arsh\", [EBPF_END >> 4] = \"endian\",\n+};\n+\n+static const char *const size_tbl[] = {\n+\t[BPF_W >> 3] = \"w\",\n+\t[BPF_H >> 3] = \"h\",\n+\t[BPF_B >> 3] = \"b\",\n+\t[EBPF_DW >> 3] = \"dw\",\n+};\n+\n+static const char *const jump_tbl[16] = {\n+\t[BPF_JA >> 4] = \"ja\",\t   [BPF_JEQ >> 4] = \"jeq\",\n+\t[BPF_JGT >> 4] = \"jgt\",\t   [BPF_JGE >> 4] = \"jge\",\n+\t[BPF_JSET >> 4] = \"jset\",  [EBPF_JNE >> 4] = \"jne\",\n+\t[EBPF_JSGT >> 4] = \"jsgt\", [EBPF_JSGE >> 4] = \"jsge\",\n+\t[EBPF_CALL >> 4] = \"call\", [EBPF_EXIT >> 4] = \"exit\",\n+};\n+\n+void rte_bpf_dump(FILE *f, const struct ebpf_insn *buf, uint32_t len)\n+{\n+\tuint32_t i;\n+\n+\tfor (i = 0; i < len; ++i) {\n+\t\tconst struct ebpf_insn *ins = buf + i;\n+\t\tuint8_t cls = BPF_CLASS(ins->code);\n+\t\tconst char *op, *postfix = \"\";\n+\n+\t\tfprintf(f, \" L%u:\\t\", i);\n+\n+\t\tswitch (cls) {\n+\t\tdefault:\n+\t\t\tfprintf(f, \"unimp 0x%x // class: %s\\n\",\n+\t\t\t\tins->code, class_tbl[cls]);\n+\t\t\tbreak;\n+\t\tcase BPF_ALU:\n+\t\t\tpostfix = \"32\";\n+\t\t\t/* fall through */\n+\t\tcase EBPF_ALU64:\n+\t\t\top = alu_op_tbl[BPF_OP_INDEX(ins->code)];\n+\t\t\tif (BPF_SRC(ins->code) == BPF_X)\n+\t\t\t\tfprintf(f, \"%s%s r%u, r%u\\n\", op, postfix, ins->dst_reg,\n+\t\t\t\t\tins->src_reg);\n+\t\t\telse\n+\t\t\t\tfprintf(f, \"%s%s r%u, #0x%x\\n\", op, postfix,\n+\t\t\t\t\tins->dst_reg, ins->imm);\n+\t\t\tbreak;\n+\t\tcase BPF_LD:\n+\t\t\top = \"ld\";\n+\t\t\tpostfix = size_tbl[BPF_SIZE_INDEX(ins->code)];\n+\t\t\tif (ins->code == (BPF_LD | BPF_IMM | EBPF_DW)) {\n+\t\t\t\tuint64_t val;\n+\n+\t\t\t\tval = (uint32_t)ins[0].imm |\n+\t\t\t\t\t(uint64_t)(uint32_t)ins[1].imm << 32;\n+\t\t\t\tfprintf(f, \"%s%s r%d, #0x%\"PRIx64\"\\n\",\n+\t\t\t\t\top, postfix, ins->dst_reg, val);\n+\t\t\t\ti++;\n+\t\t\t} else if (BPF_MODE(ins->code) == BPF_IMM)\n+\t\t\t\tfprintf(f, \"%s%s r%d, #0x%x\\n\", op, postfix,\n+\t\t\t\t\tins->dst_reg, ins->imm);\n+\t\t\telse if (BPF_MODE(ins->code) == BPF_ABS)\n+\t\t\t\tfprintf(f, \"%s%s r%d, [%d]\\n\", op, postfix,\n+\t\t\t\t\tins->dst_reg, ins->imm);\n+\t\t\telse if (BPF_MODE(ins->code) == BPF_IND)\n+\t\t\t\tfprintf(f, \"%s%s r%d, [r%u + %d]\\n\", op, postfix,\n+\t\t\t\t\tins->dst_reg, ins->src_reg, ins->imm);\n+\t\t\telse\n+\t\t\t\tfprintf(f, \"// BUG: LD opcode 0x%02x in eBPF insns\\n\",\n+\t\t\t\t\tins->code);\n+\t\t\tbreak;\n+\t\tcase BPF_LDX:\n+\t\t\top = \"ldx\";\n+\t\t\tpostfix = size_tbl[BPF_SIZE_INDEX(ins->code)];\n+\t\t\tfprintf(f, \"%s%s r%d, [r%u + %d]\\n\", op, postfix, ins->dst_reg,\n+\t\t\t\tins->src_reg, ins->off);\n+\t\t\tbreak;\n+\t\tcase BPF_ST:\n+\t\t\top = \"st\";\n+\t\t\tpostfix = size_tbl[BPF_SIZE_INDEX(ins->code)];\n+\t\t\tif (BPF_MODE(ins->code) == BPF_MEM)\n+\t\t\t\tfprintf(f, \"%s%s [r%d + %d], #0x%x\\n\", op, postfix,\n+\t\t\t\t\tins->dst_reg, ins->off, ins->imm);\n+\t\t\telse\n+\t\t\t\tfprintf(f, \"// BUG: ST opcode 0x%02x in eBPF insns\\n\",\n+\t\t\t\t\tins->code);\n+\t\t\tbreak;\n+\t\tcase BPF_STX:\n+\t\t\top = \"stx\";\n+\t\t\tpostfix = size_tbl[BPF_SIZE_INDEX(ins->code)];\n+\t\t\tfprintf(f, \"%s%s [r%d + %d], r%u\\n\", op, postfix,\n+\t\t\t\tins->dst_reg, ins->off, ins->src_reg);\n+\t\t\tbreak;\n+#define L(pc, off) ((int)(pc) + 1 + (off))\n+\t\tcase BPF_JMP:\n+\t\t\top = jump_tbl[BPF_OP_INDEX(ins->code)];\n+\t\t\tif (op == NULL)\n+\t\t\t\tfprintf(f, \"invalid jump opcode: %#x\\n\", ins->code);\n+\t\t\telse if (BPF_OP(ins->code) == BPF_JA)\n+\t\t\t\tfprintf(f, \"%s L%d\\n\", op, L(i, ins->off));\n+\t\t\telse if (BPF_OP(ins->code) == EBPF_EXIT)\n+\t\t\t\tfprintf(f, \"%s\\n\", op);\n+\t\t\telse\n+\t\t\t\tfprintf(f, \"%s r%u, #0x%x, L%d\\n\", op, ins->dst_reg,\n+\t\t\t\t\tins->imm, L(i, ins->off));\n+\t\t\tbreak;\n+\t\tcase BPF_RET:\n+\t\t\tfprintf(f, \"// BUG: RET opcode 0x%02x in eBPF insns\\n\",\n+\t\t\t\tins->code);\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+}\ndiff --git a/lib/bpf/meson.build b/lib/bpf/meson.build\nindex 54f7610ae990..5b5585173aeb 100644\n--- a/lib/bpf/meson.build\n+++ b/lib/bpf/meson.build\n@@ -2,6 +2,7 @@\n # Copyright(c) 2018 Intel Corporation\n \n sources = files('bpf.c',\n+\t'bpf_dump.c',\n         'bpf_exec.c',\n         'bpf_load.c',\n         'bpf_pkt.c',\ndiff --git a/lib/bpf/rte_bpf.h b/lib/bpf/rte_bpf.h\nindex 2f23e272a376..0d0a84b130a0 100644\n--- a/lib/bpf/rte_bpf.h\n+++ b/lib/bpf/rte_bpf.h\n@@ -198,6 +198,20 @@ rte_bpf_exec_burst(const struct rte_bpf *bpf, void *ctx[], uint64_t rc[],\n int\n rte_bpf_get_jit(const struct rte_bpf *bpf, struct rte_bpf_jit *jit);\n \n+/**\n+ * Dump epf instructions to a file.\n+ *\n+ * @param f\n+ *   A pointer to a file for output\n+ * @param buf\n+ *   A pointer to BPF instructions\n+ * @param len\n+ *   Number of BPF instructions to dump.\n+ */\n+__rte_experimental\n+void\n+rte_bpf_dump(FILE *f, const struct ebpf_insn *buf, uint32_t len);\n+\n #ifdef RTE_PORT_PCAP\n \n struct bpf_program;\ndiff --git a/lib/bpf/version.map b/lib/bpf/version.map\nindex 47082d5003ef..3b953f2f4592 100644\n--- a/lib/bpf/version.map\n+++ b/lib/bpf/version.map\n@@ -19,4 +19,5 @@ EXPERIMENTAL {\n \tglobal:\n \n \trte_bpf_convert;\n+\trte_bpf_dump;\n };\n",
    "prefixes": [
        "v11",
        "05/12"
    ]
}