Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98694/?format=api
{ "id": 98694, "url": "http://patches.dpdk.org/api/patches/98694/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210911153041.28510-4-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210911153041.28510-4-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210911153041.28510-4-venkatkumar.duvvuru@broadcom.com", "date": "2021-09-11T15:30:31", "name": "[v3,03/13] net/bnxt: add flow meter drop counter support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4f0ff3d5b6606056f79fb7fe2a68e780877593e4", "submitter": { "id": 1635, "url": "http://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210911153041.28510-4-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 18856, "url": "http://patches.dpdk.org/api/series/18856/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18856", "date": "2021-09-11T15:30:28", "name": "enhancements to host based flow table management", "version": 3, "mbox": "http://patches.dpdk.org/series/18856/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98694/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/98694/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2FDCA034F;\n\tSat, 11 Sep 2021 17:31:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 639C6410F7;\n\tSat, 11 Sep 2021 17:30:56 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.166.228])\n by mails.dpdk.org (Postfix) with ESMTP id E784440A4B\n for <dev@dpdk.org>; Sat, 11 Sep 2021 17:30:49 +0200 (CEST)", "from S60.dhcp.broadcom.net (unknown [10.123.66.170])\n (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 7F3A680D6;\n Sat, 11 Sep 2021 08:30:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 7F3A680D6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1631374249;\n bh=g0IiQ2xDbVJeeOTHKgv6b6IciCGz4ee0N9N+V/GMYIc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=kABZ2PTgUb6ZHm9suzD6xmwMAptmjuFNI6EIHy/rQzkf+TTriAM7fSpiOYvEs5LfP\n 4R8vLLVELHgBZsqOWl47WjiRMaHD/jy3TdxwLp7IyXUU/PqEA1yavVMWJ73U+qHHGU\n jts4mtxJjNyc5pGKY8Z8g0uE4M+ufVjf2YobQgnk=", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Jay Ding <jay.ding@broadcom.com>", "Date": "Sat, 11 Sep 2021 21:00:31 +0530", "Message-Id": "<20210911153041.28510-4-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210911153041.28510-1-venkatkumar.duvvuru@broadcom.com>", "References": "<20210908050643.9989-1-venkatkumar.duvvuru@broadcom.com>\n <20210911153041.28510-1-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v3 03/13] net/bnxt: add flow meter drop counter\n support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jay Ding <jay.ding@broadcom.com>\n\n- Add flow meter drop counter support for Thor.\n\nSigned-off-by: Jay Ding <jay.ding@broadcom.com>\nReviewed-by: Farah Smith <farah.smith@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/tf_core/cfa_resource_types.h | 5 +-\n drivers/net/bnxt/tf_core/tf_core.h | 8 +-\n drivers/net/bnxt/tf_core/tf_device_p58.c | 1 +\n drivers/net/bnxt/tf_core/tf_device_p58.h | 14 ++++\n drivers/net/bnxt/tf_core/tf_tbl.c | 74 +++++++++++--------\n drivers/net/bnxt/tf_core/tf_util.c | 2 +\n 6 files changed, 68 insertions(+), 36 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_core/cfa_resource_types.h b/drivers/net/bnxt/tf_core/cfa_resource_types.h\nindex cbab0d0078..36a55d4e17 100644\n--- a/drivers/net/bnxt/tf_core/cfa_resource_types.h\n+++ b/drivers/net/bnxt/tf_core/cfa_resource_types.h\n@@ -104,10 +104,11 @@\n #define CFA_RESOURCE_TYPE_P58_WC_FKB 0x12UL\n /* VEB TCAM */\n #define CFA_RESOURCE_TYPE_P58_VEB_TCAM 0x13UL\n+/* Metadata */\n+#define CFA_RESOURCE_TYPE_P58_METADATA 0x14UL\n /* Meter drop counter */\n #define CFA_RESOURCE_TYPE_P58_METER_DROP_CNT 0x15UL\n-#define CFA_RESOURCE_TYPE_P58_LAST CFA_RESOURCE_TYPE_P58_METER_DROP_CNT\n-\n+#define CFA_RESOURCE_TYPE_P58_LAST CFA_RESOURCE_TYPE_P58_METER_DROP_CNT\n \n /* Multicast Group */\n #define CFA_RESOURCE_TYPE_P45_MCG 0x0UL\ndiff --git a/drivers/net/bnxt/tf_core/tf_core.h b/drivers/net/bnxt/tf_core/tf_core.h\nindex 7e0cdf7e0d..af8d13bd7e 100644\n--- a/drivers/net/bnxt/tf_core/tf_core.h\n+++ b/drivers/net/bnxt/tf_core/tf_core.h\n@@ -283,9 +283,9 @@ enum tf_tbl_type {\n \tTF_TBL_TYPE_ACT_MODIFY_32B,\n \t/** TH 64B Modify Record */\n \tTF_TBL_TYPE_ACT_MODIFY_64B,\n-\t/** (Future) Meter Profiles */\n+\t/** Meter Profiles */\n \tTF_TBL_TYPE_METER_PROF,\n-\t/** (Future) Meter Instance */\n+\t/** Meter Instance */\n \tTF_TBL_TYPE_METER_INST,\n \t/** Wh+/SR/Th Mirror Config */\n \tTF_TBL_TYPE_MIRROR_CONFIG,\n@@ -301,6 +301,8 @@ enum tf_tbl_type {\n \tTF_TBL_TYPE_EM_FKB,\n \t/** TH WC Flexible Key builder */\n \tTF_TBL_TYPE_WC_FKB,\n+\t/** Meter Drop Counter */\n+\tTF_TBL_TYPE_METER_DROP_CNT,\n \n \t/* External */\n \n@@ -2194,6 +2196,8 @@ enum tf_global_config_type {\n \tTF_TUNNEL_ENCAP, /**< Tunnel Encap Config(TECT) */\n \tTF_ACTION_BLOCK, /**< Action Block Config(ABCR) */\n \tTF_COUNTER_CFG, /**< Counter Configuration (CNTRS_CTRL) */\n+\tTF_METER_CFG, /**< Meter Config(ACTP4_FMTCR) */\n+\tTF_METER_INTERVAL_CFG, /**< Meter Interval Config(FMTCR_INTERVAL) */\n \tTF_GLOBAL_CFG_TYPE_MAX\n };\n \ndiff --git a/drivers/net/bnxt/tf_core/tf_device_p58.c b/drivers/net/bnxt/tf_core/tf_device_p58.c\nindex 808dcb1f77..a492c62bff 100644\n--- a/drivers/net/bnxt/tf_core/tf_device_p58.c\n+++ b/drivers/net/bnxt/tf_core/tf_device_p58.c\n@@ -43,6 +43,7 @@ const char *tf_resource_str_p58[CFA_RESOURCE_TYPE_P58_LAST + 1] = {\n \t[CFA_RESOURCE_TYPE_P58_EM_FKB] = \"em_fkb \",\n \t[CFA_RESOURCE_TYPE_P58_WC_FKB] = \"wc_fkb \",\n \t[CFA_RESOURCE_TYPE_P58_VEB_TCAM] = \"veb \",\n+\t[CFA_RESOURCE_TYPE_P58_METADATA] = \"metadata\",\n };\n \n /**\ndiff --git a/drivers/net/bnxt/tf_core/tf_device_p58.h b/drivers/net/bnxt/tf_core/tf_device_p58.h\nindex 66b0f4e983..8c2e07aa34 100644\n--- a/drivers/net/bnxt/tf_core/tf_device_p58.h\n+++ b/drivers/net/bnxt/tf_core/tf_device_p58.h\n@@ -75,10 +75,18 @@ struct tf_rm_element_cfg tf_tbl_p58[TF_TBL_TYPE_MAX] = {\n \t\tTF_RM_ELEM_CFG_HCAPI_BA, CFA_RESOURCE_TYPE_P58_METER,\n \t\t0, 0, 0\n \t},\n+\t[TF_TBL_TYPE_METER_DROP_CNT] = {\n+\t\tTF_RM_ELEM_CFG_HCAPI_BA, CFA_RESOURCE_TYPE_P58_METER_DROP_CNT,\n+\t\t0, 0, 0\n+\t},\n \t[TF_TBL_TYPE_MIRROR_CONFIG] = {\n \t\tTF_RM_ELEM_CFG_HCAPI_BA, CFA_RESOURCE_TYPE_P58_MIRROR,\n \t\t0, 0, 0\n \t},\n+\t[TF_TBL_TYPE_METADATA] = {\n+\t\tTF_RM_ELEM_CFG_HCAPI_BA, CFA_RESOURCE_TYPE_P58_METADATA,\n+\t\t0, 0, 0\n+\t},\n \t/* Policy - ARs in bank 1 */\n \t[TF_TBL_TYPE_FULL_ACT_RECORD] = {\n \t\t.cfg_type = TF_RM_ELEM_CFG_HCAPI_BA_PARENT,\n@@ -194,5 +202,11 @@ struct tf_global_cfg_cfg tf_global_cfg_p58[TF_GLOBAL_CFG_TYPE_MAX] = {\n \t[TF_COUNTER_CFG] = {\n \t\tTF_GLOBAL_CFG_CFG_HCAPI, TF_COUNTER_CFG\n \t},\n+\t[TF_METER_CFG] = {\n+\t\tTF_GLOBAL_CFG_CFG_HCAPI, TF_METER_CFG\n+\t},\n+\t[TF_METER_INTERVAL_CFG] = {\n+\t\tTF_GLOBAL_CFG_CFG_HCAPI, TF_METER_INTERVAL_CFG\n+\t},\n };\n #endif /* _TF_DEVICE_P58_H_ */\ndiff --git a/drivers/net/bnxt/tf_core/tf_tbl.c b/drivers/net/bnxt/tf_core/tf_tbl.c\nindex e77399c6bd..7011edcd78 100644\n--- a/drivers/net/bnxt/tf_core/tf_tbl.c\n+++ b/drivers/net/bnxt/tf_core/tf_tbl.c\n@@ -374,23 +374,28 @@ tf_tbl_set(struct tf *tfp,\n \t\t}\n \t}\n \n-\t/* Verify that the entry has been previously allocated */\n-\taparms.rm_db = tbl_db->tbl_db[parms->dir];\n-\taparms.subtype = parms->type;\n-\tTF_TBL_PTR_TO_RM(&aparms.index, parms->idx, base, shift);\n-\n-\taparms.allocated = &allocated;\n-\trc = tf_rm_is_allocated(&aparms);\n-\tif (rc)\n-\t\treturn rc;\n+\t/* Do not check meter drop counter because it is not allocated\n+\t * resources\n+\t */\n+\tif (parms->type != TF_TBL_TYPE_METER_DROP_CNT) {\n+\t\t/* Verify that the entry has been previously allocated */\n+\t\taparms.rm_db = tbl_db->tbl_db[parms->dir];\n+\t\taparms.subtype = parms->type;\n+\t\tTF_TBL_PTR_TO_RM(&aparms.index, parms->idx, base, shift);\n+\n+\t\taparms.allocated = &allocated;\n+\t\trc = tf_rm_is_allocated(&aparms);\n+\t\tif (rc)\n+\t\t\treturn rc;\n \n-\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n-\t\tTFP_DRV_LOG(ERR,\n-\t\t \"%s, Invalid or not allocated index, type:%d, idx:%d\\n\",\n-\t\t tf_dir_2_str(parms->dir),\n-\t\t parms->type,\n-\t\t parms->idx);\n-\t\treturn -EINVAL;\n+\t\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n+\t\t\tTFP_DRV_LOG(ERR,\n+\t\t\t \"%s, Invalid or not allocated index, type:%d, idx:%d\\n\",\n+\t\t\t tf_dir_2_str(parms->dir),\n+\t\t\t parms->type,\n+\t\t\t parms->idx);\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n \t/* Set the entry */\n@@ -477,23 +482,28 @@ tf_tbl_get(struct tf *tfp,\n \t\t}\n \t}\n \n-\t/* Verify that the entry has been previously allocated */\n-\taparms.rm_db = tbl_db->tbl_db[parms->dir];\n-\taparms.subtype = parms->type;\n-\tTF_TBL_PTR_TO_RM(&aparms.index, parms->idx, base, shift);\n-\n-\taparms.allocated = &allocated;\n-\trc = tf_rm_is_allocated(&aparms);\n-\tif (rc)\n-\t\treturn rc;\n+\t/* Do not check meter drop counter because it is not allocated\n+\t * resources.\n+\t */\n+\tif (parms->type != TF_TBL_TYPE_METER_DROP_CNT) {\n+\t\t/* Verify that the entry has been previously allocated */\n+\t\taparms.rm_db = tbl_db->tbl_db[parms->dir];\n+\t\taparms.subtype = parms->type;\n+\t\tTF_TBL_PTR_TO_RM(&aparms.index, parms->idx, base, shift);\n+\n+\t\taparms.allocated = &allocated;\n+\t\trc = tf_rm_is_allocated(&aparms);\n+\t\tif (rc)\n+\t\t\treturn rc;\n \n-\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n-\t\tTFP_DRV_LOG(ERR,\n-\t\t \"%s, Invalid or not allocated index, type:%d, idx:%d\\n\",\n-\t\t tf_dir_2_str(parms->dir),\n-\t\t parms->type,\n-\t\t parms->idx);\n-\t\treturn -EINVAL;\n+\t\tif (allocated != TF_RM_ALLOCATED_ENTRY_IN_USE) {\n+\t\t\tTFP_DRV_LOG(ERR,\n+\t\t\t \"%s, Invalid or not allocated index, type:%d, idx:%d\\n\",\n+\t\t\t tf_dir_2_str(parms->dir),\n+\t\t\t parms->type,\n+\t\t\t parms->idx);\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n \t/* Set the entry */\ndiff --git a/drivers/net/bnxt/tf_core/tf_util.c b/drivers/net/bnxt/tf_core/tf_util.c\nindex e712816209..d100399d0a 100644\n--- a/drivers/net/bnxt/tf_core/tf_util.c\n+++ b/drivers/net/bnxt/tf_core/tf_util.c\n@@ -112,6 +112,8 @@ tf_tbl_type_2_str(enum tf_tbl_type tbl_type)\n \t\treturn \"WC Flexible Key Builder\";\n \tcase TF_TBL_TYPE_EXT:\n \t\treturn \"External\";\n+\tcase TF_TBL_TYPE_METER_DROP_CNT:\n+\t\treturn \"Meter drop counter\";\n \tdefault:\n \t\treturn \"Invalid tbl type\";\n \t}\n", "prefixes": [ "v3", "03/13" ] }