Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98540/?format=api
{ "id": 98540, "url": "http://patches.dpdk.org/api/patches/98540/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210910130548.127017-2-miao.li@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210910130548.127017-2-miao.li@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210910130548.127017-2-miao.li@intel.com", "date": "2021-09-10T13:05:44", "name": "[1/5] net/virtio: implement rte_power_monitor API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "986c0446cc437306b2eaf00139c4209ef89a8a10", "submitter": { "id": 2220, "url": "http://patches.dpdk.org/api/people/2220/?format=api", "name": "Li, Miao", "email": "miao.li@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210910130548.127017-2-miao.li@intel.com/mbox/", "series": [ { "id": 18818, "url": "http://patches.dpdk.org/api/series/18818/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18818", "date": "2021-09-10T13:05:43", "name": "CPU Enabling: Implement rte_power_monitor API in virtio/vhost PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/18818/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/98540/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/98540/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 20049A0547;\n\tFri, 10 Sep 2021 07:03:55 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CC0D740DF4;\n\tFri, 10 Sep 2021 07:03:51 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 0006B4068C\n for <dev@dpdk.org>; Fri, 10 Sep 2021 07:03:49 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Sep 2021 22:03:49 -0700", "from limiao-icelake.sh.intel.com ([10.67.115.199])\n by fmsmga002.fm.intel.com with ESMTP; 09 Sep 2021 22:03:47 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10102\"; a=\"208102002\"", "E=Sophos;i=\"5.85,282,1624345200\"; d=\"scan'208\";a=\"208102002\"", "E=Sophos;i=\"5.85,282,1624345200\"; d=\"scan'208\";a=\"549003917\"" ], "X-ExtLoop1": "1", "From": "Miao Li <miao.li@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com,\n\tmaxime.coquelin@redhat.com,\n\tmiao.li@intel.com", "Date": "Fri, 10 Sep 2021 13:05:44 +0000", "Message-Id": "<20210910130548.127017-2-miao.li@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210910130548.127017-1-miao.li@intel.com>", "References": "<20210910130548.127017-1-miao.li@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch implements rte_power_monitor API in virtio PMD to reduce\npower consumption when no packet come in. According to current semantics\nof power monitor, this commit adds a callback function to decide whether\naborts the sleep by checking current value against the expected value and\nvirtio_get_monitor_addr to provide address to monitor. When no packet come\nin, the value of address will not be changed and the running core will\nsleep. Once packets arrive, the value of address will be changed and the\nrunning core will wakeup.\n\nSigned-off-by: Miao Li <miao.li@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 57 ++++++++++++++++++++++++++++++\n 1 file changed, 57 insertions(+)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex e58085a2c9..4ce49936f5 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -73,6 +73,8 @@ static int virtio_mac_addr_set(struct rte_eth_dev *dev,\n \t\t\t\tstruct rte_ether_addr *mac_addr);\n \n static int virtio_intr_disable(struct rte_eth_dev *dev);\n+static int virtio_get_monitor_addr(void *rx_queue,\n+\t\t\t\tstruct rte_power_monitor_cond *pmc);\n \n static int virtio_dev_queue_stats_mapping_set(\n \tstruct rte_eth_dev *eth_dev,\n@@ -975,6 +977,7 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {\n \t.mac_addr_add = virtio_mac_addr_add,\n \t.mac_addr_remove = virtio_mac_addr_remove,\n \t.mac_addr_set = virtio_mac_addr_set,\n+\t.get_monitor_addr = virtio_get_monitor_addr,\n };\n \n /*\n@@ -1306,6 +1309,60 @@ virtio_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)\n \treturn 0;\n }\n \n+#define CLB_VAL_IDX 0\n+#define CLB_MSK_IDX 1\n+static int\n+virtio_packed_monitor_callback(const uint64_t value,\n+\t\tconst uint64_t opaque[RTE_POWER_MONITOR_OPAQUE_SZ])\n+{\n+\tconst uint64_t m = opaque[CLB_MSK_IDX];\n+\tconst uint64_t v = opaque[CLB_VAL_IDX];\n+\n+\treturn (value & m) == v ? -1 : 0;\n+}\n+\n+static int\n+virtio_split_monitor_callback(const uint64_t value,\n+\t\tconst uint64_t opaque[RTE_POWER_MONITOR_OPAQUE_SZ])\n+{\n+\tconst uint64_t m = opaque[CLB_MSK_IDX];\n+\tconst uint64_t v = opaque[CLB_VAL_IDX];\n+\n+\treturn (value & m) == v ? 0 : -1;\n+}\n+\n+static int\n+virtio_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond *pmc)\n+{\n+\tstruct virtnet_rx *rxvq = rx_queue;\n+\tstruct virtqueue *vq = virtnet_rxq_to_vq(rxvq);\n+\tstruct virtio_hw *hw = vq->hw;\n+\tif (vq == NULL)\n+\t\treturn -EINVAL;\n+\tif (virtio_with_packed_queue(hw)) {\n+\t\tstruct vring_packed_desc *desc;\n+\t\tdesc = vq->vq_packed.ring.desc;\n+\t\tpmc->addr = &desc[vq->vq_used_cons_idx].flags;\n+\t\tif (vq->vq_packed.used_wrap_counter)\n+\t\t\tpmc->opaque[CLB_VAL_IDX] =\n+\t\t\t\t\t\tVRING_PACKED_DESC_F_AVAIL_USED;\n+\t\telse\n+\t\t\tpmc->opaque[CLB_VAL_IDX] = 0;\n+\t\tpmc->opaque[CLB_MSK_IDX] = VRING_PACKED_DESC_F_AVAIL_USED;\n+\t\tpmc->fn = virtio_packed_monitor_callback;\n+\t\tpmc->size = sizeof(uint16_t);\n+\t} else {\n+\t\tpmc->addr = &vq->vq_split.ring.used->idx;\n+\t\tpmc->opaque[CLB_VAL_IDX] = vq->vq_used_cons_idx\n+\t\t\t\t\t& (vq->vq_nentries - 1);\n+\t\tpmc->opaque[CLB_MSK_IDX] = vq->vq_nentries - 1;\n+\t\tpmc->fn = virtio_split_monitor_callback;\n+\t\tpmc->size = sizeof(uint16_t);\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n virtio_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n {\n", "prefixes": [ "1/5" ] }