Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97698/?format=api
{ "id": 97698, "url": "http://patches.dpdk.org/api/patches/97698/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210901142433.8444-15-venkatkumar.duvvuru@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210901142433.8444-15-venkatkumar.duvvuru@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210901142433.8444-15-venkatkumar.duvvuru@broadcom.com", "date": "2021-09-01T14:24:33", "name": "[14/14] net/bnxt: add support for testpmd co-existence", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d37fc7ab8a50ffe2f9ae6e8c3c83d802b3b0e36e", "submitter": { "id": 1635, "url": "http://patches.dpdk.org/api/people/1635/?format=api", "name": "Venkat Duvvuru", "email": "venkatkumar.duvvuru@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210901142433.8444-15-venkatkumar.duvvuru@broadcom.com/mbox/", "series": [ { "id": 18604, "url": "http://patches.dpdk.org/api/series/18604/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18604", "date": "2021-09-01T14:24:19", "name": "enhancements to host based flow table management", "version": 1, "mbox": "http://patches.dpdk.org/series/18604/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/97698/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/97698/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F6CDA0C45;\n\tWed, 1 Sep 2021 16:26:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B61914119A;\n\tWed, 1 Sep 2021 16:25:11 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.166.231])\n by mails.dpdk.org (Postfix) with ESMTP id 93F4341195\n for <dev@dpdk.org>; Wed, 1 Sep 2021 16:25:10 +0200 (CEST)", "from S60.dhcp.broadcom.net (unknown [10.123.66.170])\n (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 2DB382E2D4;\n Wed, 1 Sep 2021 07:25:08 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 2DB382E2D4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1630506310;\n bh=+z0pV8k9ZdjXszHHwF9QL8v7jGd+UhxrgXHRJw7T9yc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=RSAJUK3hmsOwS3utKF4UeMDLZ/MQcpC6tuRFJ/ZdTiFpNPmxnjImBKE0BDnaaKGkF\n MWVecM4hrYRtY96Ygu5wVyrNsiYIB3r0jPtFNDVsDs0AJFwYRSQ1aoq+30QCVz4x9c\n 7TGrNhYMYTp/4cVY1+uxMIEMqeIPeNtRpfJUqc0A=", "From": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Wed, 1 Sep 2021 19:54:33 +0530", "Message-Id": "<20210901142433.8444-15-venkatkumar.duvvuru@broadcom.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210901142433.8444-1-venkatkumar.duvvuru@broadcom.com>", "References": "<20210901142433.8444-1-venkatkumar.duvvuru@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 14/14] net/bnxt: add support for testpmd\n co-existence", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, testpmd support in ULP is enabled only during compilation\ntime. This patch adds support for testpmd during runtime using\ndevarg \"testpmd\".\n\nSigned-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 3 ++\n drivers/net/bnxt/bnxt_ethdev.c | 56 +++++++++++++++++++++++++\n drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 5 +++\n drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 4 +-\n 4 files changed, 67 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 494a1eff37..c9adc66fda 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -722,6 +722,9 @@ struct bnxt {\n \t((bp)->flags2 & BNXT_FLAGS2_PTP_TIMESYNC_ENABLED)\n #define\tBNXT_ACCUM_STATS_EN(bp)\t\t\t\\\n \t((bp)->flags2 & BNXT_FLAGS2_ACCUM_STATS_EN)\n+#define\tBNXT_FLAGS2_TESTPMD_EN\t\t\tBIT(3)\n+#define\tBNXT_TESTPMD_EN(bp)\t\t\t\\\n+\t((bp)->flags2 & BNXT_FLAGS2_TESTPMD_EN)\n \n \tuint16_t\t\tchip_num;\n #define CHIP_NUM_58818\t\t0xd818\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex de34a2f0bb..20c5b12b53 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -98,6 +98,7 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {\n #define BNXT_DEVARG_REP_FC_R2F \"rep-fc-r2f\"\n #define BNXT_DEVARG_REP_FC_F2R \"rep-fc-f2r\"\n #define BNXT_DEVARG_APP_ID\t\"app-id\"\n+#define\tBNXT_DEVARG_TESTPMD\t\"testpmd\"\n \n static const char *const bnxt_dev_args[] = {\n \tBNXT_DEVARG_REPRESENTOR,\n@@ -111,9 +112,17 @@ static const char *const bnxt_dev_args[] = {\n \tBNXT_DEVARG_REP_FC_R2F,\n \tBNXT_DEVARG_REP_FC_F2R,\n \tBNXT_DEVARG_APP_ID,\n+\tBNXT_DEVARG_TESTPMD,\n \tNULL\n };\n \n+/*\n+ * testpmd == false to disable\n+ * testpmd == true to enable\n+ */\n+#define\tBNXT_DEVARG_TESTPMD_INVALID(truflow)\t\t((testpmd) > 1)\n+\n+\n /*\n * accum-stats == false to disable flow counter accumulation\n * accum-stats == true to enable flow counter accumulation\n@@ -5853,6 +5862,44 @@ bnxt_parse_devarg_rep_fc_f2r(__rte_unused const char *key,\n \treturn 0;\n }\n \n+static int\n+bnxt_parse_devarg_testpmd(__rte_unused const char *key,\n+\t\t\t const char *value, void *opaque_arg)\n+{\n+\tstruct bnxt *bp = opaque_arg;\n+\tunsigned long testpmd;\n+\tchar *end = NULL;\n+\n+\tif (!value || !opaque_arg) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Invalid parameter passed to testpmd devargs.\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\ttestpmd = strtoul(value, &end, 10);\n+\tif (end == NULL || *end != '\\0' ||\n+\t (testpmd == ULONG_MAX && errno == ERANGE)) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Invalid parameter passed to testpmd devargs.\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (BNXT_DEVARG_TESTPMD_INVALID(testpmd)) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Invalid value passed to testpmd devargs.\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (testpmd) {\n+\t\tbp->flags2 |= BNXT_FLAGS2_TESTPMD_EN;\n+\t\tPMD_DRV_LOG(INFO, \"Host-based testpmd feature enabled.\\n\");\n+\t} else {\n+\t\tbp->flags2 &= ~BNXT_FLAGS2_TESTPMD_EN;\n+\t\tPMD_DRV_LOG(INFO, \"Host-based testpmd feature disabled.\\n\");\n+\t}\n+\n+\treturn 0;\n+}\n static int\n bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs)\n {\n@@ -5890,6 +5937,15 @@ bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs)\n \tif (ret)\n \t\tgoto err;\n \n+\t/*\n+\t * Handler for \"testpmd\" devarg.\n+\t * Invoked as for ex: \"-a 0000:00:0d.0,testpmd=1\"\n+\t */\n+\tret = rte_kvargs_process(kvlist, BNXT_DEVARG_TESTPMD,\n+\t\t\t\t bnxt_parse_devarg_testpmd, bp);\n+\tif (ret)\n+\t\tgoto err;\n+\n err:\n \t/*\n \t * Handler for \"app-id\" devarg.\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\nindex 3b86410fb1..2ad662fb17 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n@@ -844,6 +844,11 @@ ulp_ctx_init(struct bnxt *bp,\n \t\tgoto error_deinit;\n \t}\n \n+\tif (BNXT_TESTPMD_EN(bp)) {\n+\t\tulp_data->ulp_flags &= ~BNXT_ULP_VF_REP_ENABLED;\n+\t\tBNXT_TF_DBG(ERR, \"Enabled Testpmd forward mode\\n\");\n+\t}\n+\n \t/*\n \t * Shared session must be created before first regular session but after\n \t * the ulp_ctx is valid.\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\nindex d8336d164e..827fe30acd 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\n@@ -526,8 +526,10 @@ bnxt_ulp_create_df_rules(struct bnxt *bp)\n \trc = ulp_default_flow_db_cfa_action_get(bp->ulp_ctx,\n \t\t\t\t\t\tinfo->def_port_flow_id,\n \t\t\t\t\t\t&bp->tx_cfa_action);\n-\tif (rc)\n+\n+\tif (rc || BNXT_TESTPMD_EN(bp))\n \t\tbp->tx_cfa_action = 0;\n+\n \tinfo->valid = true;\n \treturn 0;\n }\n", "prefixes": [ "14/14" ] }