Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97445/?format=api
{ "id": 97445, "url": "http://patches.dpdk.org/api/patches/97445/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-27-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210827065717.1838258-27-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210827065717.1838258-27-andrew.rybchenko@oktetlabs.ru", "date": "2021-08-27T06:57:05", "name": "[26/38] net/sfc: add simple port representor statistics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3f367011ad96c256b2d14e968619dfd567e50c4a", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-27-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 18492, "url": "http://patches.dpdk.org/api/series/18492/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18492", "date": "2021-08-27T06:56:39", "name": "net/sfc: support port representors", "version": 1, "mbox": "http://patches.dpdk.org/series/18492/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/97445/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/97445/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 08D55A0C43;\n\tFri, 27 Aug 2021 09:00:39 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 47E18412D1;\n\tFri, 27 Aug 2021 08:58:57 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id DC6EB412BF\n for <dev@dpdk.org>; Fri, 27 Aug 2021 08:58:53 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id AB4EF7F6E2; Fri, 27 Aug 2021 09:58:53 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id A66857F6ED;\n Fri, 27 Aug 2021 09:57:35 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A66857F6ED", "Authentication-Results": "shelob.oktetlabs.ru/A66857F6ED; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Igor Romanov <igor.romanov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>, Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Fri, 27 Aug 2021 09:57:05 +0300", "Message-Id": "<20210827065717.1838258-27-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 26/38] net/sfc: add simple port representor\n statistics", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nGather statistics of enqueued and dequeued packets in Rx and Tx burst\ncallbacks to report in stats_get callback.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_repr.c | 60 ++++++++++++++++++++++++++++++++++++--\n 1 file changed, 58 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c\nindex a436b7e5e1..4fd81c3f6b 100644\n--- a/drivers/net/sfc/sfc_repr.c\n+++ b/drivers/net/sfc/sfc_repr.c\n@@ -32,9 +32,14 @@ struct sfc_repr_shared {\n \tuint16_t\t\tswitch_port_id;\n };\n \n+struct sfc_repr_queue_stats {\n+\tunion sfc_pkts_bytes\t\tpackets_bytes;\n+};\n+\n struct sfc_repr_rxq {\n \t/* Datapath members */\n \tstruct rte_ring\t\t\t*ring;\n+\tstruct sfc_repr_queue_stats\tstats;\n \n \t/* Non-datapath members */\n \tstruct sfc_repr_shared\t\t*shared;\n@@ -45,6 +50,7 @@ struct sfc_repr_txq {\n \t/* Datapath members */\n \tstruct rte_ring\t\t\t*ring;\n \tefx_mport_id_t\t\t\tegress_mport;\n+\tstruct sfc_repr_queue_stats\tstats;\n \n \t/* Non-datapath members */\n \tstruct sfc_repr_shared\t\t*shared;\n@@ -173,15 +179,30 @@ sfc_repr_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n {\n \tstruct sfc_repr_rxq *rxq = rx_queue;\n \tvoid **objs = (void *)&rx_pkts[0];\n+\tunsigned int n_rx;\n \n \t/* mbufs port is already filled correctly by representors proxy */\n-\treturn rte_ring_sc_dequeue_burst(rxq->ring, objs, nb_pkts, NULL);\n+\tn_rx = rte_ring_sc_dequeue_burst(rxq->ring, objs, nb_pkts, NULL);\n+\n+\tif (n_rx > 0) {\n+\t\tunsigned int n_bytes = 0;\n+\t\tunsigned int i = 0;\n+\n+\t\tdo {\n+\t\t\tn_bytes += rx_pkts[i]->pkt_len;\n+\t\t} while (++i < n_rx);\n+\n+\t\tsfc_pkts_bytes_add(&rxq->stats.packets_bytes, n_rx, n_bytes);\n+\t}\n+\n+\treturn n_rx;\n }\n \n static uint16_t\n sfc_repr_tx_burst(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n {\n \tstruct sfc_repr_txq *txq = tx_queue;\n+\tunsigned int n_bytes = 0;\n \tunsigned int n_tx;\n \tvoid **objs;\n \tuint16_t i;\n@@ -201,6 +222,7 @@ sfc_repr_tx_burst(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\tm->ol_flags |= sfc_dp_mport_override;\n \t\t*RTE_MBUF_DYNFIELD(m, sfc_dp_mport_offset,\n \t\t\t\t efx_mport_id_t *) = txq->egress_mport;\n+\t\tn_bytes += tx_pkts[i]->pkt_len;\n \t}\n \n \tobjs = (void *)&tx_pkts[0];\n@@ -210,14 +232,18 @@ sfc_repr_tx_burst(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t * Remove m-port override flag from packets that were not enqueued\n \t * Setting the flag only for enqueued packets after the burst is\n \t * not possible since the ownership of enqueued packets is\n-\t * transferred to representor proxy.\n+\t * transferred to representor proxy. The same logic applies to\n+\t * counting the enqueued packets' bytes.\n \t */\n \tfor (i = n_tx; i < nb_pkts; ++i) {\n \t\tstruct rte_mbuf *m = tx_pkts[i];\n \n \t\tm->ol_flags &= ~sfc_dp_mport_override;\n+\t\tn_bytes -= m->pkt_len;\n \t}\n \n+\tsfc_pkts_bytes_add(&txq->stats.packets_bytes, n_tx, n_bytes);\n+\n \treturn n_tx;\n }\n \n@@ -849,6 +875,35 @@ sfc_repr_dev_close(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static int\n+sfc_repr_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+{\n+\tunion sfc_pkts_bytes queue_stats;\n+\tuint16_t i;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct sfc_repr_rxq *rxq = dev->data->rx_queues[i];\n+\n+\t\tsfc_pkts_bytes_get(&rxq->stats.packets_bytes,\n+\t\t\t\t &queue_stats);\n+\n+\t\tstats->ipackets += queue_stats.pkts;\n+\t\tstats->ibytes += queue_stats.bytes;\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct sfc_repr_txq *txq = dev->data->tx_queues[i];\n+\n+\t\tsfc_pkts_bytes_get(&txq->stats.packets_bytes,\n+\t\t\t\t &queue_stats);\n+\n+\t\tstats->opackets += queue_stats.pkts;\n+\t\tstats->obytes += queue_stats.bytes;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static const struct eth_dev_ops sfc_repr_dev_ops = {\n \t.dev_configure\t\t\t= sfc_repr_dev_configure,\n \t.dev_start\t\t\t= sfc_repr_dev_start,\n@@ -856,6 +911,7 @@ static const struct eth_dev_ops sfc_repr_dev_ops = {\n \t.dev_close\t\t\t= sfc_repr_dev_close,\n \t.dev_infos_get\t\t\t= sfc_repr_dev_infos_get,\n \t.link_update\t\t\t= sfc_repr_dev_link_update,\n+\t.stats_get\t\t\t= sfc_repr_stats_get,\n \t.rx_queue_setup\t\t\t= sfc_repr_rx_queue_setup,\n \t.rx_queue_release\t\t= sfc_repr_rx_queue_release,\n \t.tx_queue_setup\t\t\t= sfc_repr_tx_queue_setup,\n", "prefixes": [ "26/38" ] }