Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97439/?format=api
{ "id": 97439, "url": "http://patches.dpdk.org/api/patches/97439/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-24-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210827065717.1838258-24-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210827065717.1838258-24-andrew.rybchenko@oktetlabs.ru", "date": "2021-08-27T06:57:02", "name": "[23/38] net/sfc: use xword type for EF100 Rx prefix", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "945bcbbd031437bd4b303cddbad6ceccd37b04a1", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-24-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 18492, "url": "http://patches.dpdk.org/api/series/18492/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18492", "date": "2021-08-27T06:56:39", "name": "net/sfc: support port representors", "version": 1, "mbox": "http://patches.dpdk.org/series/18492/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/97439/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/97439/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C31A7A0C43;\n\tFri, 27 Aug 2021 08:59:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 771AC412B5;\n\tFri, 27 Aug 2021 08:58:47 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 4D7524129B\n for <dev@dpdk.org>; Fri, 27 Aug 2021 08:58:42 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 25EF57F6E0; Fri, 27 Aug 2021 09:58:42 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 54A4D7F6E9;\n Fri, 27 Aug 2021 09:57:35 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 54A4D7F6E9", "Authentication-Results": "shelob.oktetlabs.ru/54A4D7F6E9; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Igor Romanov <igor.romanov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>, Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Fri, 27 Aug 2021 09:57:02 +0300", "Message-Id": "<20210827065717.1838258-24-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 23/38] net/sfc: use xword type for EF100 Rx prefix", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nLayout of the EF100 Rx prefix is defined in terms of a 32 bytes long\nvalue type (xword). Replace oword with xword to avoid truncation.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_ef100_rx.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c\nindex d4cb96881c..15fce55361 100644\n--- a/drivers/net/sfc/sfc_ef100_rx.c\n+++ b/drivers/net/sfc/sfc_ef100_rx.c\n@@ -379,7 +379,7 @@ static const efx_rx_prefix_layout_t sfc_ef100_rx_prefix_layout = {\n \n static bool\n sfc_ef100_rx_prefix_to_offloads(const struct sfc_ef100_rxq *rxq,\n-\t\t\t\tconst efx_oword_t *rx_prefix,\n+\t\t\t\tconst efx_xword_t *rx_prefix,\n \t\t\t\tstruct rte_mbuf *m)\n {\n \tconst efx_word_t *class;\n@@ -399,19 +399,19 @@ sfc_ef100_rx_prefix_to_offloads(const struct sfc_ef100_rxq *rxq,\n \tm->packet_type = sfc_ef100_rx_class_decode(*class, &ol_flags);\n \n \tif ((rxq->flags & SFC_EF100_RXQ_RSS_HASH) &&\n-\t EFX_TEST_OWORD_BIT(rx_prefix[0],\n+\t EFX_TEST_XWORD_BIT(rx_prefix[0],\n \t\t\t ESF_GZ_RX_PREFIX_RSS_HASH_VALID_LBN)) {\n \t\tol_flags |= PKT_RX_RSS_HASH;\n-\t\t/* EFX_OWORD_FIELD converts little-endian to CPU */\n-\t\tm->hash.rss = EFX_OWORD_FIELD(rx_prefix[0],\n+\t\t/* EFX_XWORD_FIELD converts little-endian to CPU */\n+\t\tm->hash.rss = EFX_XWORD_FIELD(rx_prefix[0],\n \t\t\t\t\t ESF_GZ_RX_PREFIX_RSS_HASH);\n \t}\n \n \tif (rxq->flags & SFC_EF100_RXQ_USER_MARK) {\n \t\tuint32_t user_mark;\n \n-\t\t/* EFX_OWORD_FIELD converts little-endian to CPU */\n-\t\tuser_mark = EFX_OWORD_FIELD(rx_prefix[0],\n+\t\t/* EFX_XWORD_FIELD converts little-endian to CPU */\n+\t\tuser_mark = EFX_XWORD_FIELD(rx_prefix[0],\n \t\t\t\t\t ESF_GZ_RX_PREFIX_USER_MARK);\n \t\tif (user_mark != SFC_EF100_USER_MARK_INVALID) {\n \t\t\tol_flags |= PKT_RX_FDIR_ID;\n@@ -480,7 +480,7 @@ sfc_ef100_rx_process_ready_pkts(struct sfc_ef100_rxq *rxq,\n \twhile (rxq->ready_pkts > 0 && rx_pkts != rx_pkts_end) {\n \t\tstruct rte_mbuf *pkt;\n \t\tstruct rte_mbuf *lastseg;\n-\t\tconst efx_oword_t *rx_prefix;\n+\t\tconst efx_xword_t *rx_prefix;\n \t\tuint16_t pkt_len;\n \t\tuint16_t seg_len;\n \t\tbool deliver;\n@@ -495,9 +495,9 @@ sfc_ef100_rx_process_ready_pkts(struct sfc_ef100_rxq *rxq,\n \t\tpkt->rearm_data[0] = rxq->rearm_data;\n \n \t\t/* data_off already moved past Rx prefix */\n-\t\trx_prefix = (const efx_oword_t *)sfc_ef100_rx_pkt_prefix(pkt);\n+\t\trx_prefix = (const efx_xword_t *)sfc_ef100_rx_pkt_prefix(pkt);\n \n-\t\tpkt_len = EFX_OWORD_FIELD(rx_prefix[0],\n+\t\tpkt_len = EFX_XWORD_FIELD(rx_prefix[0],\n \t\t\t\t\t ESF_GZ_RX_PREFIX_LENGTH);\n \t\tSFC_ASSERT(pkt_len > 0);\n \t\trte_pktmbuf_pkt_len(pkt) = pkt_len;\n", "prefixes": [ "23/38" ] }