Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97217/?format=api
{ "id": 97217, "url": "http://patches.dpdk.org/api/patches/97217/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210823085511.3079434-1-asafp@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210823085511.3079434-1-asafp@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210823085511.3079434-1-asafp@nvidia.com", "date": "2021-08-23T08:55:11", "name": "[1/1] net/mlx5: add stub functions to null drv ops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ead41d6c1dc90f735a4ea6fe0e72df1cdc8ca32b", "submitter": { "id": 1892, "url": "http://patches.dpdk.org/api/people/1892/?format=api", "name": "Asaf Penso", "email": "asafp@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210823085511.3079434-1-asafp@nvidia.com/mbox/", "series": [ { "id": 18405, "url": "http://patches.dpdk.org/api/series/18405/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18405", "date": "2021-08-23T08:55:11", "name": "[1/1] net/mlx5: add stub functions to null drv ops", "version": 1, "mbox": "http://patches.dpdk.org/series/18405/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/97217/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/97217/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B75E9A0C56;\n\tMon, 23 Aug 2021 10:55:41 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D05824014D;\n\tMon, 23 Aug 2021 10:55:40 +0200 (CEST)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52])\n by mails.dpdk.org (Postfix) with ESMTP id 0C74240143\n for <dev@dpdk.org>; Mon, 23 Aug 2021 10:55:39 +0200 (CEST)", "from MWHPR1701CA0013.namprd17.prod.outlook.com\n (2603:10b6:301:14::23) by MN2PR12MB3950.namprd12.prod.outlook.com\n (2603:10b6:208:16d::10) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug\n 2021 08:55:35 +0000", "from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com\n (2603:10b6:301:14:cafe::ca) by MWHPR1701CA0013.outlook.office365.com\n (2603:10b6:301:14::23) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend\n Transport; Mon, 23 Aug 2021 08:55:35 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4436.19 via Frontend Transport; Mon, 23 Aug 2021 08:55:35 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 23 Aug\n 2021 08:55:33 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=NjvoAjujKkvqFX59WA7iw7rQ4TqIZAxjoPuCPT9fr6lebTpd5cwkYObymjpNhZEbQzCjdWxIe75euw6Jum/eru0mmiOormvHRzBt549+ZwB72C8+v8QgPwENczTJocM6k4xgRjwxtkVtvQToJtB0HxwQjxFlDrh7/P0X7HY7jNQn9mff/cC6w4A588fnQNpmGzywaCd4rGLMSJMrBEXiiOOZ+U7ORoiIYUUD2Me/gndge1ij4+vis6bQ6oRkxkPB4mkTwl8Zg4qPL9UCrxrDWHGnLgVyOJYQjOTf+dkQ9P5yGdcpSZ488xRW+ueoXCH//WplEr9weuScRpHKcoIFJw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AHJps43oAfpJWblfdsRO+GlDG4AYnohIOOrb+lTW82U=;\n b=YC93xk4HwwqPHAhJ9eJtoJG35mVl4uv/C561FkVUNwj3HjBoFZrtqSvnQV9FQoOgaNlZuFWj+w27GTeXKi1P2KQpfHgcJweieWvENjytRgd0LiWSWpoysVgzA/G1aQSTZABNiUuiaG/fvoxoehHP8DtQeDT40j9VU/aEvd6XKyxJLOGRTugVDIopecMuO32Vt7sIrRcCua3fvVF4HTg5l4SuqCLmBFJf0tbdyOe8z7SlAFM526NXjx8PaHsghz/12nJ554vfkXPRJgkRXlcKtXzeEgYwbOmBnm5itMnkz8aP04Ok+mFZKHkIOjWgAMM1OWgCCD51ww/eRKXnDNN77w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AHJps43oAfpJWblfdsRO+GlDG4AYnohIOOrb+lTW82U=;\n b=UIPU58YXW0FuELUR9Ep5sXFRWt5y7U071LTN6vWT0zAFkEsf+lDpizfbb18ic0dTKh6ENXFZGy3tQAM89BnhPz/X7CoSjHLV9DAoJRsIl9ewoqS7vlSc6yVcH/exP5PqrlPZODcXANa3cjN7ho80lyC0FCfFPh5WO2urR0LK49ZXAfXIw5+9sK/IcPgKgjiUoxR4OTbKsZFEmxmrcS/y7xx18G6i4/uVX1whLCQqScfjMuVmv/u6zGw6+lg76MvS4OpMh0YmiSLvvWiUWl3x4vkMpcP+vNcD4+s2LPb+yTwCwDoxz20WHiABTqoNcztTdiYvqGDfvdrNZaL9Hc0Pxg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)\n header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Asaf Penso <asafp@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <viacheslavo@nvidia.com>, <matan@nvidia.com>,\n <rasland@nvidia.com>", "Date": "Mon, 23 Aug 2021 11:55:11 +0300", "Message-ID": "<20210823085511.3079434-1-asafp@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "2a6b50ed-0c56-4c38-e501-08d96613c582", "X-MS-TrafficTypeDiagnostic": "MN2PR12MB3950:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <MN2PR12MB3950467DA7EF8FC2956B80E0CDC49@MN2PR12MB3950.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:949;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n tpggCkfsjFuC4sXAYOYq79CBfnM6vh8LpBxCZ+wnh4GwzzBJdT88pt53ReFYqcWTRphfL0+rp5bFWizduADecQjYMNdQQScCrBoDLGD8hcfY9Dpbtlh4EVBjADZlp3gIOhgLGxrjhbhM8L2QYASfSW1ezyhLlaPaV0DTsCArx4A8adipfuClik0J1LP8krCZXwnYSBN5dBzWsQOA5UgfKiEnZ4aLmD2EF2m+swz2nJ+K+TmXV0w9F7894znQuGRirw4hf9SApAEMXRHf0cHPDUtHYaDQTt+pyWy0S+1KRnGvy+acHjRT0VN3o/7cUps35R2Zefg4s4gictSV2OCeeJtWuA1ZX4NstDIHV6pZccCdxvC6krxatWmUaEWsQxM4oewGlyKPECGYrACre0euIUZvAYs9HwYAGaAdgiJmviz+EgTyRwOgnFcVH96z0odgi/dG1EYe1j5pjkPWfp9VVr0e9tbVnDC6/qA3gChLBeadvZ3Vc6ZgJa3Idl5GgkCeQPOyWzFK8LmoMEdMJqkmKxHCBUCYKLvelNUlxq/9wEgfdpWfw/YwWJnIKyse5pkTI/uEaET9V9ev6zGoUHC22DfVGS+OciFceMYtef4ss1+mnjtxLbizm7t1S+KgUE29TMYg5yaFXceg+jpsrcTDjRPHb1LiwsX9Gq1LB8mh8OJFJryM5SrixVELlpJSamn7FA/I5QxQg17iptpn/bQP4A==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(39860400002)(396003)(136003)(346002)(376002)(46966006)(36840700001)(186003)(16526019)(2616005)(5660300002)(107886003)(426003)(6666004)(6286002)(82310400003)(4326008)(36906005)(336012)(55016002)(70586007)(70206006)(36756003)(83380400001)(6916009)(1076003)(478600001)(356005)(7636003)(47076005)(82740400003)(36860700001)(7696005)(2906002)(8676002)(26005)(8936002)(54906003)(316002)(86362001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Aug 2021 08:55:35.2578 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 2a6b50ed-0c56-4c38-e501-08d96613c582", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT050.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB3950", "Subject": "[dpdk-dev] [PATCH 1/1] net/mlx5: add stub functions to null drv ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are several functions implementation that queries the drv type\nto understand which fops function to use.\nIn case the type is DV, the fucntion gets the concrete DV function and\ncalls it.\nIn case it’s not, the function returns an error.\n\nThe current implementation is not flexible enough and will not support\nfuture concrete functions in a good way.\n\nThis patch adds more stub functions that include error handling and\nare assigned to the null drv ops struct.\nThis allows the functions to always call the virtual function without\nbasing the decision on a specific drv type.\n\nSigned-off-by: Asaf Penso <asafp@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 87 +++++++++++++++++-------------\n drivers/net/mlx5/mlx5_flow.h | 12 +++++\n drivers/net/mlx5/mlx5_flow_verbs.c | 4 ++\n 3 files changed, 66 insertions(+), 37 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex e63a297e2a..894c16ba20 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -3231,6 +3231,45 @@ flow_null_sync_domain(struct rte_eth_dev *dev __rte_unused,\n \treturn 0;\n }\n \n+int\n+flow_null_get_aged_flows(struct rte_eth_dev *dev,\n+\t\t void **context __rte_unused,\n+\t\t uint32_t nb_contexts __rte_unused,\n+\t\t struct rte_flow_error *error __rte_unused)\n+{\n+\tDRV_LOG(ERR, \"port %u get aged flows is not supported.\",\n+\t\tdev->data->port_id);\n+\treturn -ENOTSUP;\n+}\n+\n+uint32_t\n+flow_null_counter_allocate(struct rte_eth_dev *dev)\n+{\n+\tDRV_LOG(ERR, \"port %u counter allocate is not supported.\",\n+\t\tdev->data->port_id);\n+\treturn 0;\n+}\n+\n+void\n+flow_null_counter_free(struct rte_eth_dev *dev,\n+\t\t\tuint32_t counter __rte_unused)\n+{\n+\tDRV_LOG(ERR, \"port %u counter free is not supported.\",\n+\t\t dev->data->port_id);\n+}\n+\n+int\n+flow_null_counter_query(struct rte_eth_dev *dev,\n+\t\t\tuint32_t counter __rte_unused,\n+\t\t\tbool clear __rte_unused,\n+\t\t\tuint64_t *pkts __rte_unused,\n+\t\t\tuint64_t *bytes __rte_unused)\n+{\n+\tDRV_LOG(ERR, \"port %u counter query is not supported.\",\n+\t\t dev->data->port_id);\n+\treturn -ENOTSUP;\n+}\n+\n /* Void driver to protect from null pointer reference. */\n const struct mlx5_flow_driver_ops mlx5_flow_null_drv_ops = {\n \t.validate = flow_null_validate,\n@@ -3241,6 +3280,10 @@ const struct mlx5_flow_driver_ops mlx5_flow_null_drv_ops = {\n \t.destroy = flow_null_destroy,\n \t.query = flow_null_query,\n \t.sync_domain = flow_null_sync_domain,\n+\t.get_aged_flows = flow_null_get_aged_flows,\n+\t.counter_alloc = flow_null_counter_allocate,\n+\t.counter_free = flow_null_counter_free,\n+\t.counter_query = flow_null_counter_query,\n };\n \n /**\n@@ -7497,17 +7540,10 @@ mlx5_flow_mtr_free(struct rte_eth_dev *dev, uint32_t mtr_idx)\n uint32_t\n mlx5_counter_alloc(struct rte_eth_dev *dev)\n {\n-\tconst struct mlx5_flow_driver_ops *fops;\n \tstruct rte_flow_attr attr = { .transfer = 0 };\n \n-\tif (flow_get_drv_type(dev, &attr) == MLX5_FLOW_TYPE_DV) {\n-\t\tfops = flow_get_drv_ops(MLX5_FLOW_TYPE_DV);\n-\t\treturn fops->counter_alloc(dev);\n-\t}\n-\tDRV_LOG(ERR,\n-\t\t\"port %u counter allocate is not supported.\",\n-\t\t dev->data->port_id);\n-\treturn 0;\n+\treturn flow_get_drv_ops(flow_get_drv_type(dev, &attr))->counter_alloc\n+\t\t(dev);\n }\n \n /**\n@@ -7521,17 +7557,9 @@ mlx5_counter_alloc(struct rte_eth_dev *dev)\n void\n mlx5_counter_free(struct rte_eth_dev *dev, uint32_t cnt)\n {\n-\tconst struct mlx5_flow_driver_ops *fops;\n \tstruct rte_flow_attr attr = { .transfer = 0 };\n \n-\tif (flow_get_drv_type(dev, &attr) == MLX5_FLOW_TYPE_DV) {\n-\t\tfops = flow_get_drv_ops(MLX5_FLOW_TYPE_DV);\n-\t\tfops->counter_free(dev, cnt);\n-\t\treturn;\n-\t}\n-\tDRV_LOG(ERR,\n-\t\t\"port %u counter free is not supported.\",\n-\t\t dev->data->port_id);\n+\tflow_get_drv_ops(flow_get_drv_type(dev, &attr))->counter_free(dev, cnt);\n }\n \n /**\n@@ -7555,17 +7583,10 @@ int\n mlx5_counter_query(struct rte_eth_dev *dev, uint32_t cnt,\n \t\t bool clear, uint64_t *pkts, uint64_t *bytes)\n {\n-\tconst struct mlx5_flow_driver_ops *fops;\n \tstruct rte_flow_attr attr = { .transfer = 0 };\n \n-\tif (flow_get_drv_type(dev, &attr) == MLX5_FLOW_TYPE_DV) {\n-\t\tfops = flow_get_drv_ops(MLX5_FLOW_TYPE_DV);\n-\t\treturn fops->counter_query(dev, cnt, clear, pkts, bytes);\n-\t}\n-\tDRV_LOG(ERR,\n-\t\t\"port %u counter query is not supported.\",\n-\t\t dev->data->port_id);\n-\treturn -ENOTSUP;\n+\treturn flow_get_drv_ops(flow_get_drv_type(dev, &attr))->counter_query\n+\t\t(dev, cnt, clear, pkts, bytes);\n }\n \n /**\n@@ -8279,18 +8300,10 @@ int\n mlx5_flow_get_aged_flows(struct rte_eth_dev *dev, void **contexts,\n \t\t\tuint32_t nb_contexts, struct rte_flow_error *error)\n {\n-\tconst struct mlx5_flow_driver_ops *fops;\n \tstruct rte_flow_attr attr = { .transfer = 0 };\n \n-\tif (flow_get_drv_type(dev, &attr) == MLX5_FLOW_TYPE_DV) {\n-\t\tfops = flow_get_drv_ops(MLX5_FLOW_TYPE_DV);\n-\t\treturn fops->get_aged_flows(dev, contexts, nb_contexts,\n-\t\t\t\t\t\t error);\n-\t}\n-\tDRV_LOG(ERR,\n-\t\t\"port %u get aged flows is not supported.\",\n-\t\t dev->data->port_id);\n-\treturn -ENOTSUP;\n+\treturn flow_get_drv_ops(flow_get_drv_type(dev, &attr))->get_aged_flows\n+\t\t(dev, contexts, nb_contexts, error);\n }\n \n /* Wrapper for driver action_validate op callback */\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 76ad53f2a1..bb23a5efce 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -1713,5 +1713,17 @@ mlx5_get_tof(const struct rte_flow_item *items,\n \t const struct rte_flow_action *actions,\n \t enum mlx5_tof_rule_type *rule_type);\n \n+int flow_null_get_aged_flows(struct rte_eth_dev *dev,\n+\t\t void **context,\n+\t\t uint32_t nb_contexts,\n+\t\t struct rte_flow_error *error);\n+uint32_t flow_null_counter_allocate(struct rte_eth_dev *dev);\n+void flow_null_counter_free(struct rte_eth_dev *dev,\n+\t\t\tuint32_t counter);\n+int flow_null_counter_query(struct rte_eth_dev *dev,\n+\t\t\tuint32_t counter,\n+\t\t\tbool clear,\n+\t\t uint64_t *pkts,\n+\t\t\tuint64_t *bytes);\n \n #endif /* RTE_PMD_MLX5_FLOW_H_ */\ndiff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flow_verbs.c\nindex b93fd4d2c9..b90d683916 100644\n--- a/drivers/net/mlx5/mlx5_flow_verbs.c\n+++ b/drivers/net/mlx5/mlx5_flow_verbs.c\n@@ -2105,4 +2105,8 @@ const struct mlx5_flow_driver_ops mlx5_flow_verbs_drv_ops = {\n \t.destroy = flow_verbs_destroy,\n \t.query = flow_verbs_query,\n \t.sync_domain = flow_verbs_sync_domain,\n+\t.get_aged_flows = flow_null_get_aged_flows,\n+\t.counter_alloc = flow_null_counter_allocate,\n+\t.counter_free = flow_null_counter_free,\n+\t.counter_query = flow_null_counter_query,\n };\n", "prefixes": [ "1/1" ] }