Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 96483,
    "url": "http://patches.dpdk.org/api/patches/96483/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1627684312-28630-4-git-send-email-navasile@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1627684312-28630-4-git-send-email-navasile@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1627684312-28630-4-git-send-email-navasile@linux.microsoft.com",
    "date": "2021-07-30T22:31:45",
    "name": "[v11,03/10] eal/windows: translate Windows errors to errno-style errors",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "9725bce2bebf7e251b2527aca2df0353e6c8d894",
    "submitter": {
        "id": 1668,
        "url": "http://patches.dpdk.org/api/people/1668/?format=api",
        "name": "Narcisa Ana Maria Vasile",
        "email": "navasile@linux.microsoft.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1627684312-28630-4-git-send-email-navasile@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 18112,
            "url": "http://patches.dpdk.org/api/series/18112/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=18112",
            "date": "2021-07-30T22:31:42",
            "name": "eal: Add EAL API for threading",
            "version": 11,
            "mbox": "http://patches.dpdk.org/series/18112/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/96483/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/96483/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B2647A0C40;\n\tSat, 31 Jul 2021 00:32:16 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D17D741102;\n\tSat, 31 Jul 2021 00:32:03 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 9543040E28\n for <dev@dpdk.org>; Sat, 31 Jul 2021 00:31:59 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1059)\n id EA2B820B36ED; Fri, 30 Jul 2021 15:31:58 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com EA2B820B36ED",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1627684318;\n bh=LF1D8eN+wBAeduli9A3YQUhlSeXFC+kfXFxFmQlfZSU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=HmSa7oGb7E53ANxTkH1t2+to2BRJd1COynCPF4CYN9aFB6QAHIyNfy5mfFso1aCN5\n p98yHegXmIOJp1jKNrkC/E0XbCkOijYjETmtP2RNbuT8xyTUgxmnz1yesfo7bN9S8A\n 0vsFOxb5ZfkngtxuV/qAqi83+MbJ6w3vVYRs8Hgg=",
        "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>",
        "To": "dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com,\n khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com,\n roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com",
        "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n pallavi.kadam@intel.com",
        "Date": "Fri, 30 Jul 2021 15:31:45 -0700",
        "Message-Id": "<1627684312-28630-4-git-send-email-navasile@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1627684312-28630-1-git-send-email-navasile@linux.microsoft.com>",
        "References": "<1624051606-26779-1-git-send-email-navasile@linux.microsoft.com>\n <1627684312-28630-1-git-send-email-navasile@linux.microsoft.com>",
        "Subject": "[dpdk-dev] [PATCH v11 03/10] eal/windows: translate Windows errors\n to errno-style errors",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Narcisa Vasile <navasile@microsoft.com>\n\nAdd function to translate Windows error codes to\nerrno-style error codes. The possible return values are chosen\nso that we have as much semantical compatibility between platforms as\npossible.\n\nSigned-off-by: Narcisa Vasile <navasile@microsoft.com>\n---\n lib/eal/common/rte_thread.c  |  6 +--\n lib/eal/include/rte_thread.h |  5 +-\n lib/eal/windows/rte_thread.c | 95 +++++++++++++++++++++++++++---------\n 3 files changed, 76 insertions(+), 30 deletions(-)",
    "diff": "diff --git a/lib/eal/common/rte_thread.c b/lib/eal/common/rte_thread.c\nindex e1a4d7eae4..27ad1c7eb0 100644\n--- a/lib/eal/common/rte_thread.c\n+++ b/lib/eal/common/rte_thread.c\n@@ -47,7 +47,7 @@ rte_thread_attr_init(rte_thread_attr_t *attr)\n \n int\n rte_thread_attr_set_affinity(rte_thread_attr_t *thread_attr,\n-\t\t\t     rte_cpuset_t *cpuset)\n+\t\trte_cpuset_t *cpuset)\n {\n \tRTE_VERIFY(thread_attr != NULL);\n \tRTE_VERIFY(cpuset != NULL);\n@@ -59,7 +59,7 @@ rte_thread_attr_set_affinity(rte_thread_attr_t *thread_attr,\n \n int\n rte_thread_attr_get_affinity(rte_thread_attr_t *thread_attr,\n-\t\t\t     rte_cpuset_t *cpuset)\n+\t\trte_cpuset_t *cpuset)\n {\n \tRTE_VERIFY(thread_attr != NULL);\n \tRTE_VERIFY(cpuset != NULL);\n@@ -71,7 +71,7 @@ rte_thread_attr_get_affinity(rte_thread_attr_t *thread_attr,\n \n int\n rte_thread_attr_set_priority(rte_thread_attr_t *thread_attr,\n-\t\t\t     enum rte_thread_priority priority)\n+\t\tenum rte_thread_priority priority)\n {\n \tRTE_VERIFY(thread_attr != NULL);\n \ndiff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 032ff73b36..bf649c2fe6 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -235,9 +235,8 @@ int rte_thread_value_set(rte_thread_key key, const void *value);\n  *\n  * @return\n  *   On success, value data pointer (can also be NULL).\n- *   On failure, NULL and an error number is set in rte_errno.\n- *   rte_errno can be: EINVAL  - Invalid parameter passed.\n- *                     ENOEXEC - Specific OS error.\n+ *   On failure, NULL and a positive error number is set in rte_errno.\n+ *\n  */\n __rte_experimental\n void *rte_thread_value_get(rte_thread_key key);\ndiff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c\nindex 01966e7745..c1ecfbd6ae 100644\n--- a/lib/eal/windows/rte_thread.c\n+++ b/lib/eal/windows/rte_thread.c\n@@ -13,6 +13,54 @@ struct eal_tls_key {\n \tDWORD thread_index;\n };\n \n+/* Translates the most common error codes related to threads */\n+static int\n+thread_translate_win32_error(DWORD error)\n+{\n+\tswitch (error) {\n+\tcase ERROR_SUCCESS:\n+\t\treturn 0;\n+\n+\tcase ERROR_INVALID_PARAMETER:\n+\t\treturn EINVAL;\n+\n+\tcase ERROR_INVALID_HANDLE:\n+\t\treturn EFAULT;\n+\n+\tcase ERROR_NOT_ENOUGH_MEMORY:\n+\t/* FALLTHROUGH */\n+\tcase ERROR_NO_SYSTEM_RESOURCES:\n+\t\treturn ENOMEM;\n+\n+\tcase ERROR_PRIVILEGE_NOT_HELD:\n+\t/* FALLTHROUGH */\n+\tcase ERROR_ACCESS_DENIED:\n+\t\treturn EACCES;\n+\n+\tcase ERROR_ALREADY_EXISTS:\n+\t\treturn EEXIST;\n+\n+\tcase ERROR_POSSIBLE_DEADLOCK:\n+\t\treturn EDEADLK;\n+\n+\tcase ERROR_INVALID_FUNCTION:\n+\t/* FALLTHROUGH */\n+\tcase ERROR_CALL_NOT_IMPLEMENTED:\n+\t\treturn ENOSYS;\n+\t}\n+\n+\treturn EINVAL;\n+}\n+\n+static int\n+thread_log_last_error(const char *message)\n+{\n+\tDWORD error = GetLastError();\n+\tRTE_LOG(DEBUG, EAL, \"GetLastError()=%lu: %s\\n\", error, message);\n+\n+\treturn thread_translate_win32_error(error);\n+}\n+\n rte_thread_t\n rte_thread_self(void)\n {\n@@ -42,7 +90,7 @@ rte_thread_attr_init(rte_thread_attr_t *attr)\n \n int\n rte_thread_attr_set_affinity(rte_thread_attr_t *thread_attr,\n-\t\t\t     rte_cpuset_t *cpuset)\n+\t\trte_cpuset_t *cpuset)\n {\n \tRTE_VERIFY(thread_attr != NULL);\n \tthread_attr->cpuset = *cpuset;\n@@ -52,7 +100,7 @@ rte_thread_attr_set_affinity(rte_thread_attr_t *thread_attr,\n \n int\n rte_thread_attr_get_affinity(rte_thread_attr_t *thread_attr,\n-\t\t\t     rte_cpuset_t *cpuset)\n+\t\trte_cpuset_t *cpuset)\n {\n \tRTE_VERIFY(thread_attr != NULL);\n \n@@ -63,7 +111,7 @@ rte_thread_attr_get_affinity(rte_thread_attr_t *thread_attr,\n \n int\n rte_thread_attr_set_priority(rte_thread_attr_t *thread_attr,\n-\t\t\t     enum rte_thread_priority priority)\n+\t\tenum rte_thread_priority priority)\n {\n \tRTE_VERIFY(thread_attr != NULL);\n \n@@ -76,18 +124,18 @@ int\n rte_thread_key_create(rte_thread_key *key,\n \t\t__rte_unused void (*destructor)(void *))\n {\n+\tint ret;\n+\n \t*key = malloc(sizeof(**key));\n \tif ((*key) == NULL) {\n \t\tRTE_LOG(DEBUG, EAL, \"Cannot allocate TLS key.\\n\");\n-\t\trte_errno = ENOMEM;\n-\t\treturn -1;\n+\t\treturn ENOMEM;\n \t}\n \t(*key)->thread_index = TlsAlloc();\n \tif ((*key)->thread_index == TLS_OUT_OF_INDEXES) {\n-\t\tRTE_LOG_WIN32_ERR(\"TlsAlloc()\");\n+\t\tret = thread_log_last_error(\"TlsAlloc()\");\n \t\tfree(*key);\n-\t\trte_errno = ENOEXEC;\n-\t\treturn -1;\n+\t\treturn ret;\n \t}\n \treturn 0;\n }\n@@ -95,16 +143,16 @@ rte_thread_key_create(rte_thread_key *key,\n int\n rte_thread_key_delete(rte_thread_key key)\n {\n-\tif (!key) {\n+\tint ret;\n+\n+\tif (key == NULL) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\n-\t\trte_errno = EINVAL;\n-\t\treturn -1;\n+\t\treturn EINVAL;\n \t}\n \tif (!TlsFree(key->thread_index)) {\n-\t\tRTE_LOG_WIN32_ERR(\"TlsFree()\");\n+\t\tret = thread_log_last_error(\"TlsFree()\");\n \t\tfree(key);\n-\t\trte_errno = ENOEXEC;\n-\t\treturn -1;\n+\t\treturn ret;\n \t}\n \tfree(key);\n \treturn 0;\n@@ -115,17 +163,14 @@ rte_thread_value_set(rte_thread_key key, const void *value)\n {\n \tchar *p;\n \n-\tif (!key) {\n+\tif (key == NULL) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\n-\t\trte_errno = EINVAL;\n-\t\treturn -1;\n+\t\treturn EINVAL;\n \t}\n \t/* discard const qualifier */\n \tp = (char *) (uintptr_t) value;\n \tif (!TlsSetValue(key->thread_index, p)) {\n-\t\tRTE_LOG_WIN32_ERR(\"TlsSetValue()\");\n-\t\trte_errno = ENOEXEC;\n-\t\treturn -1;\n+\t\treturn thread_log_last_error(\"TlsSetValue()\");\n \t}\n \treturn 0;\n }\n@@ -134,16 +179,18 @@ void *\n rte_thread_value_get(rte_thread_key key)\n {\n \tvoid *output;\n+\tDWORD ret = 0;\n \n-\tif (!key) {\n+\tif (key == NULL) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \toutput = TlsGetValue(key->thread_index);\n-\tif (GetLastError() != ERROR_SUCCESS) {\n-\t\tRTE_LOG_WIN32_ERR(\"TlsGetValue()\");\n-\t\trte_errno = ENOEXEC;\n+\tret = GetLastError();\n+\tif (ret != 0) {\n+\t\tRTE_LOG(DEBUG, EAL, \"GetLastError()=%lu: TlsGetValue()\\n\", ret);\n+\t\trte_errno = thread_translate_win32_error(ret);\n \t\treturn NULL;\n \t}\n \treturn output;\n",
    "prefixes": [
        "v11",
        "03/10"
    ]
}