Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95602/?format=api
{ "id": 95602, "url": "http://patches.dpdk.org/api/patches/95602/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210709105548.8389-3-richael.zhuang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210709105548.8389-3-richael.zhuang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210709105548.8389-3-richael.zhuang@arm.com", "date": "2021-07-09T10:55:48", "name": "[v8,2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8ea8b753faee3d8ec26c25fa0deb152640360078", "submitter": { "id": 2178, "url": "http://patches.dpdk.org/api/people/2178/?format=api", "name": "Richael Zhuang", "email": "richael.zhuang@arm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210709105548.8389-3-richael.zhuang@arm.com/mbox/", "series": [ { "id": 17738, "url": "http://patches.dpdk.org/api/series/17738/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17738", "date": "2021-07-09T10:55:46", "name": "power: add support for cppc cpufreq driver", "version": 8, "mbox": "http://patches.dpdk.org/series/17738/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95602/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/95602/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 873A0A0A0C;\n\tFri, 9 Jul 2021 12:56:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A74F3416A4;\n\tFri, 9 Jul 2021 12:56:15 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 5C6E5416AC;\n Fri, 9 Jul 2021 12:56:14 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C0CC6ED1;\n Fri, 9 Jul 2021 03:56:13 -0700 (PDT)", "from wls-arm-cavium06.shanghai.arm.com\n (wls-arm-cavium06.shanghai.arm.com [10.169.206.120])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED6653F5A1;\n Fri, 9 Jul 2021 03:56:11 -0700 (PDT)" ], "From": "Richael Zhuang <richael.zhuang@arm.com>", "To": "dev@dpdk.org", "Cc": "yux.jiang@intel.com, richael.zhuang@arm.com, stable@dpdk.org,\n David Hunt <david.hunt@intel.com>", "Date": "Fri, 9 Jul 2021 18:55:48 +0800", "Message-Id": "<20210709105548.8389-3-richael.zhuang@arm.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210709105548.8389-1-richael.zhuang@arm.com>", "References": "<20210709033416.46199-2-richael.zhuang@arm.com>\n <20210709105548.8389-1-richael.zhuang@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 2/2] test/power: round cpuinfo cur freq only\n in CPPC cpufreq", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On arm platform, the value in \"/sys/.../cpuinfo_cur_freq\" may not\nbe exactly the same as what was set when using CPPC cpufreq driver.\nFor other cpufreq driver, no need to round it currently, or else\nthis check will fail with turbo enabled. For example, with acpi_cpufreq,\ncpuinfo_cur_freq can be 2401000 which is equal to freqs[0].It should\nnot be rounded to 2400000.\n\nFixes: 606a234c6d360 (\"test/power: round CPU frequency to check\")\nCc: richael.zhuang@arm.com\nCc: stable@dpdk.org\n\nSigned-off-by: Richael Zhuang <richael.zhuang@arm.com>\nAcked-by: David Hunt <david.hunt@intel.com>\n---\n app/test/test_power_cpufreq.c | 23 ++++++++++++++---------\n 1 file changed, 14 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c\nindex 8516df4ca6..b8fc53925c 100644\n--- a/app/test/test_power_cpufreq.c\n+++ b/app/test/test_power_cpufreq.c\n@@ -55,7 +55,9 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)\n \tFILE *f;\n \tchar fullpath[PATH_MAX];\n \tchar buf[BUFSIZ];\n+\tenum power_management_env env;\n \tuint32_t cur_freq;\n+\tuint32_t freq_conv;\n \tint ret = -1;\n \tint i;\n \n@@ -80,15 +82,18 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)\n \t\t\tgoto fail_all;\n \n \t\tcur_freq = strtoul(buf, NULL, TEST_POWER_CONVERT_TO_DECIMAL);\n-\n-\t\t/* convert the frequency to nearest 100000 value\n-\t\t * Ex: if cur_freq=1396789 then freq_conv=1400000\n-\t\t * Ex: if cur_freq=800030 then freq_conv=800000\n-\t\t */\n-\t\tunsigned int freq_conv = 0;\n-\t\tfreq_conv = (cur_freq + TEST_FREQ_ROUNDING_DELTA)\n-\t\t\t\t\t/ TEST_ROUND_FREQ_TO_N_100000;\n-\t\tfreq_conv = freq_conv * TEST_ROUND_FREQ_TO_N_100000;\n+\t\tfreq_conv = cur_freq;\n+\n+\t\tenv = rte_power_get_env();\n+\t\tif (env == PM_ENV_CPPC_CPUFREQ) {\n+\t\t\t/* convert the frequency to nearest 100000 value\n+\t\t\t * Ex: if cur_freq=1396789 then freq_conv=1400000\n+\t\t\t * Ex: if cur_freq=800030 then freq_conv=800000\n+\t\t\t */\n+\t\t\tfreq_conv = (cur_freq + TEST_FREQ_ROUNDING_DELTA)\n+\t\t\t\t\t\t/ TEST_ROUND_FREQ_TO_N_100000;\n+\t\t\tfreq_conv = freq_conv * TEST_ROUND_FREQ_TO_N_100000;\n+\t\t}\n \n \t\tif (turbo)\n \t\t\tret = (freqs[idx] <= freq_conv ? 0 : -1);\n", "prefixes": [ "v8", "2/2" ] }