Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 93919,
    "url": "http://patches.dpdk.org/api/patches/93919/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1622849908-5710-8-git-send-email-navasile@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1622849908-5710-8-git-send-email-navasile@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1622849908-5710-8-git-send-email-navasile@linux.microsoft.com",
    "date": "2021-06-04T23:38:25",
    "name": "[v8,07/10] eal: implement functions for mutex management",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "dae16ea0689c23b9f26a5b6c5f2773b4872ed04b",
    "submitter": {
        "id": 1668,
        "url": "http://patches.dpdk.org/api/people/1668/?format=api",
        "name": "Narcisa Ana Maria Vasile",
        "email": "navasile@linux.microsoft.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1622849908-5710-8-git-send-email-navasile@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 17240,
            "url": "http://patches.dpdk.org/api/series/17240/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17240",
            "date": "2021-06-04T23:38:18",
            "name": "eal: Add EAL API for threading",
            "version": 8,
            "mbox": "http://patches.dpdk.org/series/17240/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/93919/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/93919/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EFA89A0A0F;\n\tSat,  5 Jun 2021 01:39:23 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 50B2141120;\n\tSat,  5 Jun 2021 01:39:03 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 176A1410FE\n for <dev@dpdk.org>; Sat,  5 Jun 2021 01:38:58 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1059)\n id 7A06720B800D; Fri,  4 Jun 2021 16:38:57 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 7A06720B800D",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1622849937;\n bh=seQWra0TuyII/9wCkbzoTnOUUvIjtpUMbtuWx/mtsyk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=evG1kDIS/AZzJJm9Lw7qweuz9CfWnKVs5POmr0V39zhjJQHBVWJyBu+TQfhHwSZaV\n EFBG0RUgHWeYRapmw0w9Z+VN+49z4Dh7YxXgQHn5uwbQe2qY1efnp5ttDtA2nILg9O\n UxOml+lKUb9a7nfTplfpoqVQ4OB5KX56lB9uVmgs=",
        "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>",
        "To": "dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com,\n khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com,\n roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com",
        "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n pallavi.kadam@intel.com",
        "Date": "Fri,  4 Jun 2021 16:38:25 -0700",
        "Message-Id": "<1622849908-5710-8-git-send-email-navasile@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1622849908-5710-1-git-send-email-navasile@linux.microsoft.com>",
        "References": "<1622580952-25169-1-git-send-email-navasile@linux.microsoft.com>\n <1622849908-5710-1-git-send-email-navasile@linux.microsoft.com>",
        "Subject": "[dpdk-dev] [PATCH v8 07/10] eal: implement functions for mutex\n management",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Narcisa Vasile <navasile@microsoft.com>\n\nAdd functions for mutex init, destroy, lock, unlock.\n\nOn Linux, static initialization of a mutex is possible\nthrough PTHREAD_MUTEX_INITIALIZER.\n\nWindows does not have a static initializer.\nInitialization is only done through InitializeCriticalSection().\n\nTo simulate static initialization, a fake initializator has been added:\nThe rte_mutex_lock() function will verify if the mutex has been initialized\nusing this fake initializer and if so, it will perform additional\ninitialization.\n---\n lib/eal/common/rte_thread.c                   | 24 ++++++\n lib/eal/include/rte_thread.h                  | 53 ++++++++++++\n lib/eal/include/rte_thread_types.h            |  4 +\n .../include/rte_windows_thread_types.h        |  9 ++\n lib/eal/windows/rte_thread.c                  | 83 ++++++++++++++++++-\n 5 files changed, 172 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/eal/common/rte_thread.c b/lib/eal/common/rte_thread.c\nindex 84050d0f4c..4d7d9242a9 100644\n--- a/lib/eal/common/rte_thread.c\n+++ b/lib/eal/common/rte_thread.c\n@@ -249,6 +249,30 @@ rte_thread_join(rte_thread_t thread_id, int *value_ptr)\n \treturn 0;\n }\n \n+int\n+rte_thread_mutex_init(rte_thread_mutex_t *mutex)\n+{\n+\treturn pthread_mutex_init(mutex, NULL);\n+}\n+\n+int\n+rte_thread_mutex_lock(rte_thread_mutex_t *mutex)\n+{\n+\treturn pthread_mutex_lock(mutex);\n+}\n+\n+int\n+rte_thread_mutex_unlock(rte_thread_mutex_t *mutex)\n+{\n+\treturn pthread_mutex_unlock(mutex);\n+}\n+\n+int\n+rte_thread_mutex_destroy(rte_thread_mutex_t *mutex)\n+{\n+\treturn pthread_mutex_destroy(mutex);\n+}\n+\n int rte_thread_cancel(rte_thread_t thread_id)\n {\n \t/*\ndiff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 1d481b9ad5..db8ef20930 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -248,6 +248,58 @@ int rte_thread_create(rte_thread_t *thread_id,\n __rte_experimental\n int rte_thread_join(rte_thread_t thread_id, int *value_ptr);\n \n+/**\n+ * Initializes a mutex.\n+ *\n+ * @param mutex\n+ *    The mutex to be initialized.\n+ *\n+ * @return\n+ *   On success, return 0.\n+ *   On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_mutex_init(rte_thread_mutex_t *mutex);\n+\n+/**\n+ * Locks a mutex.\n+ *\n+ * @param mutex\n+ *    The mutex to be locked.\n+ *\n+ * @return\n+ *   On success, return 0.\n+ *   On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_mutex_lock(rte_thread_mutex_t *mutex);\n+\n+/**\n+ * Unlocks a mutex.\n+ *\n+ * @param mutex\n+ *    The mutex to be unlocked.\n+ *\n+ * @return\n+ *   On success, return 0.\n+ *   On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_mutex_unlock(rte_thread_mutex_t *mutex);\n+\n+/**\n+ * Releases all resources associated with a mutex.\n+ *\n+ * @param mutex\n+ *    The mutex to be uninitialized.\n+ *\n+ * @return\n+ *   On success, return 0.\n+ *   On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_mutex_destroy(rte_thread_mutex_t *mutex);\n+\n /**\n  * Terminates a thread.\n  *\n@@ -283,6 +335,7 @@ int rte_thread_detach(rte_thread_t thread_id);\n  *\n  * @param cpusetp\n  *   Pointer to CPU affinity to set.\n+ *\n  * @return\n  *   On success, return 0; otherwise return -1;\n  */\ndiff --git a/lib/eal/include/rte_thread_types.h b/lib/eal/include/rte_thread_types.h\nindex d67b24a563..7bb0d2948c 100644\n--- a/lib/eal/include/rte_thread_types.h\n+++ b/lib/eal/include/rte_thread_types.h\n@@ -7,4 +7,8 @@\n \n #include <pthread.h>\n \n+#define RTE_THREAD_MUTEX_INITIALIZER     PTHREAD_MUTEX_INITIALIZER\n+\n+typedef pthread_mutex_t                 rte_thread_mutex_t;\n+\n #endif /* _RTE_THREAD_TYPES_H_ */\ndiff --git a/lib/eal/windows/include/rte_windows_thread_types.h b/lib/eal/windows/include/rte_windows_thread_types.h\nindex 60e6d94553..c6c8502bfb 100644\n--- a/lib/eal/windows/include/rte_windows_thread_types.h\n+++ b/lib/eal/windows/include/rte_windows_thread_types.h\n@@ -7,4 +7,13 @@\n \n #include <rte_windows.h>\n \n+#define WINDOWS_MUTEX_INITIALIZER               (void*)-1\n+#define RTE_THREAD_MUTEX_INITIALIZER            {WINDOWS_MUTEX_INITIALIZER}\n+\n+struct thread_mutex_t {\n+\tvoid* mutex_id;\n+};\n+\n+typedef struct thread_mutex_t rte_thread_mutex_t;\n+\n #endif /* _RTE_THREAD_TYPES_H_ */\ndiff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c\nindex 5afdd54e15..239aa6be5d 100644\n--- a/lib/eal/windows/rte_thread.c\n+++ b/lib/eal/windows/rte_thread.c\n@@ -470,6 +470,88 @@ rte_thread_join(rte_thread_t thread_id, int *value_ptr)\n \treturn ret;\n }\n \n+int\n+rte_thread_mutex_init(rte_thread_mutex_t *mutex)\n+{\n+\tint ret = 0;\n+\tCRITICAL_SECTION *m = NULL;\n+\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tm = calloc(1, sizeof(*m));\n+\tif (m == NULL) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Unable to initialize mutex. Insufficient memory!\\n\");\n+\t\tret = ENOMEM;\n+\t\tgoto cleanup;\n+\t}\n+\n+\tInitializeCriticalSection(m);\n+\tmutex->mutex_id = m;\n+\tm = NULL;\n+\n+cleanup:\n+\treturn ret;\n+}\n+\n+int\n+rte_thread_mutex_lock(rte_thread_mutex_t *mutex)\n+{\n+\tint ret = 0;\n+\tvoid* id = 0;\n+\trte_thread_mutex_t m;\n+\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\t/* Check if mutex has been statically initialized */\n+\tid = InterlockedCompareExchangePointer(&mutex->mutex_id, mutex->mutex_id, WINDOWS_MUTEX_INITIALIZER);\n+\t/* If mutex has been statically initialized */\n+\tif (id == WINDOWS_MUTEX_INITIALIZER) {\n+\t\tret = rte_thread_mutex_init(&m);\n+\t\tif (ret != 0) {\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\tid = InterlockedCompareExchangePointer(&mutex->mutex_id, m.mutex_id, WINDOWS_MUTEX_INITIALIZER);\n+\t\t/* If meanwhile the mutex was initialized by a different thread,\n+\t\t * destroy the local initialization.\n+\t\t */\n+\t\tif (id != WINDOWS_MUTEX_INITIALIZER) {\n+\t\t\trte_thread_mutex_destroy(&m);\n+\t\t}\n+\t}\n+\n+\tEnterCriticalSection(mutex->mutex_id);\n+\n+\treturn 0;\n+}\n+\n+int\n+rte_thread_mutex_unlock(rte_thread_mutex_t *mutex)\n+{\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tLeaveCriticalSection(mutex->mutex_id);\n+\treturn 0;\n+}\n+\n+int\n+rte_thread_mutex_destroy(rte_thread_mutex_t *mutex)\n+{\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tif (mutex->mutex_id == WINDOWS_MUTEX_INITIALIZER) {\n+\t\tgoto cleanup;\n+\t}\n+\n+\tDeleteCriticalSection(mutex->mutex_id);\n+\tfree(mutex->mutex_id);\n+\n+cleanup:\n+\tmutex->mutex_id = NULL;\n+\n+\treturn 0;\n+}\n+\n int\n rte_thread_cancel(rte_thread_t thread_id)\n {\n@@ -549,7 +631,6 @@ rte_thread_key_delete(rte_thread_key key)\n int\n rte_thread_value_set(rte_thread_key key, const void *value)\n {\n-\tint ret;\n \tchar *p;\n \n \tif (key == NULL) {\n",
    "prefixes": [
        "v8",
        "07/10"
    ]
}