Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 93786,
    "url": "http://patches.dpdk.org/api/patches/93786/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210602094108.1575640-25-jiawenwu@trustnetic.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210602094108.1575640-25-jiawenwu@trustnetic.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210602094108.1575640-25-jiawenwu@trustnetic.com",
    "date": "2021-06-02T09:41:08",
    "name": "[v5,24/24] net/ngbe: add device stop operation",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "e74b6678143c089a229aec11774d106a37429f51",
    "submitter": {
        "id": 1932,
        "url": "http://patches.dpdk.org/api/people/1932/?format=api",
        "name": "Jiawen Wu",
        "email": "jiawenwu@trustnetic.com"
    },
    "delegate": {
        "id": 3961,
        "url": "http://patches.dpdk.org/api/users/3961/?format=api",
        "username": "arybchenko",
        "first_name": "Andrew",
        "last_name": "Rybchenko",
        "email": "andrew.rybchenko@oktetlabs.ru"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210602094108.1575640-25-jiawenwu@trustnetic.com/mbox/",
    "series": [
        {
            "id": 17206,
            "url": "http://patches.dpdk.org/api/series/17206/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17206",
            "date": "2021-06-02T09:40:44",
            "name": "net: ngbe PMD",
            "version": 5,
            "mbox": "http://patches.dpdk.org/series/17206/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/93786/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/93786/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7D81DA0524;\n\tWed,  2 Jun 2021 11:42:38 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EBD6A411AC;\n\tWed,  2 Jun 2021 11:40:14 +0200 (CEST)",
            "from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56])\n by mails.dpdk.org (Postfix) with ESMTP id BF146411A5\n for <dev@dpdk.org>; Wed,  2 Jun 2021 11:40:12 +0200 (CEST)",
            "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Wed, 02 Jun 2021 17:40:07 +0800 (CST)"
        ],
        "X-QQ-mid": "bizesmtp32t1622626807t4hquvcm",
        "X-QQ-SSF": "01400000000000D0E000B00A0000000",
        "X-QQ-FEAT": "CBgi6aaeY4fybGPRZ6bVBtL+Mh+6FDjrm1/sBfkGlHOL4DZDX3LAPIZI41sxs\n WwcM0RguuBrRO2b+2iXU/lwCtcqdBYA0Ab3VrMrq8fDc10sWAdboIo99Z5SFksikk4b61G/\n iF1vGv5+DJPGLXUqj8O5/WQAeEcS39GT+LjGnbG9ahk95XirFlz6R+CQ7euGsRPwufkRBZa\n 23yV/FEHHsvEboMJtW/M05ppyAeHtr7flC37YGb9ZiPp/5NTf+fuBn+8d9UPZpS4AOTtoP6\n pGKMC/vmLAtNDxPtN3BAtS1oaw8LstnvYYEN7Mb+vWtmZuCzu1gjfW+9ygNtqFUvCQkqQZI\n l1lFxx561PAqNklKHgetxzP9iZLkQNL3FXtATQ8",
        "X-QQ-GoodBg": "2",
        "From": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "To": "dev@dpdk.org",
        "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "Date": "Wed,  2 Jun 2021 17:41:08 +0800",
        "Message-Id": "<20210602094108.1575640-25-jiawenwu@trustnetic.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "In-Reply-To": "<20210602094108.1575640-1-jiawenwu@trustnetic.com>",
        "References": "<20210602094108.1575640-1-jiawenwu@trustnetic.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-QQ-SENDSIZE": "520",
        "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6",
        "X-QQ-Bgrelay": "1",
        "Subject": "[dpdk-dev] [PATCH v5 24/24] net/ngbe: add device stop operation",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Support to stop, close and reset device.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/ngbe/ngbe_ethdev.c | 123 ++++++++++++++++++++++++++++++++-\n drivers/net/ngbe/ngbe_ethdev.h |   7 ++\n drivers/net/ngbe/ngbe_rxtx.c   |  47 +++++++++++++\n 3 files changed, 175 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex 2b551c00c7..d6ea621b86 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -531,20 +531,136 @@ ngbe_dev_start(struct rte_eth_dev *dev)\n \n error:\n \tPMD_INIT_LOG(ERR, \"failure in dev start: %d\", err);\n+\tngbe_dev_clear_queues(dev);\n \treturn -EIO;\n }\n \n+/*\n+ * Stop device: disable rx and tx functions to allow for reconfiguring.\n+ */\n+static int\n+ngbe_dev_stop(struct rte_eth_dev *dev)\n+{\n+\tstruct rte_eth_link link;\n+\tstruct ngbe_hw *hw = NGBE_DEV_HW(dev);\n+\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n+\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n+\n+\tif (hw->adapter_stopped)\n+\t\treturn 0;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tif ((hw->sub_system_id & NGBE_OEM_MASK) == NGBE_LY_M88E1512_SFP ||\n+\t\t(hw->sub_system_id & NGBE_OEM_MASK) == NGBE_LY_YT8521S_SFP) {\n+\t\t/* gpio0 is used to power on/off control*/\n+\t\twr32(hw, NGBE_GPIODATA, NGBE_GPIOBIT_0);\n+\t}\n+\n+\t/* disable interrupts */\n+\tngbe_disable_intr(hw);\n+\n+\t/* reset the NIC */\n+\tngbe_pf_reset_hw(hw);\n+\thw->adapter_stopped = 0;\n+\n+\t/* stop adapter */\n+\tngbe_stop_hw(hw);\n+\n+\tngbe_dev_clear_queues(dev);\n+\n+\t/* Clear stored conf */\n+\tdev->data->scattered_rx = 0;\n+\n+\t/* Clear recorded link status */\n+\tmemset(&link, 0, sizeof(link));\n+\trte_eth_linkstatus_set(dev, &link);\n+\n+\tif (!rte_intr_allow_others(intr_handle))\n+\t\t/* resume to the default handler */\n+\t\trte_intr_callback_register(intr_handle,\n+\t\t\t\t\t   ngbe_dev_interrupt_handler,\n+\t\t\t\t\t   (void *)dev);\n+\n+\t/* Clean datapath event and queue/vec mapping */\n+\trte_intr_efd_disable(intr_handle);\n+\tif (intr_handle->intr_vec != NULL) {\n+\t\trte_free(intr_handle->intr_vec);\n+\t\tintr_handle->intr_vec = NULL;\n+\t}\n+\n+\thw->adapter_stopped = true;\n+\tdev->data->dev_started = 0;\n+\n+\treturn 0;\n+}\n+\n /*\n  * Reset and stop device.\n  */\n static int\n ngbe_dev_close(struct rte_eth_dev *dev)\n {\n+\tstruct ngbe_hw *hw = NGBE_DEV_HW(dev);\n+\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n+\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n+\tint retries = 0;\n+\tint ret;\n+\n \tPMD_INIT_FUNC_TRACE();\n \n-\tRTE_SET_USED(dev);\n+\tngbe_pf_reset_hw(hw);\n \n-\treturn 0;\n+\tret = ngbe_dev_stop(dev);\n+\n+\tngbe_dev_free_queues(dev);\n+\n+\t/* reprogram the RAR[0] in case user changed it. */\n+\tngbe_set_rar(hw, 0, hw->mac.addr, 0, true);\n+\n+\t/* Unlock any pending hardware semaphore */\n+\tngbe_swfw_lock_reset(hw);\n+\n+\t/* disable uio intr before callback unregister */\n+\trte_intr_disable(intr_handle);\n+\n+\tdo {\n+\t\tret = rte_intr_callback_unregister(intr_handle,\n+\t\t\t\tngbe_dev_interrupt_handler, dev);\n+\t\tif (ret >= 0 || ret == -ENOENT) {\n+\t\t\tbreak;\n+\t\t} else if (ret != -EAGAIN) {\n+\t\t\tPMD_INIT_LOG(ERR,\n+\t\t\t\t\"intr callback unregister failed: %d\",\n+\t\t\t\tret);\n+\t\t}\n+\t\trte_delay_ms(100);\n+\t} while (retries++ < (10 + NGBE_LINK_UP_TIME));\n+\n+\trte_free(dev->data->mac_addrs);\n+\tdev->data->mac_addrs = NULL;\n+\n+\trte_free(dev->data->hash_mac_addrs);\n+\tdev->data->hash_mac_addrs = NULL;\n+\n+\treturn ret;\n+}\n+\n+/*\n+ * Reset PF device.\n+ */\n+static int\n+ngbe_dev_reset(struct rte_eth_dev *dev)\n+{\n+\tint ret;\n+\n+\tret = eth_ngbe_dev_uninit(dev);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = eth_ngbe_dev_init(dev, NULL);\n+\n+\treturn ret;\n }\n \n static int\n@@ -1120,6 +1236,9 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = {\n \t.dev_configure              = ngbe_dev_configure,\n \t.dev_infos_get              = ngbe_dev_info_get,\n \t.dev_start                  = ngbe_dev_start,\n+\t.dev_stop                   = ngbe_dev_stop,\n+\t.dev_close                  = ngbe_dev_close,\n+\t.dev_reset                  = ngbe_dev_reset,\n \t.link_update                = ngbe_dev_link_update,\n \t.dev_supported_ptypes_get   = ngbe_dev_supported_ptypes_get,\n \t.rx_queue_start\t            = ngbe_dev_rx_queue_start,\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.h b/drivers/net/ngbe/ngbe_ethdev.h\nindex 97ced40e4b..7ca3ebbda3 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.h\n+++ b/drivers/net/ngbe/ngbe_ethdev.h\n@@ -61,6 +61,13 @@ struct ngbe_adapter {\n #define NGBE_DEV_INTR(dev) \\\n \t(&((struct ngbe_adapter *)(dev)->data->dev_private)->intr)\n \n+/*\n+ * RX/TX function prototypes\n+ */\n+void ngbe_dev_clear_queues(struct rte_eth_dev *dev);\n+\n+void ngbe_dev_free_queues(struct rte_eth_dev *dev);\n+\n void ngbe_dev_rx_queue_release(void *rxq);\n \n void ngbe_dev_tx_queue_release(void *txq);\ndiff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c\nindex daa2d7ae4d..a76b9d50a1 100644\n--- a/drivers/net/ngbe/ngbe_rxtx.c\n+++ b/drivers/net/ngbe/ngbe_rxtx.c\n@@ -2236,6 +2236,53 @@ ngbe_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+void __rte_cold\n+ngbe_dev_clear_queues(struct rte_eth_dev *dev)\n+{\n+\tunsigned int i;\n+\tstruct ngbe_adapter *adapter = NGBE_DEV_ADAPTER(dev);\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct ngbe_tx_queue *txq = dev->data->tx_queues[i];\n+\n+\t\tif (txq != NULL) {\n+\t\t\ttxq->ops->release_mbufs(txq);\n+\t\t\ttxq->ops->reset(txq);\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct ngbe_rx_queue *rxq = dev->data->rx_queues[i];\n+\n+\t\tif (rxq != NULL) {\n+\t\t\tngbe_rx_queue_release_mbufs(rxq);\n+\t\t\tngbe_reset_rx_queue(adapter, rxq);\n+\t\t}\n+\t}\n+}\n+\n+void\n+ngbe_dev_free_queues(struct rte_eth_dev *dev)\n+{\n+\tunsigned int i;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tngbe_dev_rx_queue_release(dev->data->rx_queues[i]);\n+\t\tdev->data->rx_queues[i] = NULL;\n+\t}\n+\tdev->data->nb_rx_queues = 0;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tngbe_dev_tx_queue_release(dev->data->tx_queues[i]);\n+\t\tdev->data->tx_queues[i] = NULL;\n+\t}\n+\tdev->data->nb_tx_queues = 0;\n+}\n+\n static int __rte_cold\n ngbe_alloc_rx_queue_mbufs(struct ngbe_rx_queue *rxq)\n {\n",
    "prefixes": [
        "v5",
        "24/24"
    ]
}