Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93628/?format=api
{ "id": 93628, "url": "http://patches.dpdk.org/api/patches/93628/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210531141027.13289-6-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210531141027.13289-6-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210531141027.13289-6-arkadiuszx.kusztal@intel.com", "date": "2021-05-31T14:10:17", "name": "[05/15] crypto/qat: rename content descriptor functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bbd7e1d47ce14f349cfad0aa6e31d54ea7060983", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210531141027.13289-6-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 17172, "url": "http://patches.dpdk.org/api/series/17172/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17172", "date": "2021-05-31T14:10:12", "name": "Add support for fourth generation of Intel QuickAssist Technology devices", "version": 1, "mbox": "http://patches.dpdk.org/series/17172/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93628/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93628/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E15EEA0524;\n\tMon, 31 May 2021 16:11:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9241A410FB;\n\tMon, 31 May 2021 16:10:54 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 7457B410F7\n for <dev@dpdk.org>; Mon, 31 May 2021 16:10:53 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 May 2021 07:10:53 -0700", "from silpixa00400308.ir.intel.com ([10.237.214.61])\n by orsmga004.jf.intel.com with ESMTP; 31 May 2021 07:10:51 -0700" ], "IronPort-SDR": [ "\n UZpgtGCiQnt4E82XALoXPKHo8TnkjjuwpP8ONYiND+2a3aUWY3G2/+i3sqvdQYHKKFbdvd3Kqd\n dSl7FY1h7U4w==", "\n 0BGR6oylVweTY6dZcX6mzONHK3k84adikU8Ev4Oc4Z3R2OqSeqhGJmE4Xzwxx/UAEeTh6yN9LY\n oKHZ2Oz2OgrA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10001\"; a=\"201492222\"", "E=Sophos;i=\"5.83,237,1616482800\"; d=\"scan'208\";a=\"201492222\"", "E=Sophos;i=\"5.83,237,1616482800\"; d=\"scan'208\";a=\"548760105\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, fiona.trahe@intel.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Date": "Mon, 31 May 2021 15:10:17 +0100", "Message-Id": "<20210531141027.13289-6-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210531141027.13289-1-arkadiuszx.kusztal@intel.com>", "References": "<20210531141027.13289-1-arkadiuszx.kusztal@intel.com>", "Subject": "[dpdk-dev] [PATCH 05/15] crypto/qat: rename content descriptor\n functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Content descriptor functions are incorrectly named,\nhaving them with proper name will improve readability and\nfacilitate further work.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n drivers/crypto/qat/qat_sym_session.c | 39 ++++++++++++++++++----------\n drivers/crypto/qat/qat_sym_session.h | 13 ----------\n 2 files changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c\nindex 2c44b1f1aa..56c85e8435 100644\n--- a/drivers/crypto/qat/qat_sym_session.c\n+++ b/drivers/crypto/qat/qat_sym_session.c\n@@ -57,6 +57,19 @@ static const uint8_t sha512InitialState[] = {\n \t0x2b, 0x3e, 0x6c, 0x1f, 0x1f, 0x83, 0xd9, 0xab, 0xfb, 0x41, 0xbd,\n \t0x6b, 0x5b, 0xe0, 0xcd, 0x19, 0x13, 0x7e, 0x21, 0x79};\n \n+static int\n+qat_sym_cd_cipher_set(struct qat_sym_session *cd,\n+\t\t\t\t\t\tconst uint8_t *enckey,\n+\t\t\t\t\t\tuint32_t enckeylen);\n+\n+static int\n+qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n+\t\t\t\t\t\tconst uint8_t *authkey,\n+\t\t\t\t\t\tuint32_t authkeylen,\n+\t\t\t\t\t\tuint32_t aad_length,\n+\t\t\t\t\t\tuint32_t digestsize,\n+\t\t\t\t\t\tunsigned int operation);\n+\n /** Frees a context previously created\n * Depends on openssl libcrypto\n */\n@@ -420,7 +433,7 @@ qat_sym_session_configure_cipher(struct rte_cryptodev *dev,\n \telse\n \t\tsession->qat_dir = ICP_QAT_HW_CIPHER_DECRYPT;\n \n-\tif (qat_sym_session_aead_create_cd_cipher(session,\n+\tif (qat_sym_cd_cipher_set(session,\n \t\t\t\t\t\tcipher_xform->key.data,\n \t\t\t\t\t\tcipher_xform->key.length)) {\n \t\tret = -EINVAL;\n@@ -669,7 +682,7 @@ qat_sym_session_handle_single_pass(struct qat_sym_session *session,\n \t}\n \tsession->cipher_iv.offset = aead_xform->iv.offset;\n \tsession->cipher_iv.length = aead_xform->iv.length;\n-\tif (qat_sym_session_aead_create_cd_cipher(session,\n+\tif (qat_sym_cd_cipher_set(session,\n \t\t\taead_xform->key.data, aead_xform->key.length))\n \t\treturn -EINVAL;\n \tsession->aad_len = aead_xform->aad_length;\n@@ -825,12 +838,12 @@ qat_sym_session_configure_auth(struct rte_cryptodev *dev,\n \t\t\t * then authentication\n \t\t\t */\n \n-\t\t\tif (qat_sym_session_aead_create_cd_cipher(session,\n+\t\t\tif (qat_sym_cd_cipher_set(session,\n \t\t\t\t\t\tauth_xform->key.data,\n \t\t\t\t\t\tauth_xform->key.length))\n \t\t\t\treturn -EINVAL;\n \n-\t\t\tif (qat_sym_session_aead_create_cd_auth(session,\n+\t\t\tif (qat_sym_cd_auth_set(session,\n \t\t\t\t\t\tkey_data,\n \t\t\t\t\t\tkey_length,\n \t\t\t\t\t\t0,\n@@ -845,7 +858,7 @@ qat_sym_session_configure_auth(struct rte_cryptodev *dev,\n \t\t\t * then cipher\n \t\t\t */\n \n-\t\t\tif (qat_sym_session_aead_create_cd_auth(session,\n+\t\t\tif (qat_sym_cd_auth_set(session,\n \t\t\t\t\tkey_data,\n \t\t\t\t\tkey_length,\n \t\t\t\t\t0,\n@@ -853,7 +866,7 @@ qat_sym_session_configure_auth(struct rte_cryptodev *dev,\n \t\t\t\t\tauth_xform->op))\n \t\t\t\treturn -EINVAL;\n \n-\t\t\tif (qat_sym_session_aead_create_cd_cipher(session,\n+\t\t\tif (qat_sym_cd_cipher_set(session,\n \t\t\t\t\t\tauth_xform->key.data,\n \t\t\t\t\t\tauth_xform->key.length))\n \t\t\t\treturn -EINVAL;\n@@ -861,7 +874,7 @@ qat_sym_session_configure_auth(struct rte_cryptodev *dev,\n \t\t/* Restore to authentication only only */\n \t\tsession->qat_cmd = ICP_QAT_FW_LA_CMD_AUTH;\n \t} else {\n-\t\tif (qat_sym_session_aead_create_cd_auth(session,\n+\t\tif (qat_sym_cd_auth_set(session,\n \t\t\t\tkey_data,\n \t\t\t\tkey_length,\n \t\t\t\t0,\n@@ -948,12 +961,12 @@ qat_sym_session_configure_aead(struct rte_cryptodev *dev,\n \t\tcrypto_operation = aead_xform->algo == RTE_CRYPTO_AEAD_AES_GCM ?\n \t\t\tRTE_CRYPTO_AUTH_OP_GENERATE : RTE_CRYPTO_AUTH_OP_VERIFY;\n \n-\t\tif (qat_sym_session_aead_create_cd_cipher(session,\n+\t\tif (qat_sym_cd_cipher_set(session,\n \t\t\t\t\taead_xform->key.data,\n \t\t\t\t\taead_xform->key.length))\n \t\t\treturn -EINVAL;\n \n-\t\tif (qat_sym_session_aead_create_cd_auth(session,\n+\t\tif (qat_sym_cd_auth_set(session,\n \t\t\t\t\taead_xform->key.data,\n \t\t\t\t\taead_xform->key.length,\n \t\t\t\t\taead_xform->aad_length,\n@@ -970,7 +983,7 @@ qat_sym_session_configure_aead(struct rte_cryptodev *dev,\n \t\tcrypto_operation = aead_xform->algo == RTE_CRYPTO_AEAD_AES_GCM ?\n \t\t\tRTE_CRYPTO_AUTH_OP_VERIFY : RTE_CRYPTO_AUTH_OP_GENERATE;\n \n-\t\tif (qat_sym_session_aead_create_cd_auth(session,\n+\t\tif (qat_sym_cd_auth_set(session,\n \t\t\t\t\taead_xform->key.data,\n \t\t\t\t\taead_xform->key.length,\n \t\t\t\t\taead_xform->aad_length,\n@@ -978,7 +991,7 @@ qat_sym_session_configure_aead(struct rte_cryptodev *dev,\n \t\t\t\t\tcrypto_operation))\n \t\t\treturn -EINVAL;\n \n-\t\tif (qat_sym_session_aead_create_cd_cipher(session,\n+\t\tif (qat_sym_cd_cipher_set(session,\n \t\t\t\t\taead_xform->key.data,\n \t\t\t\t\taead_xform->key.length))\n \t\t\treturn -EINVAL;\n@@ -1523,7 +1536,7 @@ qat_get_crypto_proto_flag(uint16_t flags)\n \treturn qat_proto_flag;\n }\n \n-int qat_sym_session_aead_create_cd_cipher(struct qat_sym_session *cdesc,\n+int qat_sym_cd_cipher_set(struct qat_sym_session *cdesc,\n \t\t\t\t\t\tconst uint8_t *cipherkey,\n \t\t\t\t\t\tuint32_t cipherkeylen)\n {\n@@ -1693,7 +1706,7 @@ int qat_sym_session_aead_create_cd_cipher(struct qat_sym_session *cdesc,\n \treturn 0;\n }\n \n-int qat_sym_session_aead_create_cd_auth(struct qat_sym_session *cdesc,\n+int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,\n \t\t\t\t\t\tconst uint8_t *authkey,\n \t\t\t\t\t\tuint32_t authkeylen,\n \t\t\t\t\t\tuint32_t aad_length,\ndiff --git a/drivers/crypto/qat/qat_sym_session.h b/drivers/crypto/qat/qat_sym_session.h\nindex 4450df6911..5d28e5a089 100644\n--- a/drivers/crypto/qat/qat_sym_session.h\n+++ b/drivers/crypto/qat/qat_sym_session.h\n@@ -120,19 +120,6 @@ qat_sym_session_configure_auth(struct rte_cryptodev *dev,\n \t\t\t\tstruct rte_crypto_sym_xform *xform,\n \t\t\t\tstruct qat_sym_session *session);\n \n-int\n-qat_sym_session_aead_create_cd_cipher(struct qat_sym_session *cd,\n-\t\t\t\t\t\tconst uint8_t *enckey,\n-\t\t\t\t\t\tuint32_t enckeylen);\n-\n-int\n-qat_sym_session_aead_create_cd_auth(struct qat_sym_session *cdesc,\n-\t\t\t\t\t\tconst uint8_t *authkey,\n-\t\t\t\t\t\tuint32_t authkeylen,\n-\t\t\t\t\t\tuint32_t aad_length,\n-\t\t\t\t\t\tuint32_t digestsize,\n-\t\t\t\t\t\tunsigned int operation);\n-\n void\n qat_sym_session_clear(struct rte_cryptodev *dev,\n \t\tstruct rte_cryptodev_sym_session *session);\n", "prefixes": [ "05/15" ] }