Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93355/?format=api
{ "id": 93355, "url": "http://patches.dpdk.org/api/patches/93355/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210521020004.100034-1-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210521020004.100034-1-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210521020004.100034-1-feifei.wang2@arm.com", "date": "2021-05-21T02:00:04", "name": "[v5] crypto/qat: fix uninitialized gcc compiler warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e4d05ce4100762812d1b301380b71022f8ec627d", "submitter": { "id": 1771, "url": "http://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210521020004.100034-1-feifei.wang2@arm.com/mbox/", "series": [ { "id": 17063, "url": "http://patches.dpdk.org/api/series/17063/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17063", "date": "2021-05-21T02:00:04", "name": "[v5] crypto/qat: fix uninitialized gcc compiler warning", "version": 5, "mbox": "http://patches.dpdk.org/series/17063/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93355/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/93355/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CFE82A0A02;\n\tFri, 21 May 2021 04:00:17 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 260D24069E;\n\tFri, 21 May 2021 04:00:17 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 35F4D40041;\n Fri, 21 May 2021 04:00:15 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9ECB5101E;\n Thu, 20 May 2021 19:00:14 -0700 (PDT)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.132])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BB7143F73D;\n Thu, 20 May 2021 19:00:10 -0700 (PDT)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "John Griffin <john.griffin@intel.com>,\n Fiona Trahe <fiona.trahe@intel.com>,\n Deepak Kumar Jain <deepak.k.jain@intel.com>,\n Jerin Jacob <jerin.jacob@caviumnetworks.com>,\n Herbert Guan <herbert.guan@arm.com>", "Cc": "dev@dpdk.org, ferruh.yigit@intel.com, adamx.dybkowski@intel.com,\n nd@arm.com, Feifei Wang <feifei.wang2@arm.com>, stable@dpdk.org,\n Ruifeng Wang <ruifeng.wang@arm.com>,\n Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>", "Date": "Fri, 21 May 2021 10:00:04 +0800", "Message-Id": "<20210521020004.100034-1-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210514074113.2666225-1-feifei.wang2@arm.com>", "References": "<20210514074113.2666225-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5] crypto/qat: fix uninitialized gcc compiler\n warning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In Arm platform, when \"RTE_ARCH_ARM64_MEMCPY\" is set as true, gcc will\nreport variable uninitialized warning:\n\n../drivers/crypto/qat/qat_sym_session.c: In function ‘partial_hash_compute’:\n../lib/eal/include/generic/rte_byteorder.h:241:24: warning:\n‘<U35a0>’ may be used uninitialized in this function\n\t[-Wmaybe-uninitialized]\n\t241 | #define rte_bswap32(x) __builtin_bswap32(x)\n\t...\n\nThis is because \"digest\" will be initialized by \"rte_memcpy\" function\nrather than \"memcpy\" if \"RTE_ARCH_ARM64_MEMCPY\" is set as true.\nFurthermore, 'rte_memcpy' will initialize 'digest' with two steps\nby invoking rte_mov_x functions. For example:\n\npartial_hash_sha1 -> rte_memcpy -> rte_memcpy_ge16_lt_128 ->\nstep 1: rte_mov16(dst,src )\nstep 2: rte_mov16(dst - 16 + n, src - 16 + n)\n\nHowever, gcc compiler cannot identify this multi-step initialization,\nthen it will report warning.\n\nTo fix this, use \"memset\" to initialize \"digest\".\n\nFixes: cd7fc8a84b48 (\"eal/arm64: optimize memcpy\")\nCc: stable@dpdk.org\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\nAcked-by: Adam Dybkowski <adamx.dybkowski@intel.com>\n---\nv2: add check and free for memory dynamic allocation (David Marchand)\nv3: fix compiler error\nv4: use 'memset' to initialize digest (Ferruh, Adam)\nv5: fixed spelling errors in commit message (Honnappa)\n\n\n drivers/crypto/qat/qat_sym_session.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c\nindex 231b1640da..e22dd3600c 100644\n--- a/drivers/crypto/qat/qat_sym_session.c\n+++ b/drivers/crypto/qat/qat_sym_session.c\n@@ -1196,6 +1196,9 @@ static int partial_hash_compute(enum icp_qat_hw_auth_algo hash_alg,\n \tuint64_t *hash_state_out_be64;\n \tint i;\n \n+\t/* Initialize to avoid gcc warning */\n+\tmemset(digest, 0, sizeof(digest));\n+\n \tdigest_size = qat_hash_get_digest_size(hash_alg);\n \tif (digest_size <= 0)\n \t\treturn -EFAULT;\n", "prefixes": [ "v5" ] }