Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93163/?format=api
{ "id": 93163, "url": "http://patches.dpdk.org/api/patches/93163/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210511131435.1226820-3-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210511131435.1226820-3-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210511131435.1226820-3-ferruh.yigit@intel.com", "date": "2021-05-11T13:14:34", "name": "[v3,3/4] net/ice/base: fix build with gcc11", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a6977c607a619e9d5707948862e76786541d93bc", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210511131435.1226820-3-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 16927, "url": "http://patches.dpdk.org/api/series/16927/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16927", "date": "2021-05-11T13:14:32", "name": "[v3,1/4] net/bnx2x: fix build with gcc11", "version": 3, "mbox": "http://patches.dpdk.org/series/16927/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93163/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93163/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 037CEA0A0E;\n\tTue, 11 May 2021 15:14:56 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B16D2406A3;\n\tTue, 11 May 2021 15:14:51 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 9C1EB4003E;\n Tue, 11 May 2021 15:14:49 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 May 2021 06:14:46 -0700", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.27])\n by fmsmga001.fm.intel.com with ESMTP; 11 May 2021 06:14:43 -0700" ], "IronPort-SDR": [ "\n xMTqRLZd9j2pYE0iB3UAC+OfGA2wdTGKpY66FTO92ACGFw/swgbPKe629xcm5R/DZnBiaGNoFM\n h4vNhF0xCMYA==", "\n jjIN1qJzwASPIoP/gnmVgBItET5jW7QxxHxRw9fdF+LWE8GQB6UFmmY6o5zwOpqipDSvskyq1S\n O2Eonl/b1A9g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9980\"; a=\"284928130\"", "E=Sophos;i=\"5.82,290,1613462400\"; d=\"scan'208\";a=\"284928130\"", "E=Sophos;i=\"5.82,290,1613462400\"; d=\"scan'208\";a=\"537021119\"" ], "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,\n Wenzhuo Lu <wenzhuo.lu@intel.com>,\n Shivanshu Shukla <shivanshu.shukla@intel.com>,\n Leyi Rong <leyi.rong@intel.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, stable@dpdk.org,\n Kevin Traynor <ktraynor@redhat.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>", "Date": "Tue, 11 May 2021 14:14:34 +0100", "Message-Id": "<20210511131435.1226820-3-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210511131435.1226820-1-ferruh.yigit@intel.com>", "References": "<20210510150319.1496105-1-ferruh.yigit@intel.com>\n <20210511131435.1226820-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 3/4] net/ice/base: fix build with gcc11", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reproduced with '--buildtype=debugoptimized' config,\ncompiler version: gcc (GCC) 12.0.0 20210509 (experimental)\n\nThere are multiple build errors, like:\n../drivers/net/ice/base/ice_switch.c: In function ‘ice_add_marker_act’:\n../drivers/net/ice/base/ice_switch.c:3727:15:\n\twarning: array subscript ‘struct ice_aqc_sw_rules_elem[0]’\n\tis partly outside array bounds of ‘unsigned char[52]’\n\t[-Warray-bounds]\n 3727 | lg_act->type = CPU_TO_LE16(ICE_AQC_SW_RULES_T_LG_ACT);\n | ^~\nIn file included from ../drivers/net/ice/base/ice_type.h:52,\n from ../drivers/net/ice/base/ice_common.h:8,\n from ../drivers/net/ice/base/ice_switch.h:8,\n from ../drivers/net/ice/base/ice_switch.c:5:\n../drivers/net/ice/base/ice_osdep.h:209:29:\n\tnote: referencing an object of size 52 allocated by ‘rte_zmalloc’\n 209 | #define ice_malloc(h, s) rte_zmalloc(NULL, s, 0)\n | ^~~~~~~~~~~~~~~~~~~~~~~\n../drivers/net/ice/base/ice_switch.c:3720:50:\n\tnote: in expansion of macro ‘ice_malloc’\n lg_act = (struct ice_aqc_sw_rules_elem *)ice_malloc(hw, rules_size);\n\nThese errors are mainly because allocated memory is cast to\n\"struct ice_aqc_sw_rules_elem *\" but allocated size is less than the size\nof \"struct ice_aqc_sw_rules_elem\".\n\n\"struct ice_aqc_sw_rules_elem\" has multiple other structs has unions,\nbased on which one is used allocated memory being less than the size of\n\"struct ice_aqc_sw_rules_elem\" is logically correct but compiler is\ncomplaining about it.\n\nSince the allocation is done explicitly and both producer and consumer\nare internal, safe to ignore the warnings. Also to prevent any side\naffect disabling the compiler warning for now, until proper fix done.\n\nReducing the warning disable to gcc >= 11 version.\n\nBugzilla ID: 678\nFixes: c7dd15931183 (\"net/ice/base: add virtual switch code\")\nFixes: 02acdce2f553 (\"net/ice/base: add MAC filter with marker and counter\")\nFixes: f89aa3affa9e (\"net/ice/base: support removing advanced rule\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: paul.m.stillwell.jr@intel.com\nCc: qi.z.zhang@intel.com\nCc: leyi.rong@intel.com\nCc: Kevin Traynor <ktraynor@redhat.com>\nCc: Ajit Khaparde <ajit.khaparde@broadcom.com>\n\nv2:\n* Kevin reported more occurrences, the concern is to have more as the\n gcc version updated. And as the size of changes increases, the risk of\n unexpected side affect also increases.\n So disabling the 'array-bounds' warning for this release for\n gcc >= 11.0.0.\n---\n drivers/net/ice/base/meson.build | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build\nindex 6c548a99775c..3305e5dd1822 100644\n--- a/drivers/net/ice/base/meson.build\n+++ b/drivers/net/ice/base/meson.build\n@@ -23,6 +23,11 @@ error_cflags = [\n '-Wno-unused-parameter',\n ]\n \n+# Bugzilla ID: 678\n+if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))\n+ error_cflags += ['-Wno-array-bounds']\n+endif\n+\n if is_windows and cc.get_id() != 'clang'\n cflags += ['-fno-asynchronous-unwind-tables']\n endif\n", "prefixes": [ "v3", "3/4" ] }