Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92767/?format=api
{ "id": 92767, "url": "http://patches.dpdk.org/api/patches/92767/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210504210857.3398397-9-matan@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210504210857.3398397-9-matan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210504210857.3398397-9-matan@nvidia.com", "date": "2021-05-04T21:08:50", "name": "[v3,08/15] crypto/mlx5: create login object using DevX", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "312afbc0ed9711253aba48c5171b1588eca8ab12", "submitter": { "id": 1911, "url": "http://patches.dpdk.org/api/people/1911/?format=api", "name": "Matan Azrad", "email": "matan@nvidia.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210504210857.3398397-9-matan@nvidia.com/mbox/", "series": [ { "id": 16812, "url": "http://patches.dpdk.org/api/series/16812/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16812", "date": "2021-05-04T21:08:42", "name": "drivers: introduce mlx5 crypto PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/16812/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92767/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92767/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9560FA0A02;\n\tTue, 4 May 2021 23:10:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BD78D41117;\n\tTue, 4 May 2021 23:09:41 +0200 (CEST)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2056.outbound.protection.outlook.com [40.107.220.56])\n by mails.dpdk.org (Postfix) with ESMTP id AC5D341117\n for <dev@dpdk.org>; Tue, 4 May 2021 23:09:39 +0200 (CEST)", "from MW4PR03CA0248.namprd03.prod.outlook.com (2603:10b6:303:b4::13)\n by MN2PR12MB4390.namprd12.prod.outlook.com (2603:10b6:208:26e::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.44; Tue, 4 May\n 2021 21:09:37 +0000", "from CO1NAM11FT034.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:b4:cafe::74) by MW4PR03CA0248.outlook.office365.com\n (2603:10b6:303:b4::13) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend\n Transport; Tue, 4 May 2021 21:09:37 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT034.mail.protection.outlook.com (10.13.174.248) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4087.27 via Frontend Transport; Tue, 4 May 2021 21:09:37 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 4 May\n 2021 21:09:35 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=aFlyVIgSyN2U0N9Ul28B77eOdOOwZvHaM9ZDKdx55Nf5CO0nC2oh88W1YtgjnO4MfPFNhbcKc68jgw0L4+VIyQenk4PkQmP5X2Z/UmnpehEjV4ydf2B8lC3ck/gRoZiUlUP896OXIrAoj3eRLW79hWCkh6yP1KeKdxmkYBS2uImKr926y6xa+ZX3bz2ixv3iQ+ItSjn7Yo0xO14sIAQB2oFW0yKjPpAgdpbm/a5iGJo1PDDE6NuCt1884L3HzT8KOaBcoMoeD5o6zf81S1+caqi16WMFLupy/VjC1FajlEHgyvr55p7kr1HTXW0HKt0CW6QF8Fq3f6y9AB2ixFbvDw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=TFCmbJ17Ov/I2l4YMjUGrPqntZtrYSrCT9Mg6xeKU50=;\n b=IslGtKeGx+CBXX9EB4B5qhx4bmiBrg1HqE2GU9jz7UNtgnEFbmNtkxc5T/0O0Aft1tDFGJ7SLT5Hbp9jX+jOITx0/37EPSsPEbL36gcQrhnRAq2sSfqDGPw8DsGd50PCt9H7qYJySW5rokc2ySRLnJEB3wccBmz4YH5166PetbNtZ5pGdNWggeEn6joughTcDnjUyfC5VNz4/HP+JcYWNJjj7izpQZ3U5IMSy4zYTsFObrmcoppxTZd/wJYmhNMcg3QgKVFexpxYE2WYSJ7q4AaFpoa4Tmk2FTxrwd8W9gyJLdZ8uWKqxghq6I9OjqGhLCngkXU79DYKuWHt8m9g1A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=TFCmbJ17Ov/I2l4YMjUGrPqntZtrYSrCT9Mg6xeKU50=;\n b=P60CbBTLefT04DAPVtrnwMbBG8qbOLrU30b0ohqKw3i8n6MEriWt/4ICLiafjGDO+4gxadDjS8tX7RYKSd72YxZZ5dX3fyvkmaUC0XS2AGvKA/5sxrE179c8MJIalIC9ln9ECpcT370otdbfu8szqvCrM5bC3Xl19fm8G/XgWxPGBybMzKnoL2kxd7+iOphVTiBlNFytzPURQoAp3zf8XKSdMkvIfkfjFCWfKC1KuHnJJcZifVzehWQyIYrpLzS6VGZUX35tTJR+yHuAtCszyCvYGG3NHN9l1C417/8yJy4BORwz9LY6fDmxE6CdsGe+YgZ0CS9ovUALWs1IQwKJ9Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)\n header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Matan Azrad <matan@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<matan@nvidia.com>, <gakhil@marvell.com>, <suanmingm@nvidia.com>, \"Thomas\n Monjalon\" <thomas@monjalon.net>, Shiri Kuzin <shirik@nvidia.com>", "Date": "Wed, 5 May 2021 00:08:50 +0300", "Message-ID": "<20210504210857.3398397-9-matan@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210504210857.3398397-1-matan@nvidia.com>", "References": "<20210429154712.2820159-1-matan@nvidia.com>\n <20210504210857.3398397-1-matan@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "52fe484d-bdf1-41f1-a0f3-08d90f40ecb4", "X-MS-TrafficTypeDiagnostic": "MN2PR12MB4390:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <MN2PR12MB4390D2B4091A6E1448126935DF5A9@MN2PR12MB4390.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:92;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n DMLpK5Jt8V1QzUyr8e1gjSru/mPVr0j+aBKSfb+t5KavQ4QWcUVHeMEk5WrFDz8eBtLL4mJGd2wtZwmIxgLYLIPkmsqM1FmZjSee26RMTLgwFdkO+JBJm9bBQ6W/MHFJBQH9knlaC+dpeE2T56FhUupy2KVrqrZweGib+a+nT5hDEnhmKtJotClkxbznAj/ZM20UYErfX5kuNVzpCg7AMLvAEnumx/PnhqBhWVkbJqZWYlkGU+S84KDzu8TsfcQ7NjW8+RciziSDKLEl3CPXg6Yr/B2k8KJiGSzslMjzM3Icoe2UNq10qxabu9bi8WWdbPpEcPeLgHzwnWA92Tx/SRducavIbhUw9yvaJg28suksgTi19v+y1xHTCWi5zz5zq/7POpSSVW1cBWVFcszYsQt/WuLKge+PrbAraObAC2D4uPo5LDNRlTsHOKZ4Y0lf2kaD51pg3OtLQ5mNd9wQwQ8ZEe+8NIzGE/arAQL7woRrTh6K+zwsxc/ld+LztyLNvmxJT03GcRVx8bSB18Xl+dwjgSLFeBQBeJIFvWHSr0u8sULWkhsIs7Hau8hZ+atczTrjDlxI/HBzBJZnqVRY2iOmscoPUGlgpscXWszvKnbg9iU73UpTOmWeLobAXHbNA4Fzxnudj4FbNpMsn8dUXl9dDbMXw0pc8yKJ+JKWDk0=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(376002)(396003)(346002)(136003)(39860400002)(36840700001)(46966006)(36756003)(6286002)(186003)(16526019)(70586007)(2906002)(356005)(426003)(2616005)(26005)(54906003)(82310400003)(36906005)(8676002)(4326008)(8936002)(82740400003)(1076003)(7696005)(6916009)(316002)(55016002)(107886003)(36860700001)(478600001)(7636003)(86362001)(70206006)(47076005)(5660300002)(6666004)(336012)(83380400001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 May 2021 21:09:37.2210 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 52fe484d-bdf1-41f1-a0f3-08d90f40ecb4", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT034.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB4390", "Subject": "[dpdk-dev] [PATCH v3 08/15] crypto/mlx5: create login object using\n DevX", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shiri Kuzin <shirik@nvidia.com>\n\nTo work with crypto engines that are marked with wrapped_import_method,\na login session is required.\nA crypto login object needs to be created using DevX.\n\nThe crypto login object contains:\n\t- The credential pointer.\n\t- The import_KEK pointer to be used for all secured information\n\t communicated in crypto commands (key fields), including the\n\t provided credential in this command.\n\t- The credential secret, wrapped by the import_KEK indicated in\n\t this command. Size includes 8 bytes IV for wrapping.\n\nAdded devargs for the required login values:\n\t- wcs_file - path to the file containing the credential.\n\t- import_kek_id - the import KEK pointer.\n\t- credential_id - the credential pointer.\n\nCreate the login DevX object in pci_probe function and destroy it in\npci_remove.\nDestroying the crypto login object means logout.\n\nSigned-off-by: Shiri Kuzin <shirik@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/crypto/mlx5/mlx5_crypto.c | 103 ++++++++++++++++++++++++++++++\n drivers/crypto/mlx5/mlx5_crypto.h | 7 ++\n 2 files changed, 110 insertions(+)", "diff": "diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c\nindex b95aea0068..18b1a6be88 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.c\n+++ b/drivers/crypto/mlx5/mlx5_crypto.c\n@@ -402,6 +402,101 @@ mlx5_crypto_hw_global_prepare(struct mlx5_crypto_priv *priv)\n \treturn 0;\n }\n \n+\n+static int\n+mlx5_crypto_args_check_handler(const char *key, const char *val, void *opaque)\n+{\n+\tstruct mlx5_crypto_devarg_params *devarg_prms = opaque;\n+\tstruct mlx5_devx_crypto_login_attr *attr = &devarg_prms->login_attr;\n+\tunsigned long tmp;\n+\tFILE *file;\n+\tint ret;\n+\tint i;\n+\n+\tif (strcmp(key, \"class\") == 0)\n+\t\treturn 0;\n+\tif (strcmp(key, \"wcs_file\") == 0) {\n+\t\tfile = fopen(val, \"rb\");\n+\t\tif (file == NULL) {\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t\tfor (i = 0 ; i < MLX5_CRYPTO_CREDENTIAL_SIZE ; i++) {\n+\t\t\tret = fscanf(file, \"%02hhX\", &attr->credential[i]);\n+\t\t\tif (ret <= 0) {\n+\t\t\t\tfclose(file);\n+\t\t\t\tDRV_LOG(ERR,\n+\t\t\t\t\t\"Failed to read credential from file.\");\n+\t\t\t\trte_errno = EINVAL;\n+\t\t\t\treturn -rte_errno;\n+\t\t\t}\n+\t\t}\n+\t\tfclose(file);\n+\t\tdevarg_prms->login_devarg = true;\n+\t\treturn 0;\n+\t}\n+\terrno = 0;\n+\ttmp = strtoul(val, NULL, 0);\n+\tif (errno) {\n+\t\tDRV_LOG(WARNING, \"%s: \\\"%s\\\" is an invalid integer.\", key, val);\n+\t\treturn -errno;\n+\t}\n+\tif (strcmp(key, \"import_kek_id\") == 0)\n+\t\tattr->session_import_kek_ptr = (uint32_t)tmp;\n+\telse if (strcmp(key, \"credential_id\") == 0)\n+\t\tattr->credential_pointer = (uint32_t)tmp;\n+\telse\n+\t\tDRV_LOG(WARNING, \"Invalid key %s.\", key);\n+\treturn 0;\n+}\n+\n+static struct mlx5_devx_obj *\n+mlx5_crypto_config_login(struct rte_devargs *devargs,\n+\t\t\t struct ibv_context *ctx)\n+{\n+\t/*\n+\t * Set credential pointer and session import KEK pointer to a default\n+\t * value of 0.\n+\t */\n+\tstruct mlx5_crypto_devarg_params login = {\n+\t\t\t.login_devarg = false,\n+\t\t\t.login_attr = {\n+\t\t\t\t\t.credential_pointer = 0,\n+\t\t\t\t\t.session_import_kek_ptr = 0,\n+\t\t\t}\n+\t};\n+\tstruct rte_kvargs *kvlist;\n+\n+\tif (devargs == NULL) {\n+\t\tDRV_LOG(ERR,\n+\t\"No login devargs in order to enable crypto operations in the device.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\tkvlist = rte_kvargs_parse(devargs->args, NULL);\n+\tif (kvlist == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed to parse devargs.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\tif (rte_kvargs_process(kvlist, NULL, mlx5_crypto_args_check_handler,\n+\t\t\t &login) != 0) {\n+\t\tDRV_LOG(ERR, \"Devargs handler function Failed.\");\n+\t\trte_kvargs_free(kvlist);\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\trte_kvargs_free(kvlist);\n+\tif (login.login_devarg == false) {\n+\t\tDRV_LOG(ERR,\n+\t\"No login credential devarg in order to enable crypto operations \"\n+\t\"in the device.\");\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\treturn mlx5_devx_cmd_create_crypto_login_obj(ctx, &login.login_attr);\n+}\n+\n /**\n * DPDK callback to register a PCI device.\n *\n@@ -423,6 +518,7 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \tstruct ibv_device *ibv;\n \tstruct rte_cryptodev *crypto_dev;\n \tstruct ibv_context *ctx;\n+\tstruct mlx5_devx_obj *login;\n \tstruct mlx5_crypto_priv *priv;\n \tstruct mlx5_hca_attr attr = { 0 };\n \tstruct rte_cryptodev_pmd_init_params init_params = {\n@@ -461,6 +557,11 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \t\trte_errno = ENOTSUP;\n \t\treturn -ENOTSUP;\n \t}\n+\tlogin = mlx5_crypto_config_login(pci_dev->device.devargs, ctx);\n+\tif (login == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed to configure login.\");\n+\t\treturn -rte_errno;\n+\t}\n \tcrypto_dev = rte_cryptodev_pmd_create(ibv->name, &pci_dev->device,\n \t\t\t\t\t&init_params);\n \tif (crypto_dev == NULL) {\n@@ -477,6 +578,7 @@ mlx5_crypto_pci_probe(struct rte_pci_driver *pci_drv,\n \tcrypto_dev->driver_id = mlx5_crypto_driver_id;\n \tpriv = crypto_dev->data->dev_private;\n \tpriv->ctx = ctx;\n+\tpriv->login_obj = login;\n \tpriv->pci_dev = pci_dev;\n \tpriv->crypto_dev = crypto_dev;\n \tif (mlx5_crypto_hw_global_prepare(priv) != 0) {\n@@ -517,6 +619,7 @@ mlx5_crypto_pci_remove(struct rte_pci_device *pdev)\n \t\tmlx5_mr_release_cache(&priv->mr_scache);\n \t\tmlx5_crypto_hw_global_release(priv);\n \t\trte_cryptodev_pmd_destroy(priv->crypto_dev);\n+\t\tclaim_zero(mlx5_devx_cmd_destroy(priv->login_obj));\n \t\tclaim_zero(mlx5_glue->close_device(priv->ctx));\n \t}\n \treturn 0;\ndiff --git a/drivers/crypto/mlx5/mlx5_crypto.h b/drivers/crypto/mlx5/mlx5_crypto.h\nindex 397267d249..0aef804b92 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.h\n+++ b/drivers/crypto/mlx5/mlx5_crypto.h\n@@ -29,6 +29,7 @@ struct mlx5_crypto_priv {\n \tstruct mlx5_hlist *dek_hlist; /* Dek hash list. */\n \tstruct rte_cryptodev_config dev_config;\n \tstruct mlx5_mr_share_cache mr_scache; /* Global shared MR cache. */\n+\tstruct mlx5_devx_obj *login_obj;\n };\n \n struct mlx5_crypto_qp {\n@@ -48,6 +49,12 @@ struct mlx5_crypto_dek {\n \tbool size_is_48; /* Whether the key\\data size is 48 bytes or not. */\n };\n \n+\n+struct mlx5_crypto_devarg_params {\n+\tbool login_devarg;\n+\tstruct mlx5_devx_crypto_login_attr login_attr;\n+};\n+\n int\n mlx5_crypto_dek_destroy(struct mlx5_crypto_priv *priv,\n \t\t\tstruct mlx5_crypto_dek *dek);\n", "prefixes": [ "v3", "08/15" ] }