Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92471/?format=api
{ "id": 92471, "url": "http://patches.dpdk.org/api/patches/92471/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619773444-10074-4-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619773444-10074-4-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619773444-10074-4-git-send-email-humin29@huawei.com", "date": "2021-04-30T09:04:04", "name": "[3/3] net/hns3: fix format u64 variable readability", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "68cd7e56b2e041efd6b9caae1b63014d9f9bfbf8", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619773444-10074-4-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16771, "url": "http://patches.dpdk.org/api/series/16771/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16771", "date": "2021-04-30T09:04:03", "name": "bufixes for hns3 PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/16771/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92471/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/92471/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89979A0546;\n\tFri, 30 Apr 2021 11:04:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5A58B41129;\n\tFri, 30 Apr 2021 11:04:06 +0200 (CEST)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id A42334013F\n for <dev@dpdk.org>; Fri, 30 Apr 2021 11:04:01 +0200 (CEST)", "from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FWmZL0n11z19M1r\n for <dev@dpdk.org>; Fri, 30 Apr 2021 17:01:30 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id\n 14.3.498.0; Fri, 30 Apr 2021 17:03:57 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Fri, 30 Apr 2021 17:04:04 +0800", "Message-ID": "<1619773444-10074-4-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619773444-10074-1-git-send-email-humin29@huawei.com>", "References": "<1619773444-10074-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 3/3] net/hns3: fix format u64 variable readability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nSome logs format u64 variables, mostly using hexadecimal which was not\nreadable.\nThis patch formats most u64 variables in decimal, and add '0x' prefix\nto the ones that are not adjusted.\n\nFixes: c37ca66f2b27 (\"net/hns3: support RSS\")\nFixes: 2790c6464725 (\"net/hns3: support device reset\")\nFixes: 8839c5e202f3 (\"net/hns3: support device stats\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 2 +-\n drivers/net/hns3/hns3_intr.c | 20 ++++++++++----------\n drivers/net/hns3/hns3_stats.c | 8 ++++----\n 3 files changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 49d6568..65c7f6e 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1556,7 +1556,7 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \t\t hw->rss_info.conf.types;\n \tif (flow_types != rss_flow_conf.types)\n \t\thns3_warn(hw, \"modified RSS types based on hardware support, \"\n-\t\t\t \"requested:%\" PRIx64 \" configured:%\" PRIx64,\n+\t\t\t \"requested:0x%\" PRIx64 \" configured:0x%\" PRIx64,\n \t\t\t rss_flow_conf.types, flow_types);\n \t/* Update the useful flow types */\n \trss_flow_conf.types = flow_types;\ndiff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c\nindex 62e89a9..905c6d9 100644\n--- a/drivers/net/hns3/hns3_intr.c\n+++ b/drivers/net/hns3/hns3_intr.c\n@@ -2570,7 +2570,7 @@ hns3_clear_reset_level(struct hns3_hw *hw, uint64_t *levels)\n \tif (merge_cnt != hw->reset.stats.merge_cnt)\n \t\thns3_warn(hw,\n \t\t\t \"No need to do low-level reset after %s reset. \"\n-\t\t\t \"merge cnt: %\" PRIx64 \" total merge cnt: %\" PRIx64,\n+\t\t\t \"merge cnt: %\" PRIu64 \" total merge cnt: %\" PRIu64,\n \t\t\t reset_string[hw->reset.level],\n \t\t\t hw->reset.stats.merge_cnt - merge_cnt,\n \t\t\t hw->reset.stats.merge_cnt);\n@@ -2590,7 +2590,7 @@ hns3_reset_err_handle(struct hns3_adapter *hns)\n \t\thw->reset.attempts = 0;\n \t\thw->reset.stats.fail_cnt++;\n \t\thns3_warn(hw, \"%s reset fail because new Reset is pending \"\n-\t\t\t \"attempts:%\" PRIx64,\n+\t\t\t \"attempts:%\" PRIu64,\n \t\t\t reset_string[hw->reset.level],\n \t\t\t hw->reset.stats.fail_cnt);\n \t\thw->reset.level = HNS3_NONE_RESET;\n@@ -2617,10 +2617,10 @@ hns3_reset_err_handle(struct hns3_adapter *hns)\n reset_fail:\n \thw->reset.attempts = 0;\n \thw->reset.stats.fail_cnt++;\n-\thns3_warn(hw, \"%s reset fail fail_cnt:%\" PRIx64 \" success_cnt:%\" PRIx64\n-\t\t \" global_cnt:%\" PRIx64 \" imp_cnt:%\" PRIx64\n-\t\t \" request_cnt:%\" PRIx64 \" exec_cnt:%\" PRIx64\n-\t\t \" merge_cnt:%\" PRIx64 \"adapter_state:%d\",\n+\thns3_warn(hw, \"%s reset fail fail_cnt:%\" PRIu64 \" success_cnt:%\" PRIu64\n+\t\t \" global_cnt:%\" PRIu64 \" imp_cnt:%\" PRIu64\n+\t\t \" request_cnt:%\" PRIu64 \" exec_cnt:%\" PRIu64\n+\t\t \" merge_cnt:%\" PRIu64 \"adapter_state:%d\",\n \t\t reset_string[hw->reset.level], hw->reset.stats.fail_cnt,\n \t\t hw->reset.stats.success_cnt, hw->reset.stats.global_cnt,\n \t\t hw->reset.stats.imp_cnt, hw->reset.stats.request_cnt,\n@@ -2736,10 +2736,10 @@ hns3_reset_post(struct hns3_adapter *hns)\n \t\trte_spinlock_unlock(&hw->lock);\n \t\thns3_clock_gettime(&tv);\n \t\ttimersub(&tv, &hw->reset.start_time, &tv_delta);\n-\t\thns3_warn(hw, \"%s reset done fail_cnt:%\" PRIx64\n-\t\t\t \" success_cnt:%\" PRIx64 \" global_cnt:%\" PRIx64\n-\t\t\t \" imp_cnt:%\" PRIx64 \" request_cnt:%\" PRIx64\n-\t\t\t \" exec_cnt:%\" PRIx64 \" merge_cnt:%\" PRIx64,\n+\t\thns3_warn(hw, \"%s reset done fail_cnt:%\" PRIu64\n+\t\t\t \" success_cnt:%\" PRIu64 \" global_cnt:%\" PRIu64\n+\t\t\t \" imp_cnt:%\" PRIu64 \" request_cnt:%\" PRIu64\n+\t\t\t \" exec_cnt:%\" PRIu64 \" merge_cnt:%\" PRIu64,\n \t\t\t reset_string[hw->reset.level],\n \t\t\t hw->reset.stats.fail_cnt, hw->reset.stats.success_cnt,\n \t\t\t hw->reset.stats.global_cnt, hw->reset.stats.imp_cnt,\ndiff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex 3afef4a..e09dc0d 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -1325,7 +1325,7 @@ hns3_dev_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n \tlen = cnt_stats * sizeof(struct rte_eth_xstat);\n \tvalues_copy = rte_zmalloc(\"hns3_xstats_values\", len, 0);\n \tif (values_copy == NULL) {\n-\t\thns3_err(hw, \"Failed to allocate %\" PRIx64 \" bytes needed \"\n+\t\thns3_err(hw, \"Failed to allocate 0x%\" PRIx64 \" bytes needed \"\n \t\t\t \"to store statistics values\", len);\n \t\treturn -ENOMEM;\n \t}\n@@ -1347,7 +1347,7 @@ hns3_dev_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n \n \tfor (i = 0; i < size; i++) {\n \t\tif (ids[i] >= cnt_stats) {\n-\t\t\thns3_err(hw, \"ids[%u] (%\" PRIx64 \") is invalid, \"\n+\t\t\thns3_err(hw, \"ids[%u] (%\" PRIu64 \") is invalid, \"\n \t\t\t\t \"should < %u\", i, ids[i], cnt_stats);\n \t\t\trte_free(values_copy);\n \t\t\treturn -EINVAL;\n@@ -1406,7 +1406,7 @@ hns3_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n \tlen = cnt_stats * sizeof(struct rte_eth_xstat_name);\n \tnames_copy = rte_zmalloc(\"hns3_xstats_names\", len, 0);\n \tif (names_copy == NULL) {\n-\t\thns3_err(hw, \"Failed to allocate %\" PRIx64 \" bytes needed \"\n+\t\thns3_err(hw, \"Failed to allocate 0x%\" PRIx64 \" bytes needed \"\n \t\t\t \"to store statistics names\", len);\n \t\treturn -ENOMEM;\n \t}\n@@ -1415,7 +1415,7 @@ hns3_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n \n \tfor (i = 0; i < size; i++) {\n \t\tif (ids[i] >= cnt_stats) {\n-\t\t\thns3_err(hw, \"ids[%u] (%\" PRIx64 \") is invalid, \"\n+\t\t\thns3_err(hw, \"ids[%u] (%\" PRIu64 \") is invalid, \"\n \t\t\t\t \"should < %u\", i, ids[i], cnt_stats);\n \t\t\trte_free(names_copy);\n \t\t\treturn -EINVAL;\n", "prefixes": [ "3/3" ] }