Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92305/?format=api
{ "id": 92305, "url": "http://patches.dpdk.org/api/patches/92305/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619592046-22269-2-git-send-email-lihuisong@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619592046-22269-2-git-send-email-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619592046-22269-2-git-send-email-lihuisong@huawei.com", "date": "2021-04-28T06:40:40", "name": "[V4,1/7] app/testpmd: fix forward lcores number when DCB test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4561b9e0fe23da38544db703ddc5e438b30f84eb", "submitter": { "id": 2085, "url": "http://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619592046-22269-2-git-send-email-lihuisong@huawei.com/mbox/", "series": [ { "id": 16709, "url": "http://patches.dpdk.org/api/series/16709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16709", "date": "2021-04-28T06:40:39", "name": "modifications about DCB forwarding configuration", "version": 4, "mbox": "http://patches.dpdk.org/series/16709/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92305/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92305/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7BF2A0A0E;\n\tWed, 28 Apr 2021 08:41:29 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1D82E412A2;\n\tWed, 28 Apr 2021 08:40:57 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id AD3A640697\n for <dev@dpdk.org>; Wed, 28 Apr 2021 08:40:46 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FVTTD0pvmzPty6\n for <dev@dpdk.org>; Wed, 28 Apr 2021 14:37:36 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id\n 14.3.498.0; Wed, 28 Apr 2021 14:40:40 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <xiaoyun.li@intel.com>", "Date": "Wed, 28 Apr 2021 14:40:40 +0800", "Message-ID": "<1619592046-22269-2-git-send-email-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619592046-22269-1-git-send-email-lihuisong@huawei.com>", "References": "<1614939741-63927-1-git-send-email-oulijun@huawei.com>\n <1619592046-22269-1-git-send-email-lihuisong@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH V4 1/7] app/testpmd: fix forward lcores number\n when DCB test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For the DCB forwarding test, each core is assigned to each traffic class.\nNumber of forwarding cores for DCB test must be equal or less than number\nof total TC. Otherwise, the following problems may occur:\n1/ Redundant polling threads will be created when forwarding cores number\n is greater than total TC number.\n2/ Two cores would try to use a same queue on a port when Rx/Tx queue\n number is greater than the used TC number, which is not allowed.\n\nFixes: 900550de04a7 (\"app/testpmd: add dcb support\")\nFixes: ce8d561418d4 (\"app/testpmd: add port configuration settings\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n app/test-pmd/config.c | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex a4445a7..39c0b80 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -3008,6 +3008,21 @@ rss_fwd_config_setup(void)\n \t}\n }\n \n+static uint16_t\n+get_fwd_port_total_tc_num(void)\n+{\n+\tstruct rte_eth_dcb_info dcb_info;\n+\tuint16_t total_tc_num = 0;\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < nb_fwd_ports; i++) {\n+\t\t(void)rte_eth_dev_get_dcb_info(fwd_ports_ids[i], &dcb_info);\n+\t\ttotal_tc_num += dcb_info.nb_tcs;\n+\t}\n+\n+\treturn total_tc_num;\n+}\n+\n /**\n * For the DCB forwarding test, each core is assigned on each traffic class.\n *\n@@ -3027,12 +3042,16 @@ dcb_fwd_config_setup(void)\n \tlcoreid_t lc_id;\n \tuint16_t nb_rx_queue, nb_tx_queue;\n \tuint16_t i, j, k, sm_id = 0;\n+\tuint16_t total_tc_num;\n \tuint8_t tc = 0;\n \n \tcur_fwd_config.nb_fwd_lcores = (lcoreid_t) nb_fwd_lcores;\n \tcur_fwd_config.nb_fwd_ports = nb_fwd_ports;\n \tcur_fwd_config.nb_fwd_streams =\n \t\t(streamid_t) (nb_rxq * cur_fwd_config.nb_fwd_ports);\n+\ttotal_tc_num = get_fwd_port_total_tc_num();\n+\tif (cur_fwd_config.nb_fwd_lcores > total_tc_num)\n+\t\tcur_fwd_config.nb_fwd_lcores = total_tc_num;\n \n \t/* reinitialize forwarding streams */\n \tinit_fwd_streams();\n", "prefixes": [ "V4", "1/7" ] }