Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92239/?format=api
{ "id": 92239, "url": "http://patches.dpdk.org/api/patches/92239/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619515014-19181-1-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619515014-19181-1-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619515014-19181-1-git-send-email-humin29@huawei.com", "date": "2021-04-27T09:16:54", "name": "[v2] net/bonding: fix socket id check", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3e3b79a7a2e4497a13c593505ede8c013fc36cbc", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619515014-19181-1-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16694, "url": "http://patches.dpdk.org/api/series/16694/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16694", "date": "2021-04-27T09:16:54", "name": "[v2] net/bonding: fix socket id check", "version": 2, "mbox": "http://patches.dpdk.org/series/16694/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92239/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92239/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C465EA0546;\n\tTue, 27 Apr 2021 11:16:56 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4124A40150;\n\tTue, 27 Apr 2021 11:16:56 +0200 (CEST)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id 845DF4003E\n for <dev@dpdk.org>; Tue, 27 Apr 2021 11:16:54 +0200 (CEST)", "from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FTx0b449Bz17Rnq\n for <dev@dpdk.org>; Tue, 27 Apr 2021 17:14:23 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id\n 14.3.498.0; Tue, 27 Apr 2021 17:16:44 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <humin29@huawei.com>", "Date": "Tue, 27 Apr 2021 17:16:54 +0800", "Message-ID": "<1619515014-19181-1-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619075569-33619-1-git-send-email-humin29@huawei.com>", "References": "<1619075569-33619-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v2] net/bonding: fix socket id check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nThe socket ID entered by user is cast to an unsigned integer. However,\nthe value may be an illegal negative value, which may cause some\nproblems. In this case, an error should be returned.\n\nIn addition, the socket ID may be an invalid positive number, which is\nalso processed in this patch.\n\nFixes: 2efb58cbab6e (\"bond: new link bonding library\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\nv2:\n* fixed socket id type.\n---\n drivers/net/bonding/rte_eth_bond_args.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c\nindex 8c5f90d..977f3fe 100644\n--- a/drivers/net/bonding/rte_eth_bond_args.c\n+++ b/drivers/net/bonding/rte_eth_bond_args.c\n@@ -207,13 +207,13 @@ bond_ethdev_parse_socket_id_kvarg(const char *key __rte_unused,\n \t\treturn -1;\n \n \terrno = 0;\n-\tsocket_id = (uint8_t)strtol(value, &endptr, 10);\n+\tsocket_id = (int)strtol(value, &endptr, 10);\n \tif (*endptr != 0 || errno != 0)\n \t\treturn -1;\n \n \t/* validate socket id value */\n-\tif (socket_id >= 0) {\n-\t\t*(uint8_t *)extra_args = (uint8_t)socket_id;\n+\tif (socket_id >= 0 && socket_id < RTE_MAX_NUMA_NODES) {\n+\t\t*(int *)extra_args = socket_id;\n \t\treturn 0;\n \t}\n \treturn -1;\n", "prefixes": [ "v2" ] }