Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92180/?format=api
{ "id": 92180, "url": "http://patches.dpdk.org/api/patches/92180/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210426133519.4777-1-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210426133519.4777-1-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210426133519.4777-1-konstantin.ananyev@intel.com", "date": "2021-04-26T13:35:19", "name": "[v2] acl: fix build with gcc 11", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a57afa512f1d3d109eac0eacc1bc60827efd1cb1", "submitter": { "id": 33, "url": "http://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210426133519.4777-1-konstantin.ananyev@intel.com/mbox/", "series": [ { "id": 16677, "url": "http://patches.dpdk.org/api/series/16677/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16677", "date": "2021-04-26T13:35:19", "name": "[v2] acl: fix build with gcc 11", "version": 2, "mbox": "http://patches.dpdk.org/series/16677/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92180/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/92180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AC32AA0548;\n\tMon, 26 Apr 2021 15:35:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 93CD241104;\n\tMon, 26 Apr 2021 15:35:42 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 1487E40140;\n Mon, 26 Apr 2021 15:35:40 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Apr 2021 06:35:39 -0700", "from sivswdev08.ir.intel.com ([10.237.217.47])\n by fmsmga004.fm.intel.com with ESMTP; 26 Apr 2021 06:35:38 -0700" ], "IronPort-SDR": [ "\n alOjCmpJwx/+bE+zxxFSos+K3xJfuV7nfUMvek1F9YxudW6wc6cQWG/ssD81Zs5vKiehXntWqy\n ITOpHY5lbu1Q==", "\n 3nd9y/S9V1sRhqY9rT4JhINCAus02FOtJpkMYDNoOMfrGc/VwBQJN2F6t6hM4VAzHVKPQ0/ewi\n zE3Nz6mjJQLg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9966\"; a=\"281665523\"", "E=Sophos;i=\"5.82,252,1613462400\"; d=\"scan'208\";a=\"281665523\"", "E=Sophos;i=\"5.82,252,1613462400\"; d=\"scan'208\";a=\"447277382\"" ], "X-ExtLoop1": "1", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Cc": "Konstantin Ananyev <konstantin.ananyev@intel.com>,\n\tstable@dpdk.org", "Date": "Mon, 26 Apr 2021 14:35:19 +0100", "Message-Id": "<20210426133519.4777-1-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20210423135451.11035-1-konstantin.ananyev@intel.com>", "References": "<20210423135451.11035-1-konstantin.ananyev@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] acl: fix build with gcc 11", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "gcc 11 with '-O2' complains about some variables being used without\nbeing initialized:\n\nIn file included from ../lib/librte_acl/acl_run_avx512x8.h:201,\n from ../lib/librte_acl/acl_run_avx512.c:110:\nIn function ‘start_flow_avx512x8’,\n inlined from ‘search_trie_avx512x8.constprop’ at ../lib/librte_acl/acl_run_avx512_common.h:317:2:\n../lib/librte_acl/acl_run_avx512_common.h:210:13: warning: ‘pdata’ is used uninitialized [-Wuninitialized]\nIn file included from ../lib/librte_acl/acl_run_avx512x8.h:201,\n from ../lib/librte_acl/acl_run_avx512.c:110:\n../lib/librte_acl/acl_run_avx512_common.h: In function ‘search_trie_avx512x8.constprop’:\n../lib/librte_acl/acl_run_avx512_common.h:314:32: note: ‘pdata’ declared here\nIn file included from ../lib/librte_acl/acl_run_avx512x8.h:201,\n from ../lib/librte_acl/acl_run_avx512.c:110:\n....\n\nIndeed, these variables are not explicitly initialized,\nbut this is done intentionally.\nWe rely on constant mask value that we pass to start_flow*() functions\nas a parameter to mask out uninitialized values.\nNote that '-O3' doesn't produce this warning.\nAnyway, to support clean build with gcc-11 this patch adds\nexplicit initialization for these variables.\nI checked the output binary: with '-O3' both clang and gcc 10/11\ngenerate no extra code for it.\nAlso performance test didn't reveal any regressions.\n\nBugzilla ID: 673\nFixes: b64c2295f7fc (\"acl: add 256-bit AVX512 classify method\")\nFixes: 45da22e42ec3 (\"acl: add 512-bit AVX512 classify method\")\nCc: stable@dpdk.org\n\nReported-by: Ali Alnubani <alialnu@nvidia.com>\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\nv2: update commit log\n---\n lib/acl/acl_run_avx512_common.h | 24 ++++++++++++++++++++++++\n 1 file changed, 24 insertions(+)", "diff": "diff --git a/lib/acl/acl_run_avx512_common.h b/lib/acl/acl_run_avx512_common.h\nindex fafaf591e..fbad74d45 100644\n--- a/lib/acl/acl_run_avx512_common.h\n+++ b/lib/acl/acl_run_avx512_common.h\n@@ -303,6 +303,28 @@ _F_(match_check_process)(struct acl_flow_avx512 *flow, uint32_t fm[2],\n \t}\n }\n \n+static inline void\n+_F_(reset_flow_vars)(_T_simd di[2], _T_simd idx[2], _T_simd pdata[4],\n+\t_T_simd tr_lo[2], _T_simd tr_hi[2])\n+{\n+\tdi[0] = _M_SI_(setzero)();\n+\tdi[1] = _M_SI_(setzero)();\n+\n+\tidx[0] = _M_SI_(setzero)();\n+\tidx[1] = _M_SI_(setzero)();\n+\n+\tpdata[0] = _M_SI_(setzero)();\n+\tpdata[1] = _M_SI_(setzero)();\n+\tpdata[2] = _M_SI_(setzero)();\n+\tpdata[3] = _M_SI_(setzero)();\n+\n+\ttr_lo[0] = _M_SI_(setzero)();\n+\ttr_lo[1] = _M_SI_(setzero)();\n+\n+\ttr_hi[0] = _M_SI_(setzero)();\n+\ttr_hi[1] = _M_SI_(setzero)();\n+}\n+\n /*\n * Perform search for up to (2 * _N_) flows in parallel.\n * Use two sets of metadata, each serves _N_ flows max.\n@@ -313,6 +335,8 @@ _F_(search_trie)(struct acl_flow_avx512 *flow)\n \tuint32_t fm[2];\n \t_T_simd di[2], idx[2], in[2], pdata[4], tr_lo[2], tr_hi[2];\n \n+\t_F_(reset_flow_vars)(di, idx, pdata, tr_lo, tr_hi);\n+\n \t/* first 1B load */\n \t_F_(start_flow)(flow, _SIMD_MASK_BIT_, _SIMD_MASK_MAX_,\n \t\t\t&pdata[0], &idx[0], &di[0]);\n", "prefixes": [ "v2" ] }