Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92110/?format=api
{ "id": 92110, "url": "http://patches.dpdk.org/api/patches/92110/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210425050454.12324-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210425050454.12324-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210425050454.12324-1-alvinx.zhang@intel.com", "date": "2021-04-25T05:04:54", "name": "net/iavf: fix PF returning error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "644c7c4db90e661058c24e1ae073cf83c2f98393", "submitter": { "id": 1398, "url": "http://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210425050454.12324-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 16644, "url": "http://patches.dpdk.org/api/series/16644/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16644", "date": "2021-04-25T05:04:54", "name": "net/iavf: fix PF returning error", "version": 1, "mbox": "http://patches.dpdk.org/series/16644/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92110/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92110/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ECE04A0548;\n\tSun, 25 Apr 2021 07:05:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B580940685;\n\tSun, 25 Apr 2021 07:05:06 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 13E1A4013F;\n Sun, 25 Apr 2021 07:05:04 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2021 22:05:03 -0700", "from shwdenpg235.ccr.corp.intel.com ([10.240.182.60])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2021 22:05:01 -0700" ], "IronPort-SDR": [ "\n 4EYO1vA7KDv0Zc/1GQTo9780Pvlji2CWHrcOlriBzxygv+iJ1i0zJrUmm/OpIyBm/2i4/eIoG2\n Y7NTw+du91Sg==", "\n GkfR3yFGgIz38YtSLpwtIi0aJwvdfGHzgShUetFWOIC7yni7sTOH85HbFsWlHw28XJ27r3a14m\n +BtR3vm4meJQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9964\"; a=\"175695596\"", "E=Sophos;i=\"5.82,249,1613462400\"; d=\"scan'208\";a=\"175695596\"", "E=Sophos;i=\"5.82,249,1613462400\"; d=\"scan'208\";a=\"464744621\"" ], "From": "Alvin Zhang <alvinx.zhang@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Sun, 25 Apr 2021 13:04:54 +0800", "Message-Id": "<20210425050454.12324-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/iavf: fix PF returning error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the command sent by VF to PF fails, iavf may need to run\ndifferent code paths according to the specific reason of the\nfailure (not supported or other reasons).\n\nThis patch adds support of identifying PF return error type.\n\nFixes: 22b123a36d07 (\"net/avf: initialize PMD\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n drivers/net/iavf/iavf_vchnl.c | 18 ++++++++++++------\n 1 file changed, 12 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c\nindex 45096cb..6586fc3 100644\n--- a/drivers/net/iavf/iavf_vchnl.c\n+++ b/drivers/net/iavf/iavf_vchnl.c\n@@ -228,13 +228,19 @@\n \t\t\trte_delay_ms(ASQ_DELAY_MS);\n \t\t\t/* If don't read msg or read sys event, continue */\n \t\t} while (i++ < MAX_TRY_TIMES);\n-\t\t/* If there's no response is received, clear command */\n-\t\tif (i >= MAX_TRY_TIMES ||\n-\t\t vf->cmd_retval != VIRTCHNL_STATUS_SUCCESS) {\n-\t\t\terr = -1;\n-\t\t\tPMD_DRV_LOG(ERR, \"No response or return failure (%d)\"\n-\t\t\t\t \" for cmd %d\", vf->cmd_retval, args->ops);\n+\n+\t\tif (i >= MAX_TRY_TIMES) {\n+\t\t\tPMD_DRV_LOG(ERR, \"No response for cmd %d\", args->ops);\n \t\t\t_clear_cmd(vf);\n+\t\t\terr = -EIO;\n+\t\t} else if (vf->cmd_retval ==\n+\t\t\t (uint32_t)VIRTCHNL_STATUS_ERR_NOT_SUPPORTED) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Cmd %d not supported\", args->ops);\n+\t\t\terr = -ENOTSUP;\n+\t\t} else if (vf->cmd_retval != VIRTCHNL_STATUS_SUCCESS) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Return failure %d for cmd %d\",\n+\t\t\t\t vf->cmd_retval, args->ops);\n+\t\t\terr = -EINVAL;\n \t\t}\n \t\tbreak;\n \t}\n", "prefixes": [] }